From patchwork Tue Jun 7 01:37:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Benjamin Herrenschmidt X-Patchwork-Id: 9159699 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0146E60759 for ; Tue, 7 Jun 2016 01:45:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DBD93264F4 for ; Tue, 7 Jun 2016 01:45:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BEB9D2833E; Tue, 7 Jun 2016 01:45:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 39AD7264F4 for ; Tue, 7 Jun 2016 01:45:38 +0000 (UTC) Received: from localhost ([::1]:46404 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA65J-0005E9-W6 for patchwork-qemu-devel@patchwork.kernel.org; Mon, 06 Jun 2016 21:45:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA62J-00039u-UY for qemu-devel@nongnu.org; Mon, 06 Jun 2016 21:42:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bA62J-0006EM-2o for qemu-devel@nongnu.org; Mon, 06 Jun 2016 21:42:31 -0400 Received: from gate.crashing.org ([63.228.1.57]:51815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA62I-0006E4-PW; Mon, 06 Jun 2016 21:42:31 -0400 Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id u571bKNp010304; Mon, 6 Jun 2016 20:37:21 -0500 Message-ID: <1465263439.23889.12.camel@kernel.crashing.org> From: Benjamin Herrenschmidt To: qemu-ppc@nongnu.org Date: Tue, 07 Jun 2016 11:37:19 +1000 X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) Mime-Version: 1.0 X-MIME-Autoconverted: from 8bit to base64 by gate.crashing.org id u571bKNp010304 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 63.228.1.57 Subject: [Qemu-devel] [PATCH 6/6] ppc: Do not take exceptions on unknown SPRs in privileged mode X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?ISO-8859-1?Q?C=E9dric?= Le Goater , qemu-devel@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP The architecture specifies that mtspr/mfspr on an unknown SPR number should act as a nop in privileged mode. I haven't removed the warning however as it can be useful for diagnosing. Signed-off-by: Benjamin Herrenschmidt ---  target-ppc/translate.c | 11 +++++++++--  1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index a3de142..dd0ecc8 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -4351,7 +4351,10 @@ static inline void gen_op_mfspr(DisasContext *ctx)              qemu_log("Trying to read invalid spr %d (0x%03x) at "                       TARGET_FMT_lx "\n", sprn, sprn, ctx->nip - 4);          } -        gen_inval_exception(ctx, POWERPC_EXCP_INVAL_SPR); +        /* Only generate an exception in user space, otherwise this is a nop */ +        if (ctx->pr) { +            gen_inval_exception(ctx, POWERPC_EXCP_INVAL_SPR); +        }      }  }   @@ -4503,7 +4506,11 @@ static void gen_mtspr(DisasContext *ctx)          }          fprintf(stderr, "Trying to write invalid spr %d (0x%03x) at "                  TARGET_FMT_lx "\n", sprn, sprn, ctx->nip - 4); -        gen_inval_exception(ctx, POWERPC_EXCP_INVAL_SPR); + +        /* Only generate an exception in user space, otherwise this is a nop */ +        if (ctx->pr) { +            gen_inval_exception(ctx, POWERPC_EXCP_INVAL_SPR); +        }      }  }