From patchwork Wed Jun 8 10:54:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alberto Garcia X-Patchwork-Id: 9164253 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 55EAC60572 for ; Wed, 8 Jun 2016 10:55:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3F49825819 for ; Wed, 8 Jun 2016 10:55:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 33C32206AC; Wed, 8 Jun 2016 10:55:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 04ED2206AC for ; Wed, 8 Jun 2016 10:55:33 +0000 (UTC) Received: from localhost ([::1]:55981 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAb91-0001VM-9g for patchwork-qemu-devel@patchwork.kernel.org; Wed, 08 Jun 2016 06:55:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAb8k-0001V5-DH for qemu-devel@nongnu.org; Wed, 08 Jun 2016 06:55:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAb8f-00010c-E4 for qemu-devel@nongnu.org; Wed, 08 Jun 2016 06:55:13 -0400 Received: from smtp3.mundo-r.com ([212.51.32.191]:49740 helo=smtp4.mundo-r.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAb8f-0000wo-6A; Wed, 08 Jun 2016 06:55:09 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2CHAwAO+VdX/5tjdVtdKgGDE4FTpj8FAYEPAZElgg+BeRKGAYE9OBQBAQEBAQEBZSeFRU9ONIgzAb09hV+JJXyEchwFjlmJdo4mAolChVkCj2EeNoE2AQuCL2uIS4FEAQEB X-IPAS-Result: A2CHAwAO+VdX/5tjdVtdKgGDE4FTpj8FAYEPAZElgg+BeRKGAYE9OBQBAQEBAQEBZSeFRU9ONIgzAb09hV+JJXyEchwFjlmJdo4mAolChVkCj2EeNoE2AQuCL2uIS4FEAQEB X-IronPort-AV: E=Sophos;i="5.26,438,1459807200"; d="scan'208";a="70751388" Received: from fanzine.igalia.com ([91.117.99.155]) by smtp4.mundo-r.com with ESMTP; 08 Jun 2016 12:55:06 +0200 Received: from [194.100.51.2] (helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim) id 1bAb8b-0000dL-S4; Wed, 08 Jun 2016 12:55:06 +0200 Received: from berto by perseus.local with local (Exim 4.87) (envelope-from ) id 1bAb8M-0001pt-2S; Wed, 08 Jun 2016 13:54:50 +0300 From: Alberto Garcia To: qemu-devel@nongnu.org Date: Wed, 8 Jun 2016 13:54:48 +0300 Message-Id: <1465383288-7021-1-git-send-email-berto@igalia.com> X-Mailer: git-send-email 2.8.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 212.51.32.191 Subject: [Qemu-devel] [PATCH] docs: Fix description of the leaky bucket algorithm in throttle.txt X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Michael Tokarev , Alberto Garcia Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Commit 0bab0ebb17759c926bd48fd396bd8cbb2c8e4a3e was supposed to fix a mistake in the description of the leaky bucket algorithm, but the version that finally landed after the review process was incorrect. This patch solves that problem and hopefully clarifies the description a bit better. Signed-off-by: Alberto Garcia --- docs/throttle.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/throttle.txt b/docs/throttle.txt index 26d4d51..cd4e109 100644 --- a/docs/throttle.txt +++ b/docs/throttle.txt @@ -235,7 +235,10 @@ consider the following values: - Water leaks from the bucket at a rate of 100 IOPS. - Water can be added to the bucket at a rate of 2000 IOPS. - The size of the bucket is 2000 x 60 = 120000 - - If 'iops-total-max' is unset then the bucket size is 100 x 60. + - If 'iops-total-max-length' is unset then it defaults to 1 and the + size of the bucket is 2000. + - If 'iops-total-max' is unset then 'iops-total-max-length' must be + unset as well. In this case the bucket size is 100. The bucket is initially empty, therefore water can be added until it's full at a rate of 2000 IOPS (the burst rate). Once the bucket is full