From patchwork Fri Jun 10 02:48:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Blake X-Patchwork-Id: 9168783 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7EEF06048F for ; Fri, 10 Jun 2016 02:54:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6969A2830C for ; Fri, 10 Jun 2016 02:54:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4C4122835E; Fri, 10 Jun 2016 02:54:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 09C042830C for ; Fri, 10 Jun 2016 02:54:51 +0000 (UTC) Received: from localhost ([::1]:38105 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBCaw-0006fS-Hv for patchwork-qemu-devel@patchwork.kernel.org; Thu, 09 Jun 2016 22:54:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBCUn-00022t-3w for qemu-devel@nongnu.org; Thu, 09 Jun 2016 22:48:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBCUl-0006ww-AT for qemu-devel@nongnu.org; Thu, 09 Jun 2016 22:48:28 -0400 Received: from resqmta-po-01v.sys.comcast.net ([2001:558:fe16:19:96:114:154:160]:54572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBCUl-0006wf-5E for qemu-devel@nongnu.org; Thu, 09 Jun 2016 22:48:27 -0400 Received: from resomta-po-20v.sys.comcast.net ([96.114.154.244]) by resqmta-po-01v.sys.comcast.net with SMTP id BCU0boaygkzylBCUkbNNub; Fri, 10 Jun 2016 02:48:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1465526906; bh=4tsVxx95V8ArAG7uTjbI7xIeNksvoc7OkW2+H03cZCc=; h=Received:Received:From:To:Subject:Date:Message-Id; b=TcBnXUhLbNu8HzKe00GAHqcilBRDJZm7jw2azZXJQShOGPS5o5CW+UpXJfaEk5Kmt Y800cBzMPp1X+o5RTZ4PUHDpqCar+5xy/Lf9p7WWyaSRXlwxgGrqnLdxUxI4Aesd8n dh+pmO6+C6D554CEMWmdBMWdIUCTXle/bNdgxUnh5/eetpdQXyRKTB55EqXB1YMy34 cK41wjwrfeu4mVwO5hIR8nd8SSQJUx+r26+artHq1LolcYEnes7Q4Mpd9F7Zw98Pak PHJVg64x5SHk8fnt9UEJcoxv8KTH0FQiVV4kSP7kRv/vgc/ohPcBWaodaBucAKbqcM +7XUPB6RwtXkQ== Received: from red.redhat.com ([24.10.254.122]) by resomta-po-20v.sys.comcast.net with comcast id 4qo91t00F2fD5rL01qoSGn; Fri, 10 Jun 2016 02:48:26 +0000 From: Eric Blake To: qemu-devel@nongnu.org Date: Thu, 9 Jun 2016 20:48:07 -0600 Message-Id: <1465526889-8339-3-git-send-email-eblake@redhat.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1465526889-8339-1-git-send-email-eblake@redhat.com> References: <1465526889-8339-1-git-send-email-eblake@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:558:fe16:19:96:114:154:160 Subject: [Qemu-devel] [PATCH 2/4] checkpatch: There is no qemu_strtod() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Blue Swirl , armbru@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Maybe there should be; but until there is, we should not flag strtod() calls as something to replaced with qemu_strtod(). We also lack qemu_strtof() and qemu_strtold(), but as no one has been using strtof() or strtold(), it's not worth complicating the regex for them. (Ironically, I had to use 'git commit -n' since checkpatch uses TAB indents, in violation of its own recommendations.) Signed-off-by: Eric Blake Reviewed-by: Markus Armbruster --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c939a32..cf32c8f 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2453,7 +2453,7 @@ sub process { } # recommend qemu_strto* over strto* for numeric conversions - if ($line =~ /\b(strto[^k].*?)\s*\(/) { + if ($line =~ /\b(strto[^kd].*?)\s*\(/) { WARN("consider using qemu_$1 in preference to $1\n" . $herecurr); } # check for module_init(), use category-specific init macros explicitly please