diff mbox

qom/object: fix comment typo

Message ID 1465889269-7226-1-git-send-email-xiecl.fnst@cn.fujitsu.com (mailing list archive)
State New, archived
Headers show

Commit Message

Changlong Xie June 14, 2016, 7:27 a.m. UTC
Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
---
 include/qom/object.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Vivier June 14, 2016, 7:28 a.m. UTC | #1
On 14/06/2016 09:27, Changlong Xie wrote:
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>

Reviewed-by: Laurent Vivier <lvivier@redhat.com>

> ---
>  include/qom/object.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/qom/object.h b/include/qom/object.h
> index 99de539..925c279 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -901,7 +901,7 @@ GSList *object_class_get_list(const char *implements_type,
>  void object_ref(Object *obj);
>  
>  /**
> - * qdef_unref:
> + * object_unref:
>   * @obj: the object
>   *
>   * Decrease the reference count of a object.  A object cannot be freed as long
>
Changlong Xie July 6, 2016, 5:52 a.m. UTC | #2
Would any maintainer pick this one?

On 06/14/2016 03:27 PM, Changlong Xie wrote:
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> ---
>   include/qom/object.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/qom/object.h b/include/qom/object.h
> index 99de539..925c279 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -901,7 +901,7 @@ GSList *object_class_get_list(const char *implements_type,
>   void object_ref(Object *obj);
>
>   /**
> - * qdef_unref:
> + * object_unref:
>    * @obj: the object
>    *
>    * Decrease the reference count of a object.  A object cannot be freed as long
>
Andreas Färber July 6, 2016, 7:21 a.m. UTC | #3
Am 06.07.2016 um 07:52 schrieb Changlong Xie:
> Would any maintainer pick this one?

Please in the future use just "qom:" in the subject. How to find out?
git log --oneline -- include/qom/object.h

Also please mention the typo in the commit message. Fixing.

Thanks,
Andreas

> 
> On 06/14/2016 03:27 PM, Changlong Xie wrote:
>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>> ---
>>   include/qom/object.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/qom/object.h b/include/qom/object.h
>> index 99de539..925c279 100644
>> --- a/include/qom/object.h
>> +++ b/include/qom/object.h
>> @@ -901,7 +901,7 @@ GSList *object_class_get_list(const char
>> *implements_type,
>>   void object_ref(Object *obj);
>>
>>   /**
>> - * qdef_unref:
>> + * object_unref:
>>    * @obj: the object
>>    *
>>    * Decrease the reference count of a object.  A object cannot be
>> freed as long
>>
> 
>
Changlong Xie July 6, 2016, 7:44 a.m. UTC | #4
On 07/06/2016 03:21 PM, Andreas Färber wrote:
> Am 06.07.2016 um 07:52 schrieb Changlong Xie:
>> Would any maintainer pick this one?
>
> Please in the future use just "qom:" in the subject. How to find out?

Ok

> git log --oneline -- include/qom/object.h

Useful git command, i'll add it to my bash aliases

>
> Also please mention the typo in the commit message. Fixing.
>

Yep

Thanks
	-Xie

> Thanks,
> Andreas
>
>>
>> On 06/14/2016 03:27 PM, Changlong Xie wrote:
>>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>>> ---
>>>    include/qom/object.h | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/qom/object.h b/include/qom/object.h
>>> index 99de539..925c279 100644
>>> --- a/include/qom/object.h
>>> +++ b/include/qom/object.h
>>> @@ -901,7 +901,7 @@ GSList *object_class_get_list(const char
>>> *implements_type,
>>>    void object_ref(Object *obj);
>>>
>>>    /**
>>> - * qdef_unref:
>>> + * object_unref:
>>>     * @obj: the object
>>>     *
>>>     * Decrease the reference count of a object.  A object cannot be
>>> freed as long
>>>
>>
>>
>
>
diff mbox

Patch

diff --git a/include/qom/object.h b/include/qom/object.h
index 99de539..925c279 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -901,7 +901,7 @@  GSList *object_class_get_list(const char *implements_type,
 void object_ref(Object *obj);
 
 /**
- * qdef_unref:
+ * object_unref:
  * @obj: the object
  *
  * Decrease the reference count of a object.  A object cannot be freed as long