| Message ID | 1466169069-29375-10-git-send-email-real@ispras.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 17/06/2016 15:11, Efimov Vasily wrote: > ICH9 SMB bridge can be created using qdev API despite existence of helper > function. The type name is needed for such creation. Using a preprocessor > alias instead the string type name itself is preferable. > > The patch makes the alias accessible through the header. > > Signed-off-by: Efimov Vasily <real@ispras.ru> > --- > hw/i2c/smbus_ich9.c | 1 - > include/hw/i386/ich9.h | 2 ++ > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/i2c/smbus_ich9.c b/hw/i2c/smbus_ich9.c > index 498f03e..48fab22 100644 > --- a/hw/i2c/smbus_ich9.c > +++ b/hw/i2c/smbus_ich9.c > @@ -35,7 +35,6 @@ > > #include "hw/i386/ich9.h" > > -#define TYPE_ICH9_SMB_DEVICE "ICH9 SMB" > #define ICH9_SMB_DEVICE(obj) \ > OBJECT_CHECK(ICH9SMBState, (obj), TYPE_ICH9_SMB_DEVICE) > > diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h > index 88233c3..f1294bc 100644 > --- a/include/hw/i386/ich9.h > +++ b/include/hw/i386/ich9.h > @@ -208,6 +208,8 @@ Object *ich9_lpc_find(void); > > > /* D31:F3 SMBus controller */ > +#define TYPE_ICH9_SMB_DEVICE "ICH9 SMB" > + > #define ICH9_A2_SMB_REVISION 0x02 > #define ICH9_SMB_PI 0x00 > > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
diff --git a/hw/i2c/smbus_ich9.c b/hw/i2c/smbus_ich9.c index 498f03e..48fab22 100644 --- a/hw/i2c/smbus_ich9.c +++ b/hw/i2c/smbus_ich9.c @@ -35,7 +35,6 @@ #include "hw/i386/ich9.h" -#define TYPE_ICH9_SMB_DEVICE "ICH9 SMB" #define ICH9_SMB_DEVICE(obj) \ OBJECT_CHECK(ICH9SMBState, (obj), TYPE_ICH9_SMB_DEVICE) diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h index 88233c3..f1294bc 100644 --- a/include/hw/i386/ich9.h +++ b/include/hw/i386/ich9.h @@ -208,6 +208,8 @@ Object *ich9_lpc_find(void); /* D31:F3 SMBus controller */ +#define TYPE_ICH9_SMB_DEVICE "ICH9 SMB" + #define ICH9_A2_SMB_REVISION 0x02 #define ICH9_SMB_PI 0x00
ICH9 SMB bridge can be created using qdev API despite existence of helper function. The type name is needed for such creation. Using a preprocessor alias instead the string type name itself is preferable. The patch makes the alias accessible through the header. Signed-off-by: Efimov Vasily <real@ispras.ru> --- hw/i2c/smbus_ich9.c | 1 - include/hw/i386/ich9.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-)