From patchwork Mon Jun 20 14:39:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 9187663 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3466D601C0 for ; Mon, 20 Jun 2016 14:43:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 223FA2787D for ; Mon, 20 Jun 2016 14:43:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 16DD32793D; Mon, 20 Jun 2016 14:43:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 97AE92787D for ; Mon, 20 Jun 2016 14:43:37 +0000 (UTC) Received: from localhost ([::1]:44060 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF0QJ-0007ux-LV for patchwork-qemu-devel@patchwork.kernel.org; Mon, 20 Jun 2016 10:43:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF0MK-00023o-2g for qemu-devel@nongnu.org; Mon, 20 Jun 2016 10:39:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bF0MH-000503-AT for qemu-devel@nongnu.org; Mon, 20 Jun 2016 10:39:26 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:34975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF0MH-0004zr-3n for qemu-devel@nongnu.org; Mon, 20 Jun 2016 10:39:25 -0400 Received: by mail-wm0-x243.google.com with SMTP id a66so9520133wme.2 for ; Mon, 20 Jun 2016 07:39:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=3ysWMshpkYZbHHC3D73S/GvNxpCaxnSofqyEQMUMn60=; b=1GU7S+p4KUT9lQFg6Knj93O0rBeWfGiA227Ynmwy2eFzuuwYQmWn1ZiXSD75vVwLxw UzzvqPhySwmfhTYDCvv+aMuOXSVA44w5kiAZuppn5gu0AiqRNMMiz+eduK3B+O4ztprt Jhs3Qn1U8Gf+jj08Dl2manSSFSDtpmolWMqJBtjBFp6gnuL5Dao/Ktjd7hOlX6t+zRwJ qqXYTH/t9jLuqEEMaHrE6amK3FrWfUELsh8wPf99+N64ajMJXvs3WXYxhYTljAXrOGNb hiryH/UICngrW1S9R9OF+atHGOHJGgCk3gNp3tTNqi9PnJAx/OX4pwALWv0Xpe1t+zUm 41Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=3ysWMshpkYZbHHC3D73S/GvNxpCaxnSofqyEQMUMn60=; b=GjlJ6XtIEGYGzwiKGHQbopEYtx7XTE/osAwdcQClVbzpFC5ueJC1gPlrUNS3Y+wF3w qrG6VxWyDRzIUckShGjFDmTUSC83nk0eX61eGz8wp9EBVNOMilEi3ICDpTM5l+TWU5nU dSCkZgglBkaHAm9C/TOmqkD4y3yOLo50RGrjMKnF6j6qVsYkgFXfYOuDxJ5+/fV9dTyN VvIrBPuggXT+LDp5LFLngqqtYqDVflsnAkGE10lim4q08cI86y5Z2KeJwBeB2z9YQ0/8 c05Vli9N5eB3TXYG74jBaaoAuggJrLe5V6x91S5sHRJtJ+2pmJFlPcs9UNR2xWxrCWqx GVpw== X-Gm-Message-State: ALyK8tK4Lh3hfgz1ws+YI3p2cdlNGeduySFnKAaMQ/igLvAMtIcIsGgw+6n2Ccl+s7SSKg== X-Received: by 10.194.123.199 with SMTP id mc7mr14848879wjb.12.1466433562455; Mon, 20 Jun 2016 07:39:22 -0700 (PDT) Received: from donizetti.lan (94-39-188-118.adsl-ull.clienti.tiscali.it. [94.39.188.118]) by smtp.gmail.com with ESMTPSA id r127sm7910146wmf.21.2016.06.20.07.39.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jun 2016 07:39:21 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 20 Jun 2016 16:39:17 +0200 Message-Id: <1466433559-30930-2-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1466433559-30930-1-git-send-email-pbonzini@redhat.com> References: <1466433559-30930-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::243 Subject: [Qemu-devel] [PATCH 1/3] ich9: call ich9_lpc_update_pic for disabled pirqs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: real@ispras.ru Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP An asserted pirq can be disabled and the corresponding GSIs should then go down to 0. However, because of the conditional in ich9_lpc_update_by_pirq, the legacy 8259 pin could remain stuck to 1. Signed-off-by: Paolo Bonzini Reviewed-by: Efimov Vasily --- hw/isa/lpc_ich9.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index 213741b..b116e1b 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -234,9 +234,6 @@ static void ich9_lpc_update_by_pirq(ICH9LPCState *lpc, int pirq) ich9_lpc_pic_irq(lpc, pirq, &pic_irq, &pic_dis); assert(pic_irq < ICH9_LPC_PIC_NUM_PINS); - if (pic_dis) { - return; - } ich9_lpc_update_pic(lpc, pic_irq); }