[v5,13/15] blockdev-backup: added support for data compression

Commit Message

Denis V. Lunev July 4, 2016, 12:28 p.m. UTC

From: Pavel Butsykin <[e-mail]>

The idea is simple - backup is "written-once" data. It is written block
by block and it is large enough. It would be nice to save storage
space and compress it.

Signed-off-by: Pavel Butsykin <[e-mail]>
Reviewed-by: Stefan Hajnoczi <[e-mail]>
Signed-off-by: Denis V. Lunev <[e-mail]>
CC: Jeff Cody <[e-mail]>
CC: Markus Armbruster <[e-mail]>
CC: Eric Blake <[e-mail]>
CC: John Snow <[e-mail]>
CC: Stefan Hajnoczi <[e-mail]>
CC: Kevin Wolf <[e-mail]>
---
 blockdev.c           | 9 ++++++---
 qapi/block-core.json | 4 ++++
 qmp-commands.hx      | 4 +++-
 3 files changed, 13 insertions(+), 4 deletions(-)

Comments

Stefan Hajnoczi July 14, 2016, 12:17 p.m. UTC | #1

On Mon, Jul 04, 2016 at 03:28:24PM +0300, Denis V. Lunev wrote:
> From: Pavel Butsykin <[e-mail]>
> 
> The idea is simple - backup is "written-once" data. It is written block
> by block and it is large enough. It would be nice to save storage
> space and compress it.
> 
> Signed-off-by: Pavel Butsykin <[e-mail]>
> Reviewed-by: Stefan Hajnoczi <[e-mail]>
> Signed-off-by: Denis V. Lunev <[e-mail]>
> CC: Jeff Cody <[e-mail]>
> CC: Markus Armbruster <[e-mail]>
> CC: Eric Blake <[e-mail]>
> CC: John Snow <[e-mail]>
> CC: Stefan Hajnoczi <[e-mail]>
> CC: Kevin Wolf <[e-mail]>
> ---
>  blockdev.c           | 9 ++++++---
>  qapi/block-core.json | 4 ++++
>  qmp-commands.hx      | 4 +++-
>  3 files changed, 13 insertions(+), 4 deletions(-)

Reviewed-by: Stefan Hajnoczi <[e-mail]>

Patch

diff --git a/blockdev.c b/blockdev.c
index fa88900..279af57 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3277,6 +3277,9 @@  void do_blockdev_backup(BlockdevBackup *backup, BlockJobTxn *txn, Error **errp)
     if (!backup->has_on_target_error) {
         backup->on_target_error = BLOCKDEV_ON_ERROR_REPORT;
     }
+    if (!backup->has_compress) {
+        backup->compress = false;
+    }
 
     blk = blk_by_name(backup->device);
     if (!blk) {
@@ -3309,9 +3312,9 @@  void do_blockdev_backup(BlockdevBackup *backup, BlockJobTxn *txn, Error **errp)
             goto out;
         }
     }
-    backup_start(bs, target_bs, backup->speed, backup->sync, NULL, false,
-                 backup->on_source_error, backup->on_target_error, block_job_cb,
-                 bs, txn, &local_err);
+    backup_start(bs, target_bs, backup->speed, backup->sync, NULL,
+                 backup->compress, backup->on_source_error,
+                 backup->on_target_error, block_job_cb, bs, txn, &local_err);
     if (local_err != NULL) {
         error_propagate(errp, local_err);
     }
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 0cbad5a..386c7ff 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -926,6 +926,9 @@ 
 # @speed: #optional the maximum speed, in bytes per second. The default is 0,
 #         for unlimited.
 #
+# @compress: #optional true to compress data, if the target format supports it.
+#            (default: false) (since 2.7)
+#
 # @on-source-error: #optional the action to take on an error on the source,
 #                   default 'report'.  'stop' and 'enospc' can only be used
 #                   if the block device supports io-status (see BlockInfo).
@@ -944,6 +947,7 @@ 
   'data': { 'device': 'str', 'target': 'str',
             'sync': 'MirrorSyncMode',
             '*speed': 'int',
+            '*compress': 'bool',
             '*on-source-error': 'BlockdevOnError',
             '*on-target-error': 'BlockdevOnError' } }
 
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 810d0fe..2cf6e1f 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -1269,7 +1269,7 @@  EQMP
 
     {
         .name       = "blockdev-backup",
-        .args_type  = "sync:s,device:B,target:B,speed:i?,"
+        .args_type  = "sync:s,device:B,target:B,speed:i?,compress:b?,"
                       "on-source-error:s?,on-target-error:s?",
         .mhandler.cmd_new = qmp_marshal_blockdev_backup,
     },
@@ -1291,6 +1291,8 @@  Arguments:
           sectors allocated in the topmost image, or "none" to only replicate
           new I/O (MirrorSyncMode).
 - "speed": the maximum speed, in bytes per second (json-int, optional)
+- "compress": true to compress data, if the target format supports it.
+              (json-bool, optional, default false)
 - "on-source-error": the action to take on an error on the source, default
                      'report'.  'stop' and 'enospc' can only be used
                      if the block device supports io-status.