Message ID | 1467891446-22267-7-git-send-email-pl@kamp.de (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3BA426048B for <patchwork-qemu-devel@patchwork.kernel.org>; Thu, 7 Jul 2016 11:49:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2D530287D4 for <patchwork-qemu-devel@patchwork.kernel.org>; Thu, 7 Jul 2016 11:49:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 222BA28813; Thu, 7 Jul 2016 11:49:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B0227287D4 for <patchwork-qemu-devel@patchwork.kernel.org>; Thu, 7 Jul 2016 11:49:27 +0000 (UTC) Received: from localhost ([::1]:39056 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org>) id 1bL7o6-0005pR-3j for patchwork-qemu-devel@patchwork.kernel.org; Thu, 07 Jul 2016 07:49:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>) id 1bL7ct-0000sx-Hn for qemu-devel@nongnu.org; Thu, 07 Jul 2016 07:37:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <pl@kamp.de>) id 1bL7cr-0005L6-JV for qemu-devel@nongnu.org; Thu, 07 Jul 2016 07:37:50 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:41409 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>) id 1bL7cr-0005Km-AD for qemu-devel@nongnu.org; Thu, 07 Jul 2016 07:37:49 -0400 Received: (qmail 8240 invoked by uid 89); 7 Jul 2016 11:37:46 -0000 Received: from [195.62.97.28] by client-16-kamp (envelope-from <pl@kamp.de>, uid 89) with qmail-scanner-2010/03/19-MF (clamdscan: 0.99.2/21858. hbedv: 8.3.40.44/7.12.99.34. avast: 1.2.2/16070700. spamassassin: 3.4.1. Clear:RC:1(195.62.97.28):. Processed in 0.396242 secs); 07 Jul 2016 11:37:46 -0000 Received: from smtp.kamp.de (HELO submission.kamp.de) ([195.62.97.28]) by mx01.kamp.de with ESMTPS (DHE-RSA-AES256-GCM-SHA384 encrypted); 7 Jul 2016 11:37:42 -0000 X-GL_Whitelist: yes Received: (qmail 14732 invoked from network); 7 Jul 2016 11:37:37 -0000 Received: from lieven-pc.kamp-intra.net (HELO lieven-pc) (relay@kamp.de@::ffff:172.21.12.60) by submission.kamp.de with ESMTPS (DHE-RSA-AES256-GCM-SHA384 encrypted) ESMTPA; 7 Jul 2016 11:37:37 -0000 Received: by lieven-pc (Postfix, from userid 1000) id CFC8E208D8; Thu, 7 Jul 2016 13:37:36 +0200 (CEST) From: Peter Lieven <pl@kamp.de> To: qemu-devel@nongnu.org Date: Thu, 7 Jul 2016 13:37:26 +0200 Message-Id: <1467891446-22267-7-git-send-email-pl@kamp.de> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1467891446-22267-1-git-send-email-pl@kamp.de> References: <1467891446-22267-1-git-send-email-pl@kamp.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a02:248:0:51::16 Subject: [Qemu-devel] [PATCH V3 6/6] coroutine: reduce stack size to 64kB X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: kwolf@redhat.com, peter.maydell@linaro.org, mst@redhat.com, armbru@redhat.com, Peter Lieven <pl@kamp.de>, dgilbert@redhat.com, mreitz@redhat.com, pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org> X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/include/qemu/coroutine_int.h b/include/qemu/coroutine_int.h index eac323a..f84d777 100644 --- a/include/qemu/coroutine_int.h +++ b/include/qemu/coroutine_int.h @@ -28,7 +28,7 @@ #include "qemu/queue.h" #include "qemu/coroutine.h" -#define COROUTINE_STACK_SIZE (1 << 20) +#define COROUTINE_STACK_SIZE (1 << 16) typedef enum { COROUTINE_YIELD = 1,
evaluation with the recently introduced maximum stack usage monitoring revealed that the actual used stack size was never above 4kB so allocating 1MB stack for each coroutine is a lot of wasted memory. So reduce the stack size to 64kB which should still give enough head room. The guard page added in qemu_alloc_stack will catch a potential stack overflow introduced by this commit. Signed-off-by: Peter Lieven <pl@kamp.de> --- include/qemu/coroutine_int.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)