From patchwork Tue Jul 12 18:03:20 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Nikunj A. Dadhania" X-Patchwork-Id: 9225867 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0D3A7604DB for ; Tue, 12 Jul 2016 18:04:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0394B272AA for ; Tue, 12 Jul 2016 18:04:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EC7DF2787D; Tue, 12 Jul 2016 18:04:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8CCE6272AA for ; Tue, 12 Jul 2016 18:04:34 +0000 (UTC) Received: from localhost ([::1]:42531 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN22q-00027X-Q7 for patchwork-qemu-devel@patchwork.kernel.org; Tue, 12 Jul 2016 14:04:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN22B-0001vB-8o for qemu-devel@nongnu.org; Tue, 12 Jul 2016 14:03:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bN227-0000Cr-1Y for qemu-devel@nongnu.org; Tue, 12 Jul 2016 14:03:50 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:60497) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN226-0000Cc-Ov for qemu-devel@nongnu.org; Tue, 12 Jul 2016 14:03:46 -0400 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u6CI3j3p044638 for ; Tue, 12 Jul 2016 14:03:46 -0400 Received: from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com [202.81.31.148]) by mx0a-001b2d01.pphosted.com with ESMTP id 2452xqwpr0-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 12 Jul 2016 14:03:45 -0400 Received: from localhost by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 13 Jul 2016 04:03:42 +1000 Received: from d23dlp03.au.ibm.com (202.81.31.214) by e23smtp06.au.ibm.com (202.81.31.212) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 13 Jul 2016 04:03:40 +1000 X-IBM-Helo: d23dlp03.au.ibm.com X-IBM-MailFrom: nikunj@linux.vnet.ibm.com X-IBM-RcptTo: qemu-devel@nongnu.org;qemu-ppc@nongnu.org Received: from d23relay09.au.ibm.com (d23relay09.au.ibm.com [9.185.63.181]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 324983578058; Wed, 13 Jul 2016 04:03:40 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u6CI3eaI23658658; Wed, 13 Jul 2016 04:03:40 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u6CI3dIZ030498; Wed, 13 Jul 2016 04:03:39 +1000 Received: from abhimanyu.in.ibm.com ([9.84.216.33]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u6CI3O5e030164; Wed, 13 Jul 2016 04:03:37 +1000 From: Nikunj A Dadhania To: qemu-ppc@nongnu.org, david@gibson.dropbear.id.au Date: Tue, 12 Jul 2016 23:33:20 +0530 X-Mailer: git-send-email 2.7.4 In-Reply-To: <1468346602-20700-1-git-send-email-nikunj@linux.vnet.ibm.com> References: <1468346602-20700-1-git-send-email-nikunj@linux.vnet.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16071218-0040-0000-0000-000001BFCC93 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16071218-0041-0000-0000-00000A0E9FA8 Message-Id: <1468346602-20700-5-git-send-email-nikunj@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-07-12_08:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607120160 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 148.163.156.1 Subject: [Qemu-devel] [RFC 4/6] target-ppc: add cmprb instruction X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP ISA 3.0 Compare Ranged Byte instruction useful for isupper/islower/isaplha kind of operation. Signed-off-by: Nikunj A Dadhania Reviewed-by: David Gibson --- target-ppc/translate.c | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 93c7c66..8de217f 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -817,6 +817,45 @@ static void gen_cmpli(DisasContext *ctx) } } +/* cmprb - range comparison: isupper, isaplha, islower*/ +static void gen_cmprb(DisasContext *ctx) +{ + TCGLabel *lab1 = gen_new_label(); + TCGLabel *lab2 = gen_new_label(); + TCGv src1 = tcg_temp_local_new(); + TCGv src2 = tcg_temp_local_new(); + TCGv src2lo = tcg_temp_local_new(); + TCGv src2hi = tcg_temp_local_new(); + + tcg_gen_andi_tl(src1, cpu_gpr[rA(ctx->opcode)], 0xFF); + tcg_gen_andi_tl(src2, cpu_gpr[rB(ctx->opcode)], 0xFFFFFFFF); + + tcg_gen_andi_tl(src2lo, src2, 0xFF); + tcg_gen_shri_tl(src2hi, src2, 8); + tcg_gen_andi_tl(src2hi, src2hi, 0xFF); + + tcg_gen_brcond_tl(TCG_COND_GTU, src1, src2hi, lab1); + tcg_gen_brcond_tl(TCG_COND_LTU, src1, src2lo, lab1); + tcg_gen_movi_i32(cpu_crf[crfD(ctx->opcode)], 1 << CRF_GT); + tcg_gen_br(lab2); + gen_set_label(lab1); + + if (ctx->opcode & 0x00200000) { + tcg_gen_shri_tl(src2hi, src2, 24); + tcg_gen_andi_tl(src2hi, src2hi, 0xFF); + tcg_gen_shri_tl(src2lo, src2, 16); + tcg_gen_andi_tl(src2lo, src2lo, 0xFF); + tcg_gen_brcond_tl(TCG_COND_GTU, src1, src2hi, lab2); + tcg_gen_brcond_tl(TCG_COND_LTU, src1, src2lo, lab2); + tcg_gen_movi_i32(cpu_crf[crfD(ctx->opcode)], 1 << CRF_GT); + } + gen_set_label(lab2); + tcg_temp_free(src1); + tcg_temp_free(src2); + tcg_temp_free(src2lo); + tcg_temp_free(src2hi); +} + /* isel (PowerPC 2.03 specification) */ static void gen_isel(DisasContext *ctx) { @@ -9898,6 +9937,7 @@ GEN_HANDLER(cmpi, 0x0B, 0xFF, 0xFF, 0x00400000, PPC_INTEGER), GEN_HANDLER(cmpl, 0x1F, 0x00, 0x01, 0x00400000, PPC_INTEGER), GEN_HANDLER(cmpli, 0x0A, 0xFF, 0xFF, 0x00400000, PPC_INTEGER), GEN_HANDLER_E(cmpb, 0x1F, 0x1C, 0x0F, 0x00000001, PPC_NONE, PPC2_ISA205), +GEN_HANDLER_E(cmprb, 0x1F, 0x00, 0x06, 0x00400001, PPC_NONE, PPC2_ISA300), GEN_HANDLER(isel, 0x1F, 0x0F, 0xFF, 0x00000001, PPC_ISEL), GEN_HANDLER(addi, 0x0E, 0xFF, 0xFF, 0x00000000, PPC_INTEGER), GEN_HANDLER(addic, 0x0C, 0xFF, 0xFF, 0x00000000, PPC_INTEGER),