| Message ID | 1468503826-10617-2-git-send-email-marcel@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/14/2016 04:51 PM, Thomas Huth wrote: > On 14.07.2016 15:43, Marcel Apfelbaum wrote: >> On a slower machine the test can take more than 30 seconds. >> Increase the timeout to 100 seconds. >> >> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com> >> --- >> tests/prom-env-test.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/prom-env-test.c b/tests/prom-env-test.c >> index 6df57d2..7a62857 100644 >> --- a/tests/prom-env-test.c >> +++ b/tests/prom-env-test.c >> @@ -30,7 +30,7 @@ static void check_guest_memory(void) >> int i; >> >> /* Poll until code has run and modified memory. Wait at most 30 seconds */ >> - for (i = 0; i < 3000; ++i) { >> + for (i = 0; i < 10000; ++i) { >> signature = readl(ADDRESS); >> if (signature == MAGIC) { >> break; > > Ack, but could you please also update the comment before the for-loop? > Sure, I'll take care of it once I'll get comments for the other patches. Thanks, Marcel > Thanks, > Thomas >
On 07/14/2016 04:51 PM, Thomas Huth wrote: > On 14.07.2016 15:43, Marcel Apfelbaum wrote: >> On a slower machine the test can take more than 30 seconds. >> Increase the timeout to 100 seconds. >> >> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com> >> --- >> tests/prom-env-test.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/prom-env-test.c b/tests/prom-env-test.c >> index 6df57d2..7a62857 100644 >> --- a/tests/prom-env-test.c >> +++ b/tests/prom-env-test.c >> @@ -30,7 +30,7 @@ static void check_guest_memory(void) >> int i; >> >> /* Poll until code has run and modified memory. Wait at most 30 seconds */ >> - for (i = 0; i < 3000; ++i) { >> + for (i = 0; i < 10000; ++i) { >> signature = readl(ADDRESS); >> if (signature == MAGIC) { >> break; > > Ack, but could you please also update the comment before the for-loop? > Hi Michael, It seems a V2 is not needed, can you tweak the comment or do you prefer me to send the series/patch again? Thanks, Marcel > Thanks, > Thomas >
diff --git a/tests/prom-env-test.c b/tests/prom-env-test.c index 6df57d2..7a62857 100644 --- a/tests/prom-env-test.c +++ b/tests/prom-env-test.c @@ -30,7 +30,7 @@ static void check_guest_memory(void) int i; /* Poll until code has run and modified memory. Wait at most 30 seconds */ - for (i = 0; i < 3000; ++i) { + for (i = 0; i < 10000; ++i) { signature = readl(ADDRESS); if (signature == MAGIC) { break;
On a slower machine the test can take more than 30 seconds. Increase the timeout to 100 seconds. Signed-off-by: Marcel Apfelbaum <marcel@redhat.com> --- tests/prom-env-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)