| Message ID | 1469198048-8535-1-git-send-email-prasanna.kalever@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/22/2016 08:34 AM, Prasanna Kumar Kalever wrote: > 1. qapi @BlockdevOptionsGluster schema member name s/debug_level/debug-level/ > 2. rearrange the versioning > 3. s/server description/servers description/ > > Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> This part is fine. > v2: address review comments given by Eric Blake > v1: Initial patch But these lines... > --- ...should be here. They are useful to reviewers, but do not need to clutter qemu.git, so putting them after the separator lets 'git am' automatically strip them. The maintainer can probably fix that without needing a respin. > qapi/block-core.json | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Eric Blake <eblake@redhat.com> Must go in during hard freeze for 2.7, otherwise it would be an ABI change compared to released code.
On Fri, Jul 22, 2016 at 8:16 PM, Eric Blake <eblake@redhat.com> wrote: > On 07/22/2016 08:34 AM, Prasanna Kumar Kalever wrote: >> 1. qapi @BlockdevOptionsGluster schema member name s/debug_level/debug-level/ >> 2. rearrange the versioning >> 3. s/server description/servers description/ >> >> Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> > > This part is fine. > >> v2: address review comments given by Eric Blake >> v1: Initial patch > > But these lines... > >> --- > > ...should be here. They are useful to reviewers, but do not need to > clutter qemu.git, so putting them after the separator lets 'git am' > automatically strip them. I learned this before :) This was not intentional Thanks, -- Prasanna > > The maintainer can probably fix that without needing a respin. > >> qapi/block-core.json | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> > > Reviewed-by: Eric Blake <eblake@redhat.com> > > Must go in during hard freeze for 2.7, otherwise it would be an ABI > change compared to released code. > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >
On Fri, Jul 22, 2016 at 08:04:08PM +0530, Prasanna Kumar Kalever wrote: > 1. qapi @BlockdevOptionsGluster schema member name s/debug_level/debug-level/ > 2. rearrange the versioning > 3. s/server description/servers description/ > > Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> > v2: address review comments given by Eric Blake > v1: Initial patch > --- > qapi/block-core.json | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index f462345..cd14e57 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -1688,9 +1688,9 @@ > # Drivers that are supported in block device operations. > # > # @host_device, @host_cdrom: Since 2.1 > +# @gluster: Since 2.7 > # > # Since: 2.0 > -# @gluster: Since 2.7 > ## > { 'enum': 'BlockdevDriver', > 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop', > @@ -2134,7 +2134,7 @@ > # > # @path: absolute path to image file in gluster volume > # > -# @server: gluster server description > +# @server: gluster servers description > # > # @debug-level: #optional libgfapi log level (default '4' which is Error) > # > @@ -2144,7 +2144,7 @@ > 'data': { 'volume': 'str', > 'path': 'str', > 'server': ['GlusterServer'], > - '*debug_level': 'int' } } > + '*debug-level': 'int' } } > > ## > # @BlockdevOptions > -- > 2.7.4 > Reviewed-by: Jeff Cody <jcody@redhat.com>
On Fri, Jul 22, 2016 at 08:04:08PM +0530, Prasanna Kumar Kalever wrote: > 1. qapi @BlockdevOptionsGluster schema member name s/debug_level/debug-level/ > 2. rearrange the versioning > 3. s/server description/servers description/ > > Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> > v2: address review comments given by Eric Blake > v1: Initial patch > --- > qapi/block-core.json | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index f462345..cd14e57 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -1688,9 +1688,9 @@ > # Drivers that are supported in block device operations. > # > # @host_device, @host_cdrom: Since 2.1 > +# @gluster: Since 2.7 > # > # Since: 2.0 > -# @gluster: Since 2.7 > ## > { 'enum': 'BlockdevDriver', > 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop', > @@ -2134,7 +2134,7 @@ > # > # @path: absolute path to image file in gluster volume > # > -# @server: gluster server description > +# @server: gluster servers description > # > # @debug-level: #optional libgfapi log level (default '4' which is Error) > # > @@ -2144,7 +2144,7 @@ > 'data': { 'volume': 'str', > 'path': 'str', > 'server': ['GlusterServer'], > - '*debug_level': 'int' } } > + '*debug-level': 'int' } } > > ## > # @BlockdevOptions > -- > 2.7.4 > Thanks, Applied to my block branch: git://github.com/codyprime/qemu-kvm-jtc.git block -Jeff
diff --git a/qapi/block-core.json b/qapi/block-core.json index f462345..cd14e57 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1688,9 +1688,9 @@ # Drivers that are supported in block device operations. # # @host_device, @host_cdrom: Since 2.1 +# @gluster: Since 2.7 # # Since: 2.0 -# @gluster: Since 2.7 ## { 'enum': 'BlockdevDriver', 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop', @@ -2134,7 +2134,7 @@ # # @path: absolute path to image file in gluster volume # -# @server: gluster server description +# @server: gluster servers description # # @debug-level: #optional libgfapi log level (default '4' which is Error) # @@ -2144,7 +2144,7 @@ 'data': { 'volume': 'str', 'path': 'str', 'server': ['GlusterServer'], - '*debug_level': 'int' } } + '*debug-level': 'int' } } ## # @BlockdevOptions
1. qapi @BlockdevOptionsGluster schema member name s/debug_level/debug-level/ 2. rearrange the versioning 3. s/server description/servers description/ Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com> v2: address review comments given by Eric Blake v1: Initial patch --- qapi/block-core.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)