diff mbox

fixup! fix qemu exit on memory hotplug when allocation fails at prealloc time

Message ID 1469453038-7991-1-git-send-email-imammedo@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Igor Mammedov July 25, 2016, 1:23 p.m. UTC 
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 - add comment o exit(1) path
---
 util/oslib-posix.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Markus Armbruster July 25, 2016, 3:44 p.m. UTC | #1 
Igor Mammedov <imammedo@redhat.com> writes:

> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
>  - add comment o exit(1) path
> ---
>  util/oslib-posix.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index a60ac97..f2d4e9e 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -356,6 +356,7 @@ void os_mem_prealloc(int fd, char *area, size_t memory, Error **errp)
>  
>      ret = sigaction(SIGBUS, &oldact, NULL);
>      if (ret) {
> +        /* Terminate QEMU since it can't recover from error */
>          perror("os_mem_prealloc: failed to reinstall signal handler");
>          exit(1);
>      }

Thanks!  My R-by stands, of course.
diff mbox

Patch

diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index a60ac97..f2d4e9e 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -356,6 +356,7 @@  void os_mem_prealloc(int fd, char *area, size_t memory, Error **errp)
 
     ret = sigaction(SIGBUS, &oldact, NULL);
     if (ret) {
+        /* Terminate QEMU since it can't recover from error */
         perror("os_mem_prealloc: failed to reinstall signal handler");
         exit(1);
     }