Message ID | 1470683381-16680-2-git-send-email-jsnow@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On 08/08/2016 02:09 PM, John Snow wrote: > From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > > Though it is not intended to be reached through normal circumstances, > if we do not gracefully deconstruct the transaction QLIST, we may wind > up with stale pointers in the list. > > The rest of this series attempts to address the underlying issues, > but this should fix list inconsistencies. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > Tested-by: John Snow <jsnow@redhat.com> > Reviewed-by: John Snow <jsnow@redhat.com> > [Rewrote commit message. --js] > Signed-off-by: John Snow <jsnow@redhat.com> > > Signed-off-by: John Snow <jsnow@redhat.com> Double SoB looks interesting. Otherwise, Reviewed-by: Eric Blake <eblake@redhat.com>
diff --git a/blockjob.c b/blockjob.c index a5ba3be..e045091 100644 --- a/blockjob.c +++ b/blockjob.c @@ -216,6 +216,7 @@ static void block_job_completed_single(BlockJob *job) } job->cb(job->opaque, job->ret); if (job->txn) { + QLIST_REMOVE(job, txn_list); block_job_txn_unref(job->txn); } block_job_unref(job);