diff mbox

[v4,2/5] linux-user: Fix TARGET_F_GETOWN definition for Mips

Message ID 1473084137-35485-3-git-send-email-aleksandar.markovic@rt-rk.com (mailing list archive)
State New, archived
Headers show

Commit Message

Aleksandar Markovic Sept. 5, 2016, 2:02 p.m. UTC
From: Aleksandar Markovic <aleksandar.markovic@imgtec.com>

For some reason, Qemu's TARGET_F_GETOWN constant for Mips does not
match the correct value of correspondant F_GETOWN. This patch fixes
this problem.

For reference, see Mips' F_GETOWN definition in Linux kernel at
arch/mips/include/uapi/asm/fcntl.h#L44.

This patch also fixes some fcntl()-related LTP tests for Qemu
user mode for Mips.

Signed-off-by: Miodrag Dinic <miodrag.dinic@imgtec.com>
---
 linux-user/syscall_defs.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Leon Alrae Sept. 8, 2016, 1:33 p.m. UTC | #1
On Mon, Sep 05, 2016 at 04:02:05PM +0200, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <aleksandar.markovic@imgtec.com>
> 
> For some reason, Qemu's TARGET_F_GETOWN constant for Mips does not
> match the correct value of correspondant F_GETOWN. This patch fixes
> this problem.
> 
> For reference, see Mips' F_GETOWN definition in Linux kernel at
> arch/mips/include/uapi/asm/fcntl.h#L44.
> 
> This patch also fixes some fcntl()-related LTP tests for Qemu
> user mode for Mips.
> 
> Signed-off-by: Miodrag Dinic <miodrag.dinic@imgtec.com>

Hi Aleksandar,

Since you're submitting the patch you need to add also your Signed-off-by:
line here (similarly in other patches in the series).

Thanks,
Leon

> ---
>  linux-user/syscall_defs.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> index e6171ae..27d93a8 100644
> --- a/linux-user/syscall_defs.h
> +++ b/linux-user/syscall_defs.h
> @@ -2186,7 +2186,7 @@ struct target_statfs64 {
>  #define TARGET_F_SETLK         6
>  #define TARGET_F_SETLKW        7
>  #define TARGET_F_SETOWN        24       /*  for sockets. */
> -#define TARGET_F_GETOWN        25       /*  for sockets. */
> +#define TARGET_F_GETOWN        23       /*  for sockets. */
>  #else
>  #define TARGET_F_GETLK         5
>  #define TARGET_F_SETLK         6
> -- 
> 1.7.9.5
>
diff mbox

Patch

diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
index e6171ae..27d93a8 100644
--- a/linux-user/syscall_defs.h
+++ b/linux-user/syscall_defs.h
@@ -2186,7 +2186,7 @@  struct target_statfs64 {
 #define TARGET_F_SETLK         6
 #define TARGET_F_SETLKW        7
 #define TARGET_F_SETOWN        24       /*  for sockets. */
-#define TARGET_F_GETOWN        25       /*  for sockets. */
+#define TARGET_F_GETOWN        23       /*  for sockets. */
 #else
 #define TARGET_F_GETLK         5
 #define TARGET_F_SETLK         6