| Message ID | 1473319037-27645-1-git-send-email-kraxel@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Sep 8, 2016 at 11:29 AM Gerd Hoffmann <kraxel@redhat.com> wrote: > We can't hotplug display adapters in qemu, tag virtio-gpu-pci > accordingly (virtio-vga already has this). > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> --- > hw/display/virtio-gpu-pci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/display/virtio-gpu-pci.c b/hw/display/virtio-gpu-pci.c > index 34a724c..ef92c4a 100644 > --- a/hw/display/virtio-gpu-pci.c > +++ b/hw/display/virtio-gpu-pci.c > @@ -48,6 +48,7 @@ static void virtio_gpu_pci_class_init(ObjectClass > *klass, void *data) > > set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories); > dc->props = virtio_gpu_pci_properties; > + dc->hotpluggable = false; > k->realize = virtio_gpu_pci_realize; > pcidev_k->class_id = PCI_CLASS_DISPLAY_OTHER; > } > -- > 1.8.3.1 > > > -- Marc-André Lureau
On Thu, Sep 08, 2016 at 09:17:17AM +0200, Gerd Hoffmann wrote: > We can't hotplug display adapters in qemu, tag virtio-gpu-pci > accordingly (virtio-vga already has this). > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> I assume you merged this? > --- > hw/display/virtio-gpu-pci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/display/virtio-gpu-pci.c b/hw/display/virtio-gpu-pci.c > index 34a724c..ef92c4a 100644 > --- a/hw/display/virtio-gpu-pci.c > +++ b/hw/display/virtio-gpu-pci.c > @@ -48,6 +48,7 @@ static void virtio_gpu_pci_class_init(ObjectClass *klass, void *data) > > set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories); > dc->props = virtio_gpu_pci_properties; > + dc->hotpluggable = false; > k->realize = virtio_gpu_pci_realize; > pcidev_k->class_id = PCI_CLASS_DISPLAY_OTHER; > } > -- > 1.8.3.1
On Fr, 2016-09-09 at 21:16 +0300, Michael S. Tsirkin wrote: > On Thu, Sep 08, 2016 at 09:17:17AM +0200, Gerd Hoffmann wrote: > > We can't hotplug display adapters in qemu, tag virtio-gpu-pci > > accordingly (virtio-vga already has this). > > > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > > Acked-by: Michael S. Tsirkin <mst@redhat.com> > > I assume you merged this? s/merged/will merged/ -> Yes. cheers, Gerd
diff --git a/hw/display/virtio-gpu-pci.c b/hw/display/virtio-gpu-pci.c index 34a724c..ef92c4a 100644 --- a/hw/display/virtio-gpu-pci.c +++ b/hw/display/virtio-gpu-pci.c @@ -48,6 +48,7 @@ static void virtio_gpu_pci_class_init(ObjectClass *klass, void *data) set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories); dc->props = virtio_gpu_pci_properties; + dc->hotpluggable = false; k->realize = virtio_gpu_pci_realize; pcidev_k->class_id = PCI_CLASS_DISPLAY_OTHER; }
We can't hotplug display adapters in qemu, tag virtio-gpu-pci accordingly (virtio-vga already has this). Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- hw/display/virtio-gpu-pci.c | 1 + 1 file changed, 1 insertion(+)