From patchwork Wed Sep 14 03:04:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Wanpeng Li X-Patchwork-Id: 9330281 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 164316077F for ; Wed, 14 Sep 2016 03:06:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0339229879 for ; Wed, 14 Sep 2016 03:06:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EB2C92987B; Wed, 14 Sep 2016 03:06:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 933CA29879 for ; Wed, 14 Sep 2016 03:06:51 +0000 (UTC) Received: from localhost ([::1]:52755 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bk0XC-0003Yj-AG for patchwork-qemu-devel@patchwork.kernel.org; Tue, 13 Sep 2016 23:06:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bk0Wu-0003YL-4N for qemu-devel@nongnu.org; Tue, 13 Sep 2016 23:06:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bk0Wp-00072o-0D for qemu-devel@nongnu.org; Tue, 13 Sep 2016 23:06:30 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:35472) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bk0Wo-0006UN-ND for qemu-devel@nongnu.org; Tue, 13 Sep 2016 23:06:26 -0400 Received: by mail-pa0-f68.google.com with SMTP id pp5so68473pac.2 for ; Tue, 13 Sep 2016 20:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mbxwvR9tKrhfVLqKU9rYsG7npm0zI+iEpyqAmdVzPGY=; b=zdiZtpmzYS8iIpK4lMUQY+NvnJthoKj0qwt1cLSTsFpikHtfSTbiyxavcA7Rda/Pjh kLpyhXlfRstrC14hhfKOufqr3EhWzirPi3KvqvCV7gxzl/vGORRewnKWGuUrNqZ0ftJ8 0Hw6VB9eH1YyzYjmOjMa+Q7Fkv8D2JIjjG6dkRglSMqj/kqzstZEhHIfDb5qUdChf6yB sBZCcnyvSf5WKPyi2A5/MrVjjQG96LYf9H62LOk8AU6HxtRpWt8of9eRl/6vp2PbHJIf Gsh1HeVSXtdyGLr2PPaJAyUWCjMwD/tkefLsSbMiC3zmNE/86aTWsHAnK+8rxYlUEipA b/hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mbxwvR9tKrhfVLqKU9rYsG7npm0zI+iEpyqAmdVzPGY=; b=m/4gA0W/A+jakwwr7BbATH9t1TiI02ZmCiQwBv530NIJFdkM9uZFukJd5UztCtEWD9 UXBIlQNN/bCXwITA0jQJSmlHpSGhZrdiwHxJ60WG2SQ3Qu5/kSCKocCTKWlz7xMSDUIq 27HNKfevjLKw0YgzxiLXxdJjc/0zluuMPAseFgmYMESqoatxM1mBDOBrIIWx+EknvEIO MZbl1dWGmV+aj0L5KklZh9Nf+QIZxNAA1iAZRDrHgaLU0M1m5JpeCvQORiMdYjOUvNSW XmA0Q7orxQRSHuwtEIHD/EnryglXI143S2q4DCyrsgsd/hQQYrdvBnMxY5L4gMiF+NKP lW6A== X-Gm-Message-State: AE9vXwPPji7N7IY5gn0khKHceCdv2nU2SGIviW3X0PCLhvJhp8AHzlg+M4tK/7l7nO872g== X-Received: by 10.67.7.170 with SMTP id dd10mr452204pad.152.1473822304755; Tue, 13 Sep 2016 20:05:04 -0700 (PDT) Received: from kernel.ksyun.com ([114.255.44.132]) by smtp.gmail.com with ESMTPSA id q14sm14778381pfg.63.2016.09.13.20.05.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 13 Sep 2016 20:05:03 -0700 (PDT) From: Wanpeng Li X-Google-Original-From: Wanpeng Li To: qemu-devel@nongnu.org, kvm@vger.kernel.org Date: Wed, 14 Sep 2016 11:04:59 +0800 Message-Id: <1473822299-6302-1-git-send-email-wanpeng.li@hotmail.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.220.68 Subject: [Qemu-devel] [PATCH] pc: apic: fix touch LAPIC when irqchip is split X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , "Michael S. Tsirkin" , Eduardo Habkost , Wanpeng Li , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Wanpeng Li Add -kernel_irqchip=split ./x86-run x86/eventinj.flat qemu-system-x86_64 -enable-kvm -machine kernel_irqchip=split -cpu host -device pc-testdev -device isa-debug-exit,iobase=0xf4,iosize=0x4 -vnc none -serial stdio -device pci-testdev -kernel x86/eventinj.flat enabling apic paging enabled cr0 = 80010011 cr3 = 7fff000 cr4 = 20 Sending vec 33 and 62 and mask one with TPR irq1 running irq1 running After 33/62 TPR test FAIL: TPR irq0 running irq0 running Both irq1 and irq0 are executing twice. kvm_entry: vcpu 0 kvm_exit: reason MSR_WRITE rip 0x401f33 info 0 0 kvm_apic: apic_write APIC_EOI = 0x0 kvm_eoi: apicid 0 vector 62 kvm_msr: msr_write 80b = 0x0 kvm_entry: vcpu 0 kvm_exit: reason PENDING_INTERRUPT rip 0x401f35 info 0 0 kvm_userspace_exit: reason KVM_EXIT_IRQ_WINDOW_OPEN (7) kvm_inj_virq: irq 62 kvm_entry: vcpu 0 kvm_exit: reason IO_INSTRUCTION rip 0x4016ec info 3fd0008 0 From the trace we can see there is an interrupt window exit after the first interrupt EOI(irq 62), and the same irq(62) is injected duplicately after the interrupt window. QEMU does KVM_INTERRUPT(62) ioctl after KVM exits with KVM_EXIT_IRQ_WINDOW_OPEN, which QEMU requested while the guest was printing. The printing calls serial_update_irq() -> qemu_irq_lower() -> qemu_set_irq() -> gsi_handler() -> qemu_set_irq() -> pic_irq_request() -> apic_deliver_pic_intr() -> kvm_handle_interrupt() kvm_handle_interrupt() does interrupt_request |= CPU_INTERRUPT_HARD which later calls cpu_get_pic_interrupt() in kvm_arch_pre_run(), but that function uses stale information from APIC and injects 62 again. If we synchronized the APIC, then the test would #GP, because there would be no injectable interrupt in LAPIC or PIC, so pic_read_irq() would return 15, thinking it was spurious. This patch fix it by don't touch LAPIC if LAPIC is in kernel. Suggested-by: Paolo Bonzini Suggested-by: Radim Krčmář Cc: Paolo Bonzini Cc: Radim Krčmář Cc: Michael S. Tsirkin Cc: Eduardo Habkost Signed-off-by: Wanpeng Li Reviewed-by: Radim Krčmář --- hw/i386/pc.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index e31f70f..4f3d508 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -161,14 +161,16 @@ int cpu_get_pic_interrupt(CPUX86State *env) X86CPU *cpu = x86_env_get_cpu(env); int intno; - intno = apic_get_interrupt(cpu->apic_state); - if (intno >= 0) { - return intno; - } - /* read the irq from the PIC */ - if (!apic_accept_pic_intr(cpu->apic_state)) { - return -1; - } + if (!kvm_irqchip_in_kernel()) { + intno = apic_get_interrupt(cpu->apic_state); + if (intno >= 0) { + return intno; + } + /* read the irq from the PIC */ + if (!apic_accept_pic_intr(cpu->apic_state)) { + return -1; + } + } intno = pic_read_irq(isa_pic); return intno; @@ -180,7 +182,7 @@ static void pic_irq_request(void *opaque, int irq, int level) X86CPU *cpu = X86_CPU(cs); DPRINTF("pic_irqs: %s irq %d\n", level? "raise" : "lower", irq); - if (cpu->apic_state) { + if (cpu->apic_state && !kvm_irqchip_in_kernel()) { CPU_FOREACH(cs) { cpu = X86_CPU(cs); if (apic_accept_pic_intr(cpu->apic_state)) {