From patchwork Thu Sep 15 06:14:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Fleytman X-Patchwork-Id: 9332845 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BD53B6077A for ; Thu, 15 Sep 2016 06:24:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AF755292A1 for ; Thu, 15 Sep 2016 06:24:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A408F292A4; Thu, 15 Sep 2016 06:24:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3464B292A1 for ; Thu, 15 Sep 2016 06:24:54 +0000 (UTC) Received: from localhost ([::1]:60121 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkQ6P-0001nv-Eq for patchwork-qemu-devel@patchwork.kernel.org; Thu, 15 Sep 2016 02:24:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkPy2-0003lr-1Q for qemu-devel@nongnu.org; Thu, 15 Sep 2016 02:16:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkPy1-0001Cv-3b for qemu-devel@nongnu.org; Thu, 15 Sep 2016 02:16:13 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkPy0-00018E-TQ for qemu-devel@nongnu.org; Thu, 15 Sep 2016 02:16:13 -0400 Received: by mail-wm0-f66.google.com with SMTP id g141so5495533wmd.1 for ; Wed, 14 Sep 2016 23:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vtCWsc8UZpEcRabyCxXb4ExuBxHsPxhtvRXIkEP9kVs=; b=SBn/sM8PDE8zvm2Lc5zqHb8Vw/KHJAaKCBw3wORj6SlQToX79F8YLReFcf8F0YXvnH 2sVpUrqCiV2Z4TEVHCAopH2hpbuAfS1aQ6xPSOx3QUcpXZbXslXt6XL9SpxT5waIWPwK 6Wt9RrkXZA4R6UR6JLpjWlc13wTa8JeQ5lhpufy6w4AyklVSiJm580s+/Kd5RGZPcyL4 l5zK9iPh0lpQ5HaDSAMq3dmgYVdpbJU7w5p58xGiif2vozgrhqJ57tPeuJ0shSPzFi4u QsWK4PtEfNJNUFZhLZDWQ6pqOC795HtZe70g9vyD2lvNY+wRauK1l7Fu5Oig/5pvLObZ RQxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vtCWsc8UZpEcRabyCxXb4ExuBxHsPxhtvRXIkEP9kVs=; b=KFqag5MBxHU6LWWi31BWie5EMZl5HXsIYKa4Vn05OV2acCJxVQ0rhY65SIiYXtPNFO sJDQP8eHjjD7NBE2tGlTbCQNB04jyYMISeFfkl08qkQDEQ3VZ6kl8K6j4+z/YQhPoY+t aBK5ZsdATSyHL1O53YSpJlT4nZB+ppN4JD4z2BoFf0NQA7rqIoLEL8QdwLpTd9xKUXF6 LyVMo0LDfvpESvBPywyblEWoereMgnv6CHOOeubXJDcN7emcDI0Uf3Hd1QCZ6not202U PWzShb0DUgtZV8UCHaj6HAcM5HlOOXU6dLzJdKeRHfGCVIl/4nUAemtHf2YtS5L6G4Yw lOVg== X-Gm-Message-State: AE9vXwOiQOSh1P3PY/axRjuH4ZQO/c1+VELLAD3xmt/5oQJW8oBVXy+IiuJHM6N6NjLAnw== X-Received: by 10.28.100.214 with SMTP id y205mr1157699wmb.72.1473920090971; Wed, 14 Sep 2016 23:14:50 -0700 (PDT) Received: from bark.daynix ([141.226.163.133]) by smtp.gmail.com with ESMTPSA id jd4sm1732011wjb.6.2016.09.14.23.14.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Sep 2016 23:14:50 -0700 (PDT) From: Dmitry Fleytman To: qemu-devel@nongnu.org Date: Thu, 15 Sep 2016 09:14:28 +0300 Message-Id: <1473920070-21938-6-git-send-email-dmitry@daynix.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1473920070-21938-1-git-send-email-dmitry@daynix.com> References: <1473920070-21938-1-git-send-email-dmitry@daynix.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 74.125.82.66 Subject: [Qemu-devel] [PATCH 5/7] e1000e: Fix OTHER interrupts processing for MSI-X X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Vugenfirer , Jason Wang , Shmulik Ladkani Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Interrupt mask for legacy OTHER causes should not apply to MSI-X OTHER cause. Signed-off-by: Dmitry Fleytman --- hw/net/e1000e_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index c38ed10..e70e669 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -2131,7 +2131,7 @@ e1000e_update_interrupt_state(E1000ECore *core) /* Set ICR[OTHER] for MSI-X */ if (is_msix) { - if (core->mac[ICR] & core->mac[IMS] & E1000_ICR_OTHER_CAUSES) { + if (core->mac[ICR] & E1000_ICR_OTHER_CAUSES) { core->mac[ICR] |= E1000_ICR_OTHER; trace_e1000e_irq_add_msi_other(core->mac[ICR]); }