[22/26] blockdev: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

Commit Message

Laurent Vivier Sept. 16, 2016, 1:56 p.m. UTC

This patch is the result of coccinelle script
scripts/coccinelle/exit.cocci

Signed-off-by: Laurent Vivier <[e-mail]>
CC: John Snow <[e-mail]>
---
 hw/ide/core.c        | 2 +-
 hw/scsi/lsi53c895a.c | 7 ++++---
 hw/sd/ssi-sd.c       | 3 ++-
 3 files changed, 7 insertions(+), 5 deletions(-)

Patch

diff --git a/hw/ide/core.c b/hw/ide/core.c
index b0e42a6..b927bd8 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -2855,7 +2855,7 @@  void ide_drive_get(DriveInfo **hd, int n)
     if (highest_bus > n_buses) {
         error_report("Too many IDE buses defined (%d > %d)",
                      highest_bus, n_buses);
-        exit(1);
+        exit(EXIT_FAILURE);
     }
 
     for (i = 0; i < n; i++) {
diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
index feb1191..9cd4796 100644
--- a/hw/scsi/lsi53c895a.c
+++ b/hw/scsi/lsi53c895a.c
@@ -28,7 +28,8 @@ 
 #define DPRINTF(fmt, ...) \
 do { printf("lsi_scsi: " fmt , ## __VA_ARGS__); } while (0)
 #define BADF(fmt, ...) \
-do { fprintf(stderr, "lsi_scsi: error: " fmt , ## __VA_ARGS__); exit(1);} while (0)
+do { fprintf(stderr, "lsi_scsi: error: " fmt , ## __VA_ARGS__); \
+     exit(EXIT_FAILURE); } while (0)
 #else
 #define DPRINTF(fmt, ...) do {} while(0)
 #define BADF(fmt, ...) \
@@ -1205,7 +1206,7 @@  again:
             break;
         default:
             BADF("Unimplemented phase %d\n", s->sstat1 & PHASE_MASK);
-            exit(1);
+            exit(EXIT_FAILURE);
         }
         s->dfifo = s->dbc & 0xff;
         s->ctest5 = (s->ctest5 & 0xfc) | ((s->dbc >> 8) & 3);
@@ -1276,7 +1277,7 @@  again:
                 }
                 if (insn & (1 << 9)) {
                     BADF("Target mode not implemented\n");
-                    exit(1);
+                    exit(EXIT_FAILURE);
                 }
                 if (insn & (1 << 10))
                     s->carry = 1;
diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c
index 3ff0886..f188455 100644
--- a/hw/sd/ssi-sd.c
+++ b/hw/sd/ssi-sd.c
@@ -23,7 +23,8 @@ 
 #define DPRINTF(fmt, ...) \
 do { printf("ssi_sd: " fmt , ## __VA_ARGS__); } while (0)
 #define BADF(fmt, ...) \
-do { fprintf(stderr, "ssi_sd: error: " fmt , ## __VA_ARGS__); exit(1);} while (0)
+do { fprintf(stderr, "ssi_sd: error: " fmt , ## __VA_ARGS__); \
+     exit(EXIT_FAILURE); } while (0)
 #else
 #define DPRINTF(fmt, ...) do {} while(0)
 #define BADF(fmt, ...) \