From patchwork Fri Sep 16 13:56:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 9335891 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F04E4607FF for ; Fri, 16 Sep 2016 14:10:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E278629FC8 for ; Fri, 16 Sep 2016 14:10:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D6E3E29FCF; Fri, 16 Sep 2016 14:10:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8651E29FC8 for ; Fri, 16 Sep 2016 14:10:49 +0000 (UTC) Received: from localhost ([::1]:41008 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bktqq-0005cw-Gp for patchwork-qemu-devel@patchwork.kernel.org; Fri, 16 Sep 2016 10:10:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkteP-00045J-F7 for qemu-devel@nongnu.org; Fri, 16 Sep 2016 09:58:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkteJ-0007cT-Kg for qemu-devel@nongnu.org; Fri, 16 Sep 2016 09:57:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bktdt-0007Fg-8y; Fri, 16 Sep 2016 09:57:51 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 05A7D9D0C1; Fri, 16 Sep 2016 13:57:09 +0000 (UTC) Received: from thinkpad.redhat.com (ovpn-112-33.ams2.redhat.com [10.36.112.33]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8GDuHkQ024127; Fri, 16 Sep 2016 09:57:07 -0400 From: Laurent Vivier To: qemu-trivial@nongnu.org Date: Fri, 16 Sep 2016 15:56:15 +0200 Message-Id: <1474034177-17663-25-git-send-email-lvivier@redhat.com> In-Reply-To: <1474034177-17663-1-git-send-email-lvivier@redhat.com> References: <1474034177-17663-1-git-send-email-lvivier@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 16 Sep 2016 13:57:09 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 24/26] error, trace: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , qemu-devel@nongnu.org, Markus Armbruster Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch is the result of coccinelle script scripts/coccinelle/exit.cocci Signed-off-by: Laurent Vivier CC: Markus Armbruster --- trace/control.c | 10 +++++----- util/error.c | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/trace/control.c b/trace/control.c index 05d85ac..b09d6f1 100644 --- a/trace/control.c +++ b/trace/control.c @@ -165,7 +165,7 @@ void trace_enable_events(const char *line_buf) if (is_help_option(line_buf)) { trace_list_events(); if (cur_mon == NULL) { - exit(0); + exit(EXIT_SUCCESS); } } else { do_trace_enable_events(line_buf); @@ -188,7 +188,7 @@ static void trace_init_events(const char *fname) fp = fopen(fname, "r"); if (!fp) { error_report("%s", strerror(errno)); - exit(1); + exit(EXIT_FAILURE); } while (fgets(line_buf, sizeof(line_buf), fp)) { loc_set_file(fname, ++line_idx); @@ -204,7 +204,7 @@ static void trace_init_events(const char *fname) if (fclose(fp) != 0) { loc_set_file(fname, 0); error_report("%s", strerror(errno)); - exit(1); + exit(EXIT_FAILURE); } loc_pop(&loc); } @@ -224,7 +224,7 @@ void trace_init_file(const char *file) if (file) { fprintf(stderr, "error: -trace file=...: " "option not supported by the selected tracing backends\n"); - exit(1); + exit(EXIT_FAILURE); } #endif } @@ -258,7 +258,7 @@ char *trace_opt_parse(const char *optarg) QemuOpts *opts = qemu_opts_parse_noisily(qemu_find_opts("trace"), optarg, true); if (!opts) { - exit(1); + exit(EXIT_FAILURE); } if (qemu_opt_get(opts, "enable")) { trace_enable_events(qemu_opt_get(opts, "enable")); diff --git a/util/error.c b/util/error.c index 9c40b1f..89b6e25 100644 --- a/util/error.c +++ b/util/error.c @@ -39,7 +39,7 @@ static void error_handle_fatal(Error **errp, Error *err) } if (errp == &error_fatal) { error_report_err(err); - exit(1); + exit(EXIT_FAILURE); } }