Message ID | 1474986431-2701-1-git-send-email-thuth@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Am 27.09.2016 um 16:27 schrieb Thomas Huth: > The get_maintainer.pl script currently thinks that the win32 > related files in the util and include folders are currently > unmaintained. Thus let's add some additional wildcards to > match these files. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 6902885..a5dec30 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -324,6 +324,8 @@ L: qemu-devel@nongnu.org > M: Stefan Weil <sw@weilnetz.de> > S: Maintained > F: *win32* > +F: */*win32* > +F: include/*/*win32* > F: qemu.nsi > > ARM Machines > Thank you, Thomas, for this patch. I suggest a small modification because there is already a maintainer for qga/ (Michael Roth) and I cannot contribute much to the QEMU guest agent. Therefore I'd prefer excluding that directory. That requires replacing */*win32* by an explicit list of directories. Otherwise fine for me. Reviewed-by: Stefan Weil <sw@weilnetz.de>
On 28.09.2016 21:28, Stefan Weil wrote: > Am 27.09.2016 um 16:27 schrieb Thomas Huth: >> The get_maintainer.pl script currently thinks that the win32 >> related files in the util and include folders are currently >> unmaintained. Thus let's add some additional wildcards to >> match these files. >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> >> --- >> MAINTAINERS | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 6902885..a5dec30 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -324,6 +324,8 @@ L: qemu-devel@nongnu.org >> M: Stefan Weil <sw@weilnetz.de> >> S: Maintained >> F: *win32* >> +F: */*win32* >> +F: include/*/*win32* >> F: qemu.nsi >> >> ARM Machines > > Thank you, Thomas, for this patch. I suggest a small modification > because there is already a maintainer for qga/ (Michael Roth) and I > cannot contribute much to the QEMU guest agent. Therefore I'd prefer > excluding that directory. That requires replacing */*win32* by an > explicit list of directories. Sure. There is even a nicer way to exclude certain files: Adding a line starting with "X:". I just sent a v2 of this patch with that line included. Thomas
diff --git a/MAINTAINERS b/MAINTAINERS index 6902885..a5dec30 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -324,6 +324,8 @@ L: qemu-devel@nongnu.org M: Stefan Weil <sw@weilnetz.de> S: Maintained F: *win32* +F: */*win32* +F: include/*/*win32* F: qemu.nsi ARM Machines
The get_maintainer.pl script currently thinks that the win32 related files in the util and include folders are currently unmaintained. Thus let's add some additional wildcards to match these files. Signed-off-by: Thomas Huth <thuth@redhat.com> --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+)