diff mbox

[1/2] tests: check-qom-proplist: Remove "bv" class property from class

Message ID 1476189467-11804-2-git-send-email-ehabkost@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Eduardo Habkost Oct. 11, 2016, 12:37 p.m. UTC
The object_property_add_bool() call in dummy_init() was always
failing because there was a "bv" class property already. Remove
the class property so both object properties and class properties
are covered by the test code.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 tests/check-qom-proplist.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Daniel P. Berrangé Oct. 11, 2016, 12:39 p.m. UTC | #1
On Tue, Oct 11, 2016 at 09:37:46AM -0300, Eduardo Habkost wrote:
> The object_property_add_bool() call in dummy_init() was always
> failing because there was a "bv" class property already. Remove
> the class property so both object properties and class properties
> are covered by the test code.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  tests/check-qom-proplist.c | 4 ----
>  1 file changed, 4 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
diff mbox

Patch

diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c
index a16cefc..693dc4c 100644
--- a/tests/check-qom-proplist.c
+++ b/tests/check-qom-proplist.c
@@ -129,10 +129,6 @@  static void dummy_init(Object *obj)
 
 static void dummy_class_init(ObjectClass *cls, void *data)
 {
-    object_class_property_add_bool(cls, "bv",
-                                   dummy_get_bv,
-                                   dummy_set_bv,
-                                   NULL);
     object_class_property_add_str(cls, "sv",
                                   dummy_get_sv,
                                   dummy_set_sv,