From patchwork Wed Oct 12 16:23:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Walle X-Patchwork-Id: 9373533 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F036C60487 for ; Wed, 12 Oct 2016 16:24:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DF537296C1 for ; Wed, 12 Oct 2016 16:24:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D2AF3296CF; Wed, 12 Oct 2016 16:24:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B71AA296C1 for ; Wed, 12 Oct 2016 16:24:18 +0000 (UTC) Received: from localhost ([::1]:34643 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buMKH-00024w-9B for patchwork-qemu-devel@patchwork.kernel.org; Wed, 12 Oct 2016 12:24:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buMJw-00024o-LJ for qemu-devel@nongnu.org; Wed, 12 Oct 2016 12:23:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buMJs-0000VC-G5 for qemu-devel@nongnu.org; Wed, 12 Oct 2016 12:23:55 -0400 Received: from ssl.serverraum.org ([213.133.101.245]:52122) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buMJs-0000Tq-7q; Wed, 12 Oct 2016 12:23:52 -0400 Received: from mwalle01.kse.adk.loc (unknown [194.25.174.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 01F4122265; Wed, 12 Oct 2016 18:23:45 +0200 (CEST) Authentication-Results: ssl.serverraum.org; dmarc=none header.from=walle.cc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1476289426; bh=9FwRVrMn1qTtUOUGGCLRpqrxVxfGYumOOl7Tt95jC84=; h=From:To:Cc:Subject:Date:From; b=UB0L10G72lpegirmFr4Jz3956PE6vNgcIQZew/rOBe7pSiekIh8JgdfkgvnNulBn5 j6zJHCG8jFS7XZQv+JDe+Wvhj0dkFb8i9+jA6H5VjsjdkOkRK+5cy7onD/n9d6KxeA EBf9CNIOyv6GmlUdYb3+H1oLspcyq+81wlZAMrPU= From: Michael Walle To: qemu-devel@nongnu.org Date: Wed, 12 Oct 2016 18:23:16 +0200 Message-Id: <1476289396-10780-1-git-send-email-michael@walle.cc> X-Mailer: git-send-email 2.1.4 X-Virus-Scanned: clamav-milter 0.99.2 at web X-Virus-Status: Clean X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 213.133.101.245 Subject: [Qemu-devel] [PATCH] target-lm32: fix style issue X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Thomas Huth , Michael Walle Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Both branches of the ternary operator have the same expressions. Drop the operator. This fixes: https://bugs.launchpad.net/qemu/+bug/1414293 Signed-off-by: Michael Walle Reviewed-by: Thomas Huth Reviewed-by: Peter Maydell --- target-lm32/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-lm32/translate.c b/target-lm32/translate.c index 2d8caeb..534c17c 100644 --- a/target-lm32/translate.c +++ b/target-lm32/translate.c @@ -343,7 +343,7 @@ static void dec_calli(DisasContext *dc) static inline void gen_compare(DisasContext *dc, int cond) { int rX = (dc->format == OP_FMT_RR) ? dc->r2 : dc->r1; - int rY = (dc->format == OP_FMT_RR) ? dc->r0 : dc->r0; + int rY = dc->r0; int rZ = (dc->format == OP_FMT_RR) ? dc->r1 : -1; int i;