diff mbox

[PULL,4/6] ui/gtk: Fix non-working DELETE key

Message ID 1477656698-13569-5-git-send-email-kraxel@redhat.com
State New, archived
Headers show

Commit Message

Gerd Hoffmann Oct. 28, 2016, 12:11 p.m. UTC
From: Thomas Huth <thuth@redhat.com>

GTK generates key events for the delete key with key->string[0] = 0x7f
... but this does not work right with the readline_handle_byte()
function in util/readline.c, since this treats the keycode 127 as
backspace. So let's add a special case for the GTK delete key to make
this key behave right in the monitor interface of the GTK ui.

Buglink: https://bugs.launchpad.net/qemu/+bug/1619438
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-id: 1477570647-7100-1-git-send-email-thuth@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
 ui/gtk.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox


diff --git a/ui/gtk.c b/ui/gtk.c
index dd13982..ca737c4 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1070,7 +1070,9 @@  static gboolean gd_text_key_down(GtkWidget *widget,
     VirtualConsole *vc = opaque;
     QemuConsole *con = vc->gfx.dcl.con;
-    if (key->length) {
+    if (key->keyval == GDK_KEY_Delete) {
+        kbd_put_qcode_console(con, Q_KEY_CODE_DELETE);
+    } else if (key->length) {
         kbd_put_string_console(con, key->string, key->length);
     } else {
         int num = gd_map_keycode(vc->s, gtk_widget_get_display(widget),