From patchwork Wed Nov 2 10:53:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ashijeet Acharya X-Patchwork-Id: 9408929 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id ADEBF601C2 for ; Wed, 2 Nov 2016 10:57:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B47D32A031 for ; Wed, 2 Nov 2016 10:57:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A92D22A04B; Wed, 2 Nov 2016 10:57:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_WEB, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 253E52A031 for ; Wed, 2 Nov 2016 10:57:21 +0000 (UTC) Received: from localhost ([::1]:54131 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1tEO-00057c-3K for patchwork-qemu-devel@patchwork.kernel.org; Wed, 02 Nov 2016 06:57:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1tDr-00052X-8b for qemu-devel@nongnu.org; Wed, 02 Nov 2016 06:56:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1tDo-0004zH-72 for qemu-devel@nongnu.org; Wed, 02 Nov 2016 06:56:47 -0400 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:35805) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c1tDo-0004z8-1N; Wed, 02 Nov 2016 06:56:44 -0400 Received: by mail-pf0-x244.google.com with SMTP id i88so1482488pfk.2; Wed, 02 Nov 2016 03:56:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=meu8YPTxj5cCwcj1s7C3OAfxl41PvS98j+7pF77XEfc=; b=s14CoXCTSKEGBAFK7ts1/LcdKJVuWKrrPTGR5QAsZrOFUGugq2fXcBNYupF14hOAre 1HSqjtuDI6kJIJXBRCHCYwSX2qUJy9tzonuu6rG/W4O7ixKwdpKliYYfgsTVJy4C+sVd Wg8ZAtbnu9HbyOOZiHTohinWBgoJbPqaXVX6SzmHCObozNvnRrjd1DMnqwmgnikZjQub EmWG337uZ+ZsMqzeM2Gbc9xoNs2QwlApu66IzDKCh3E9Ke2sfa4uzjkAehQ1CogFwjOg S9VJ/8GcUnS8h8TfuJYUIGeY0rA9qbHE8FFH02HM3ghG8PjNcwLuxEaq7wVGxZcY66Uf vFxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=meu8YPTxj5cCwcj1s7C3OAfxl41PvS98j+7pF77XEfc=; b=VlCq9eQq8tzTbKH1JC1WqATrWFlWrpGqs9KluA/IMaqVam5AIfV3Z5RB4cUwFMpkRq 52PD/sMP1r7+b2MkjgXaogIJFCgCuSt+yZP4VG8Ly3R2m83qpuKCXWPjaOLIHweXBqHR W/FZmYjGGvgzg250rUYWZxQBKTZTDrZ8xrYHWVYGSkExhWqDqQk4tEvmS+04onLQkh3n i9AlU/MAHtg1MJyz4TIwmSKMYesjqkJnnFI+6ttaxzW1OEfDo3sDApOiBqvLx6fuwAyO vA+A5qLPkKB+BCF4qRbbYHhS+3dfZzPJ50YV9lWmsqmnAr46y0wy37oE/zOkkTc9k2TN Ktig== X-Gm-Message-State: ABUngvdr8hpV6zIxaXcquckd7i5T8mPIbMM+3bnJ7TiwAHI++bHVLsWKQsXfweDb9WXaxQ== X-Received: by 10.98.31.14 with SMTP id f14mr992540pff.27.1478084202866; Wed, 02 Nov 2016 03:56:42 -0700 (PDT) Received: from linux.local ([27.251.197.196]) by smtp.gmail.com with ESMTPSA id 3sm3804776pfo.31.2016.11.02.03.56.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 02 Nov 2016 03:56:42 -0700 (PDT) From: Ashijeet Acharya To: kwolf@redhat.com Date: Wed, 2 Nov 2016 16:23:46 +0530 Message-Id: <1478084026-10163-1-git-send-email-ashijeetacharya@gmail.com> X-Mailer: git-send-email 2.6.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::244 Subject: [Qemu-devel] [PATCH v2] block/ssh: Code cleanup for unused parameter X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-block@nongnu.org, jcody@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, Ashijeet Acharya , mreitz@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch drops the unused parameter "BDRVSSHState" being passed into the ssh_config() function and does code cleanup. The unused parameter was introduced by the commit c322712. Signed-off-by: Ashijeet Acharya --- Changes in v2: - Modify the commit message and subject line --- block/ssh.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index ca071c5..15ed281 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -582,8 +582,7 @@ static bool ssh_process_legacy_socket_options(QDict *output_opts, return true; } -static InetSocketAddress *ssh_config(BDRVSSHState *s, QDict *options, - Error **errp) +static InetSocketAddress *ssh_config(QDict *options, Error **errp) { InetSocketAddress *inet = NULL; QDict *addr = NULL; @@ -661,7 +660,7 @@ static int connect_to_ssh(BDRVSSHState *s, QDict *options, } /* Pop the config into our state object, Exit if invalid */ - s->inet = ssh_config(s, options, errp); + s->inet = ssh_config(options, errp); if (!s->inet) { ret = -EINVAL; goto err;