Message ID | 1478109056-25198-2-git-send-email-jsnow@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Wed, Nov 02, 2016 at 01:50:51PM -0400, John Snow wrote: > From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > > Though it is not intended to be reached through normal circumstances, > if we do not gracefully deconstruct the transaction QLIST, we may wind > up with stale pointers in the list. > > The rest of this series attempts to address the underlying issues, > but this should fix list inconsistencies. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > Tested-by: John Snow <jsnow@redhat.com> > Reviewed-by: John Snow <jsnow@redhat.com> > [Rewrote commit message. --js] > Signed-off-by: John Snow <jsnow@redhat.com> > Reviewed-by: Eric Blake <eblake@redhat.com> > Reviewed-by: Kevin Wolf <kwolf@redhat.com> > > Signed-off-by: John Snow <jsnow@redhat.com> > --- > blockjob.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/blockjob.c b/blockjob.c > index 4aa14a4..4d0ef53 100644 > --- a/blockjob.c > +++ b/blockjob.c > @@ -256,6 +256,7 @@ static void block_job_completed_single(BlockJob *job) > } > > if (job->txn) { > + QLIST_REMOVE(job, txn_list); > block_job_txn_unref(job->txn); > } > block_job_unref(job); > -- > 2.7.4 > Reviewed-by: Jeff Cody <jcody@redhat.com>
diff --git a/blockjob.c b/blockjob.c index 4aa14a4..4d0ef53 100644 --- a/blockjob.c +++ b/blockjob.c @@ -256,6 +256,7 @@ static void block_job_completed_single(BlockJob *job) } if (job->txn) { + QLIST_REMOVE(job, txn_list); block_job_txn_unref(job->txn); } block_job_unref(job);