From patchwork Mon Nov 14 14:32:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 9427643 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5947260471 for ; Mon, 14 Nov 2016 14:33:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4BFC926490 for ; Mon, 14 Nov 2016 14:33:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 408B428448; Mon, 14 Nov 2016 14:33:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B818726490 for ; Mon, 14 Nov 2016 14:33:04 +0000 (UTC) Received: from localhost ([::1]:40565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6IJj-0000iP-WE for patchwork-qemu-devel@patchwork.kernel.org; Mon, 14 Nov 2016 09:33:04 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45928) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6IIz-0000cU-B9 for qemu-devel@nongnu.org; Mon, 14 Nov 2016 09:32:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6IIy-0008JE-7m for qemu-devel@nongnu.org; Mon, 14 Nov 2016 09:32:17 -0500 Received: from mx2.suse.de ([195.135.220.15]:54803) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c6IIr-0008Hc-DK; Mon, 14 Nov 2016 09:32:09 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id CB18DAC48; Mon, 14 Nov 2016 14:32:06 +0000 (UTC) From: Alexander Graf To: QEMU Developers Date: Mon, 14 Nov 2016 15:32:15 +0100 Message-Id: <1479133935-63848-3-git-send-email-agraf@suse.de> X-Mailer: git-send-email 1.8.5.6 In-Reply-To: <1479133935-63848-1-git-send-email-agraf@suse.de> References: <1479133935-63848-1-git-send-email-agraf@suse.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 195.135.220.15 Subject: [Qemu-devel] [PATCH RFC v2 2/2] ARM: KVM: Enable in-kernel timers with user space gic X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm , kvm-devel , Paolo Bonzini Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP When running with KVM enabled, you can choose between emulating the gic in kernel or user space. If the kernel supports in-kernel virtualization of the interrupt controller, it will default to that. If not, if will default to user space emulation. Unfortunately when running in user mode gic emulation, we miss out on timer events which are only available from kernel space. This patch leverages the new kernel/user space pending line synchronization for those timer events. Signed-off-by: Alexander Graf Reviewed-by: Peter Maydell --- rfc1 -> rfc2: - use local variable for ARM_CPU - remove bear trap - move timer warning to gic device --- hw/intc/arm_gic.c | 7 +++++++ include/sysemu/kvm.h | 11 +++++++++++ kvm-all.c | 5 +++++ kvm-stub.c | 5 +++++ target-arm/cpu.h | 3 +++ target-arm/kvm.c | 20 ++++++++++++++++++++ 6 files changed, 51 insertions(+) diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c index 521aac3..1f3aacf 100644 --- a/hw/intc/arm_gic.c +++ b/hw/intc/arm_gic.c @@ -25,6 +25,7 @@ #include "qom/cpu.h" #include "qemu/log.h" #include "trace.h" +#include "sysemu/kvm.h" //#define DEBUG_GIC @@ -1428,6 +1429,12 @@ static void arm_gic_realize(DeviceState *dev, Error **errp) return; } + if (kvm_enabled() && !kvm_arm_supports_timer()) { + error_setg(errp, "KVM with user space irqchip only works when the " + "host kernel supports KVM_CAP_ARM_TIMER"); + return; + } + /* This creates distributor and main CPU interface (s->cpuiomem[0]) */ gic_init_irqs_and_mmio(s, gic_set_irq, gic_ops); diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h index df67cc0..9715fee 100644 --- a/include/sysemu/kvm.h +++ b/include/sysemu/kvm.h @@ -227,6 +227,17 @@ int kvm_init_vcpu(CPUState *cpu); int kvm_cpu_exec(CPUState *cpu); int kvm_destroy_vcpu(CPUState *cpu); +/** + * kvm_arm_supports_timer + * + * Not all KVM implementations support notifications for the CP15 timers to + * user space. This function indicates whether the current KVM implementation + * does support them. + * + * Returns: true if KVM supports using ARM core timers from user space + */ +bool kvm_arm_supports_timer(void); + #ifdef NEED_CPU_H #include "cpu.h" diff --git a/kvm-all.c b/kvm-all.c index 330219e..8d4696c 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -2194,6 +2194,11 @@ int kvm_has_intx_set_mask(void) return kvm_state->intx_set_mask; } +bool kvm_arm_supports_timer(void) +{ + return kvm_check_extension(kvm_state, KVM_CAP_ARM_TIMER); +} + #ifdef KVM_CAP_SET_GUEST_DEBUG struct kvm_sw_breakpoint *kvm_find_sw_breakpoint(CPUState *cpu, target_ulong pc) diff --git a/kvm-stub.c b/kvm-stub.c index b1b6b96..a4d408b 100644 --- a/kvm-stub.c +++ b/kvm-stub.c @@ -157,4 +157,9 @@ bool kvm_has_free_slot(MachineState *ms) { return false; } + +bool kvm_arm_supports_timer(void) +{ + return false; +} #endif diff --git a/target-arm/cpu.h b/target-arm/cpu.h index ca5c849..2c379a3 100644 --- a/target-arm/cpu.h +++ b/target-arm/cpu.h @@ -659,6 +659,9 @@ struct ARMCPU { ARMELChangeHook *el_change_hook; void *el_change_hook_opaque; + + /* Used to synchronize KVM and QEMU timer levels */ + uint8_t timer_irq_level; }; static inline ARMCPU *arm_env_get_cpu(CPUARMState *env) diff --git a/target-arm/kvm.c b/target-arm/kvm.c index c00b94e..c5f0d37 100644 --- a/target-arm/kvm.c +++ b/target-arm/kvm.c @@ -527,6 +527,26 @@ void kvm_arch_pre_run(CPUState *cs, struct kvm_run *run) MemTxAttrs kvm_arch_post_run(CPUState *cs, struct kvm_run *run) { + ARMCPU *cpu; + bool vtimer_high; + + if (kvm_irqchip_in_kernel()) { + /* + * We only need to sync timer states with user-space interrupt + * controllers, so return early and save cycles if we don't. + */ + return MEMTXATTRS_UNSPECIFIED; + } + + cpu = ARM_CPU(cs); + + /* Synchronize our internal vtimer irq line with the kvm one */ + if (run->s.regs.timer_irq_level != cpu->timer_irq_level) { + vtimer_high = run->s.regs.timer_irq_level & KVM_ARM_TIMER_VTIMER; + qemu_set_irq(cpu->gt_timer_outputs[GTIMER_VIRT], vtimer_high ? 1 : 0); + cpu->timer_irq_level = run->s.regs.timer_irq_level; + } + return MEMTXATTRS_UNSPECIFIED; }