diff mbox

[08/17] wctablet: drop debug code from wctablet_handler

Message ID 1483692945-9866-9-git-send-email-kraxel@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Gerd Hoffmann Jan. 6, 2017, 8:55 a.m. UTC 
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 backends/wctablet.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Eric Blake Jan. 6, 2017, 1:17 p.m. UTC | #1 
On 01/06/2017 02:55 AM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  backends/wctablet.c | 6 ------
>  1 file changed, 6 deletions(-)

Why not just squash this into 1/17?

> 
> diff --git a/backends/wctablet.c b/backends/wctablet.c
> index 84fb485..d0ee0e4 100644
> --- a/backends/wctablet.c
> +++ b/backends/wctablet.c
> @@ -204,12 +204,6 @@ static void wctablet_handler(void *opaque)
>      }
>  
>      if (len) {
> -        // DPRINTF("-------- Write %2d: ", canWrite);
> -        // for (i = 0; i < len; i++) {
> -        //     DPRINTF(" %02x", tablet->outbuf[i]);
> -        // }
> -        // DPRINTF("\n");
> -
>          qemu_chr_be_write(chr, tablet->outbuf, len);
>          tablet->outlen -= len;
>          if (tablet->outlen) {
>
Gerd Hoffmann Jan. 9, 2017, 7:50 a.m. UTC | #2 
On Fr, 2017-01-06 at 07:17 -0600, Eric Blake wrote:
> On 01/06/2017 02:55 AM, Gerd Hoffmann wrote:
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> >  backends/wctablet.c | 6 ------
> >  1 file changed, 6 deletions(-)
> 
> Why not just squash this into 1/17?

My intention is to keep the submission by Anatoli separate from the
cleanups and improvements I did.  Also in case I introduced any
regressions it is easier to figure which change broke things this way.

For the actual merge it probably makes sense to just squash the whole
series into a single patch.

cheers,
  Gerd
diff mbox

Patch

diff --git a/backends/wctablet.c b/backends/wctablet.c
index 84fb485..d0ee0e4 100644
--- a/backends/wctablet.c
+++ b/backends/wctablet.c
@@ -204,12 +204,6 @@  static void wctablet_handler(void *opaque)
     }
 
     if (len) {
-        // DPRINTF("-------- Write %2d: ", canWrite);
-        // for (i = 0; i < len; i++) {
-        //     DPRINTF(" %02x", tablet->outbuf[i]);
-        // }
-        // DPRINTF("\n");
-
         qemu_chr_be_write(chr, tablet->outbuf, len);
         tablet->outlen -= len;
         if (tablet->outlen) {