| Message ID | 1486576669-29760-1-git-send-email-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Thomas Huth <thuth@redhat.com> writes: > The "or-irq" device needs to be wired up in source code, there is no > way the user can make any real use of this device with the "-device" > parameter or the "device_add" monitor command yet. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com>
On Wed, Feb 8, 2017 at 11:27 PM, Markus Armbruster <armbru@redhat.com> wrote: > Thomas Huth <thuth@redhat.com> writes: > >> The "or-irq" device needs to be wired up in source code, there is no >> way the user can make any real use of this device with the "-device" >> parameter or the "device_add" monitor command yet. >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> > > Reviewed-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@xilinx.com> Thanks, Alistair >
diff --git a/hw/core/or-irq.c b/hw/core/or-irq.c index 1ac090d..1485d5b 100644 --- a/hw/core/or-irq.c +++ b/hw/core/or-irq.c @@ -89,6 +89,9 @@ static void or_irq_class_init(ObjectClass *klass, void *data) dc->props = or_irq_properties; dc->realize = or_irq_realize; dc->vmsd = &vmstate_or_irq; + + /* Reason: Needs to be wired up to work, e.g. see stm32f205_soc.c */ + dc->cannot_instantiate_with_device_add_yet = true; } static const TypeInfo or_irq_type_info = {
The "or-irq" device needs to be wired up in source code, there is no way the user can make any real use of this device with the "-device" parameter or the "device_add" monitor command yet. Signed-off-by: Thomas Huth <thuth@redhat.com> --- v3: Another update to the patch description and comment hw/core/or-irq.c | 3 +++ 1 file changed, 3 insertions(+)