From patchwork Wed Jun 7 00:17:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emilio Cota X-Patchwork-Id: 9770237 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1B48560353 for ; Wed, 7 Jun 2017 00:17:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E822B284C5 for ; Wed, 7 Jun 2017 00:17:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DBAA328520; Wed, 7 Jun 2017 00:17:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 02B57284C5 for ; Wed, 7 Jun 2017 00:17:54 +0000 (UTC) Received: from localhost ([::1]:40523 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIOfZ-00062M-9X for patchwork-qemu-devel@patchwork.kernel.org; Tue, 06 Jun 2017 20:17:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIOet-0005y1-HS for qemu-devel@nongnu.org; Tue, 06 Jun 2017 20:17:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIOeq-0004SP-Be for qemu-devel@nongnu.org; Tue, 06 Jun 2017 20:17:11 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39301) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dIOep-0004Rz-Tp for qemu-devel@nongnu.org; Tue, 06 Jun 2017 20:17:08 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3795C20E40; Tue, 6 Jun 2017 20:17:05 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Tue, 06 Jun 2017 20:17:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=YNl Rz83Bsa2USY2b7bAdpYwGaR7uvOilq1GiFUOnCh0=; b=M0tge7nfEWWw4gpiJ42 1J7+EgTzSB+KmFo4BP1Y+aol7v3GsBowTz9d1fBfS6nPmrS46OujZ+Ywx0oVUteN NKpfCtIWeVzepaG/QaQED3USalMocAZ6RkmL55yKRWwri96dBhwlDmpgY3Fta5fo LvvjAXzDSXL9fkSlcUD6Pjz0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=YNlRz83Bsa2USY2b7bAdpYwGaR7uvOilq1GiFUOnC h0=; b=h9P1K0MvCup9XaB40yRP0/g4beErUor6nxRbhwt+ih+8kanaHpgamXFqS NSpsP89oHMJKfM0HVdjABlQVNhEuLMTd87nftqX6UAx4PA9L05dNs0XII5hmQqLp N0VKJLTAQGq0k91nUp7CIbKPYGwsCSY1VSQqj27Gs/HTLmFb8vfWrO06sPBsf76K +LgQr+rDpaf3FlxZhh+Bt+BVzhcS7cNpJUolK31DLZAr5khJqnf6byP+VYvA/rgr LJR84JoRKVdRbD7ltLVMgSRCdU2BC7teUs8NtsLplN6AfiDJKJuEc0FWhH2NU3Gc 37jNIOoHC45N8cZu/V47VrVNV33Ow== X-ME-Sender: X-Sasl-enc: fxi8JVSmfi1h3VRMidbXm45jylYGgRDbUe4GJ2/I5Dbk 1496794625 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id F247A7E850; Tue, 6 Jun 2017 20:17:04 -0400 (EDT) From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Tue, 6 Jun 2017 20:17:04 -0400 Message-Id: <1496794624-4083-1-git-send-email-cota@braap.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1496790745-314-2-git-send-email-cota@braap.org> References: <1496790745-314-2-git-send-email-cota@braap.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 Subject: [Qemu-devel] [PATCH v3 1/2 -- fixed] util: add cacheinfo X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Geert Martin Ijewski , Paolo Bonzini , Pranith Kumar , alex.bennee@linaro.org, Richard Henderson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Add helpers to gather cache info from the host at init-time. For now, only export the host's I/D cache line sizes, which we will use to improve cache locality to avoid false sharing. Suggested-by: Richard Henderson Suggested-by: Geert Martin Ijewski Tested-by: Geert Martin Ijewski Signed-off-by: Emilio G. Cota Reviewed-by: Pranith Kumar --- include/qemu/osdep.h | 3 + util/Makefile.objs | 1 + util/cacheinfo.c | 158 +++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 162 insertions(+) create mode 100644 util/cacheinfo.c diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 1c9f5e2..ee43521 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -470,4 +470,7 @@ char *qemu_get_pid_name(pid_t pid); */ pid_t qemu_fork(Error **errp); +extern int qemu_icache_linesize; +extern int qemu_dcache_linesize; + #endif diff --git a/util/Makefile.objs b/util/Makefile.objs index c6205eb..94d9477 100644 --- a/util/Makefile.objs +++ b/util/Makefile.objs @@ -20,6 +20,7 @@ util-obj-y += host-utils.o util-obj-y += bitmap.o bitops.o hbitmap.o util-obj-y += fifo8.o util-obj-y += acl.o +util-obj-y += cacheinfo.o util-obj-y += error.o qemu-error.o util-obj-y += id.o util-obj-y += iov.o qemu-config.o qemu-sockets.o uri.o notify.o diff --git a/util/cacheinfo.c b/util/cacheinfo.c new file mode 100644 index 0000000..41dccb1 --- /dev/null +++ b/util/cacheinfo.c @@ -0,0 +1,158 @@ +/* + * cacheinfo.c - helpers to query the host about its caches + * + * Copyright (C) 2017, Emilio G. Cota + * License: GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + */ + +#include "qemu/osdep.h" + +int qemu_icache_linesize = 64; +int qemu_dcache_linesize = 64; + +#ifdef _WIN32 +static unsigned int linesize_win(PROCESSOR_CACHE_TYPE type) +{ + PSYSTEM_LOGICAL_PROCESSOR_INFORMATION buf; + DWORD size = 0; + unsigned int ret = 0; + BOOL success; + size_t n; + size_t i; + + success = GetLogicalProcessorInformation(0, &size); + if (success || GetLastError() != ERROR_INSUFFICIENT_BUFFER) { + return 0; + } + buf = (PSYSTEM_LOGICAL_PROCESSOR_INFORMATION)g_malloc0(size); + if (!GetLogicalProcessorInformation(buf, &size)) { + goto out; + } + + n = size / sizeof(SYSTEM_LOGICAL_PROCESSOR_INFORMATION); + for (i = 0; i < n; i++) { + if (buf[i].Relationship == RelationCache && + buf[i].Cache.Level == 1 && + (buf[i].Cache.Type == CacheUnified || + buf[i].Cache.Type == type)) { + ret = buf[i].Cache.LineSize; + break; + } + } + out: + g_free(buf); + return ret; +} +#endif + +#ifdef __APPLE__ +#include + +unsigned int linesize_apple(void) +{ + unsigned long bytes; + size_t len = sizeof(bytes); + + /* There's only a single sysctl for both I/D cache line sizes */ + if (sysctlbyname("hw.cachelinesize", &bytes, &len, NULL, 0)) { + return 0; + } + return bytes; +} +#endif + +static void icache_info(void) +{ + #ifdef _SC_LEVEL1_ICACHE_LINESIZE + { + long x = sysconf(_SC_LEVEL1_ICACHE_LINESIZE); + + if (x > 0) { + qemu_icache_linesize = x; + return; + } + } + #endif + #ifdef AT_ICACHEBSIZE + /* glibc does not always export this through sysconf, e.g. on PPC */ + { + unsigned long x = qemu_getauxval(AT_ICACHEBSIZE); + + if (x > 0) { + qemu_icache_linesize = x; + return; + } + } + #endif + #ifdef _WIN32 + { + unsigned int x = linesize_win(CacheInstruction); + + if (x > 0) { + qemu_icache_linesize = x; + return; + } + } + #endif + #ifdef __APPLE__ + { + unsigned int x = linesize_apple(); + + if (x > 0) { + qemu_icache_linesize = x; + return; + } + } + #endif +} + +static void dcache_info(void) +{ + #ifdef _SC_LEVEL1_DCACHE_LINESIZE + { + long x = sysconf(_SC_LEVEL1_DCACHE_LINESIZE); + + if (x > 0) { + qemu_dcache_linesize = x; + return; + } + } + #endif + #ifdef AT_DCACHEBSIZE + { + unsigned long x = qemu_getauxval(AT_DCACHEBSIZE); + + if (x > 0) { + qemu_dcache_linesize = x; + return; + } + } + #endif + #ifdef _WIN32 + { + unsigned int x = linesize_win(CacheData); + + if (x > 0) { + qemu_dcache_linesize = x; + return; + } + } + #endif + #ifdef __APPLE__ + { + unsigned int x = linesize_apple(); + + if (x > 0) { + qemu_dcache_linesize = x; + return; + } + } + #endif +} + +static void __attribute__((constructor)) cacheinfo_init(void) +{ + icache_info(); + dcache_info(); +}