From patchwork Fri Jun 16 18:55:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gabriel L. Somlo" X-Patchwork-Id: 9793301 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 03F9A6038F for ; Fri, 16 Jun 2017 18:56:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EBF3B2865B for ; Fri, 16 Jun 2017 18:56:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E0BC828672; Fri, 16 Jun 2017 18:56:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 522BC2866B for ; Fri, 16 Jun 2017 18:56:39 +0000 (UTC) Received: from localhost ([::1]:60362 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLwQA-0004Uq-0R for patchwork-qemu-devel@patchwork.kernel.org; Fri, 16 Jun 2017 14:56:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLwP8-0004UL-QT for qemu-devel@nongnu.org; Fri, 16 Jun 2017 14:55:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dLwP7-0006Ym-W5 for qemu-devel@nongnu.org; Fri, 16 Jun 2017 14:55:34 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:35160) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dLwP7-0006Y6-SZ for qemu-devel@nongnu.org; Fri, 16 Jun 2017 14:55:33 -0400 Received: by mail-qt0-x243.google.com with SMTP id x58so12311685qtc.2 for ; Fri, 16 Jun 2017 11:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vELz7niruQKAcErHMpR99MavOiYYxwWbo2gBI6HMKiU=; b=Vgg5K03nnZ7IizYfrzpMrR61iEUxTvU3k2d2B1nQuNgPC4vYT7K3E66oz3heDPNA3F cimCI2RnE5eBSobunucQ5otqdfZXQDZjnoUkCdmL+dcI/4OHu7AhFXegPQHSZobScxgg DoPiCknDBXfiNQWbbArVnNbid30sVCWwI0w2YyH/otsPTfdMy0/snOkCJwPYZ/O+Bua5 KAh3G8xrUZfPCasmyB8X6cvXpzShnK1SulIVevAvOsh+uOt5Jt1PJrYsEfKg7vm/7qMc EpXQEdl4jIpc7D/53TKzj2aKxgJuE/z3ib49aNx//Tqu5YBQS4tkkik93hx9U9XX3yTm 4Obw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vELz7niruQKAcErHMpR99MavOiYYxwWbo2gBI6HMKiU=; b=Kt4TDkwRnIhVHR5L+lKHIs4KFZ5yvYhzNOaCNrBL6LUBTPbIQcjRgbCXPZvRCt7tah VMV/6GAeN8vLV84pMHEuag0QKe+V2KAsdDmsAln/HXBSO+pY3zUH3bhH9Gjnn1yJHHmS QzkAhA6cU3sIisaeI3KYliWA8pKFqvOx79tF9lEtdJTRrhDGc02j7K/KkmO/ogmLy68w zSz1Bm+72FhgkXBHYoQqjkJvL6YNX06nEfMl80r6cnrJmWiGrfAO86oVniyfvzKwwc8X A1s6a9gWRsJuYFrwZNbXoDd+n4hrDsjBTBJbRvyfg8xZXLBlmRTOT7xhTIfQUDhAjXEI HqQA== X-Gm-Message-State: AKS2vOzBhzUQGZFudGH9z2HG2JBfdJ/yeZ/X+POuw/oEpgCg9wWoOkWM n8zc7FwJ8wRdK5w3 X-Received: by 10.200.8.67 with SMTP id x3mr14535987qth.195.1497639333005; Fri, 16 Jun 2017 11:55:33 -0700 (PDT) Received: from HEDWIG.ini.cmu.edu (HEDWIG.INI.CMU.EDU. [128.2.16.51]) by smtp.gmail.com with ESMTPSA id p24sm1761565qki.49.2017.06.16.11.55.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Jun 2017 11:55:31 -0700 (PDT) From: "Gabriel L. Somlo" To: qemu-devel@nongnu.org Date: Fri, 16 Jun 2017 14:55:16 -0400 Message-Id: <1497639316-22202-4-git-send-email-gsomlo@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1497639316-22202-1-git-send-email-gsomlo@gmail.com> References: <1497639316-22202-1-git-send-email-gsomlo@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH v3 3/3] applesmc: fix port i/o access width X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, eshelton@pobox.com, agraf@suse.de, f4bug@amsat.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Set access width of all AppleSMC i/o regions to 1 byte, since they all represent 8-bit-wide ports. Signed-off-by: Gabriel Somlo Reviewed-by: Alexander Graf --- hw/misc/applesmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c index 0d882e8..7896812 100644 --- a/hw/misc/applesmc.c +++ b/hw/misc/applesmc.c @@ -316,12 +316,12 @@ static void applesmc_isa_realize(DeviceState *dev, Error **errp) AppleSMCState *s = APPLE_SMC(dev); memory_region_init_io(&s->io_data, OBJECT(s), &applesmc_data_io_ops, s, - "applesmc-data", 4); + "applesmc-data", 1); isa_register_ioport(&s->parent_obj, &s->io_data, s->iobase + APPLESMC_DATA_PORT); memory_region_init_io(&s->io_cmd, OBJECT(s), &applesmc_cmd_io_ops, s, - "applesmc-cmd", 4); + "applesmc-cmd", 1); isa_register_ioport(&s->parent_obj, &s->io_cmd, s->iobase + APPLESMC_CMD_PORT);