| Message ID | 1502979556-31791-1-git-send-email-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Aug 17, 2017 at 04:19:16PM +0200, Thomas Huth wrote: > QEMU currently aborts unexpectedly when the user tries to add and > remove a "spapr-tce-table" device: > > $ qemu-system-ppc64 -nographic -S -nodefaults -monitor stdio > QEMU 2.9.92 monitor - type 'help' for more information > (qemu) device_add spapr-tce-table,id=x > (qemu) device_del x > ** > ERROR:qemu/qdev-monitor.c:872:qdev_unplug: assertion failed: (hotplug_ctrl) > Aborted (core dumped) > > The device should not be accessable for the users at all, it's just > used internally, so mark it with user_creatable = false. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Applied to ppc-for-2.10. > --- > hw/ppc/spapr_iommu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c > index e614621..ed2d535 100644 > --- a/hw/ppc/spapr_iommu.c > +++ b/hw/ppc/spapr_iommu.c > @@ -618,6 +618,8 @@ static void spapr_tce_table_class_init(ObjectClass *klass, void *data) > dc->init = spapr_tce_table_realize; > dc->reset = spapr_tce_reset; > dc->unrealize = spapr_tce_table_unrealize; > + /* Reason: This is just an internal device for handling the hypercalls */ > + dc->user_creatable = false; > > QLIST_INIT(&spapr_tce_tables); >
diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c index e614621..ed2d535 100644 --- a/hw/ppc/spapr_iommu.c +++ b/hw/ppc/spapr_iommu.c @@ -618,6 +618,8 @@ static void spapr_tce_table_class_init(ObjectClass *klass, void *data) dc->init = spapr_tce_table_realize; dc->reset = spapr_tce_reset; dc->unrealize = spapr_tce_table_unrealize; + /* Reason: This is just an internal device for handling the hypercalls */ + dc->user_creatable = false; QLIST_INIT(&spapr_tce_tables);
QEMU currently aborts unexpectedly when the user tries to add and remove a "spapr-tce-table" device: $ qemu-system-ppc64 -nographic -S -nodefaults -monitor stdio QEMU 2.9.92 monitor - type 'help' for more information (qemu) device_add spapr-tce-table,id=x (qemu) device_del x ** ERROR:qemu/qdev-monitor.c:872:qdev_unplug: assertion failed: (hotplug_ctrl) Aborted (core dumped) The device should not be accessable for the users at all, it's just used internally, so mark it with user_creatable = false. Signed-off-by: Thomas Huth <thuth@redhat.com> --- hw/ppc/spapr_iommu.c | 2 ++ 1 file changed, 2 insertions(+)