| Message ID | 150471163020.18882.9386672218918089445.stgit@frigg.lan (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Sep 06, 2017 at 18:27:10 +0300, Lluís Vilanova wrote: > Right now, function trace_event_set_vcpu_state_dynamic() asynchronously enables > events in the case a vCPU is executing TCG code. If the vCPU is being created > this makes some events like "guest_cpu_enter" to not be traced. > > Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu> > --- > trace/control-target.c | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/trace/control-target.c b/trace/control-target.c > index 4e36101997..0056da6a46 100644 > --- a/trace/control-target.c > +++ b/trace/control-target.c > @@ -88,13 +88,18 @@ void trace_event_set_vcpu_state_dynamic(CPUState *vcpu, > clear_bit(vcpu_id, vcpu->trace_dstate_delayed); > (*ev->dstate)--; > } > - /* > - * Delay changes until next TB; we want all TBs to be built from a > - * single set of dstate values to ensure consistency of generated > - * tracing code. > - */ > - async_run_on_cpu(vcpu, trace_event_synchronize_vcpu_state_dynamic, > - RUN_ON_CPU_NULL); > + if (vcpu->created) { > + /* > + * Delay changes until next TB; we want all TBs to be built from a > + * single set of dstate values to ensure consistency of generated > + * tracing code. > + */ > + async_run_on_cpu(vcpu, trace_event_synchronize_vcpu_state_dynamic, > + RUN_ON_CPU_NULL); > + } else { > + run_on_cpu_data ignored; > + trace_event_synchronize_vcpu_state_dynamic(vcpu, ignored); I'd prefer RUN_ON_CPU_NULL here instead of the ignored param. Other than that, Reviewed-by: Emilio G. Cota <cota@braap.org> E.
diff --git a/trace/control-target.c b/trace/control-target.c index 4e36101997..0056da6a46 100644 --- a/trace/control-target.c +++ b/trace/control-target.c @@ -88,13 +88,18 @@ void trace_event_set_vcpu_state_dynamic(CPUState *vcpu, clear_bit(vcpu_id, vcpu->trace_dstate_delayed); (*ev->dstate)--; } - /* - * Delay changes until next TB; we want all TBs to be built from a - * single set of dstate values to ensure consistency of generated - * tracing code. - */ - async_run_on_cpu(vcpu, trace_event_synchronize_vcpu_state_dynamic, - RUN_ON_CPU_NULL); + if (vcpu->created) { + /* + * Delay changes until next TB; we want all TBs to be built from a + * single set of dstate values to ensure consistency of generated + * tracing code. + */ + async_run_on_cpu(vcpu, trace_event_synchronize_vcpu_state_dynamic, + RUN_ON_CPU_NULL); + } else { + run_on_cpu_data ignored; + trace_event_synchronize_vcpu_state_dynamic(vcpu, ignored); + } } }
Right now, function trace_event_set_vcpu_state_dynamic() asynchronously enables events in the case a vCPU is executing TCG code. If the vCPU is being created this makes some events like "guest_cpu_enter" to not be traced. Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu> --- trace/control-target.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-)