From patchwork Thu Oct 19 20:04:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Aaron Lindsay X-Patchwork-Id: 10018225 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B52ED60224 for ; Thu, 19 Oct 2017 20:05:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A841728D63 for ; Thu, 19 Oct 2017 20:05:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9C58028E44; Thu, 19 Oct 2017 20:05:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F035F28D63 for ; Thu, 19 Oct 2017 20:05:39 +0000 (UTC) Received: from localhost ([::1]:51049 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5H4U-00056n-H9 for patchwork-qemu-devel@patchwork.kernel.org; Thu, 19 Oct 2017 16:05:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5H3q-00056U-0M for qemu-devel@nongnu.org; Thu, 19 Oct 2017 16:04:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5H3m-0005fT-0P for qemu-devel@nongnu.org; Thu, 19 Oct 2017 16:04:57 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42370) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e5H3l-0005et-NG for qemu-devel@nongnu.org; Thu, 19 Oct 2017 16:04:53 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 66D8160585; Thu, 19 Oct 2017 20:04:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1508443491; bh=MsfePZVzynieAy+ebvtWHoUQC/mZrbrS/LXbw2ZtYTc=; h=From:To:Cc:Subject:Date:From; b=WLgQx9jAxxquL+O972VHT3OzY0hVxyO5ZR8VSVBRIFuELEo6U7HjfbLWQx5TJ5QVr HXPskfGzHLIYd373F9zj06q9CXOF/X8KkB1h2nPrg8yayjtJ9rpZ+Gqq985rmpXf+G Wcmru1qeXlQ7kiXK44lQeTQMGCmE/IF0cGGedG50= Received: from mossypile.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: alindsay@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id EF25B60287; Thu, 19 Oct 2017 20:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1508443490; bh=MsfePZVzynieAy+ebvtWHoUQC/mZrbrS/LXbw2ZtYTc=; h=From:To:Cc:Subject:Date:From; b=O7YVDTizlrTCzxrV3TUnXDM9AYWXYpfgQc5Ve9wV8VzpJeHNQV3omQBLGnGfhwU+t 31mr3xbNQghI9aDS7Yi7XTm052S2YXUQ4BdomLhXMNIaGP3+x2m0yUfJKhPn5ygTFs 66jeBxGXk7aoQcoqXY/6PJZ5qHyHAnB8Hs7/9Uz8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EF25B60287 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=alindsay@codeaurora.org From: Aaron Lindsay To: qemu-devel@nongnu.org Date: Thu, 19 Oct 2017 16:04:43 -0400 Message-Id: <1508443483-5429-1-git-send-email-alindsay@codeaurora.org> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 198.145.29.96 Subject: [Qemu-devel] [PATCH] build: Don't force preserving permissions on config-devices.mak.old X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Weil , Markus Armbruster , Gerd Hoffmann , Stefan Hajnoczi , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paul Brook Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP I get the following error when building on an NFSv3 filesystem: % make -j8 GEN aarch64-softmmu/config-devices.mak.tmp GEN config-host.h [snip] GEN qmp-marshal.c GEN aarch64-softmmu/config-devices.mak cp: preserving permissions for ‘aarch64-softmmu/config-devices.mak.old’: Operation not supported make: *** Deleting file `aarch64-softmmu/config-devices.mak' GEN qapi-types.c [snip] CC scsi/qemu-pr-helper.o make: *** No rule to make target `config-all-devices.mak', needed by `subdir-aarch64-softmmu'. Stop. make: *** Waiting for unfinished jobs.... Ideally you would only build on a filesystem with proper support, but I haven't been able to find a reason why preserving exact permissions is important in this case. Signed-off-by: Aaron Lindsay Reviewed-by: Stefan Hajnoczi --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 9372742..952b6df 100644 --- a/Makefile +++ b/Makefile @@ -287,7 +287,7 @@ endif $(call quiet-command, if test -f $@; then \ if cmp -s $@.old $@; then \ mv $@.tmp $@; \ - cp -p $@ $@.old; \ + cp $@ $@.old; \ else \ if test -f $@.old; then \ echo "WARNING: $@ (user modified) out of date.";\ @@ -299,7 +299,7 @@ endif fi; \ else \ mv $@.tmp $@; \ - cp -p $@ $@.old; \ + cp $@ $@.old; \ fi,"GEN","$@"); defconfig: