diff mbox

[Bug,1728325,NEW] POWER8: Wrong behaviour with float-to-int punning

Message ID 150923941073.9276.8418169350776607737.malonedeb@wampee.canonical.com (mailing list archive)
State New, archived
Headers show

Commit Message

Launchpad Bug Tracker Oct. 29, 2017, 1:10 a.m. UTC
Public bug reported:

Building a reduced test program with 'gcc -O2 -fno-inline -mcpu=power8'
produces wrong results at runtime. I don't think gcc is at fault here.

---
#include <stdio.h>

int getWord(const float x)
{
  return *(int*)&x;
}

void main()
{
    int foo = getWord(+123.456f);
    int bar = getWord(-123.456f);

    printf("%d\n", foo);
    printf("%d\n", bar);
    return;
}
---

This prints:
---
0
0
---

Compiling with 'gcc -O2 -fno-inline -mcpu=power7' and you instead get the expected result:
---
1123477881
-1024005767
---


The different between the two programs is:

        .size   getWord,.-getWord


Seems like qemu doesn't handle xscvdpspn/mfvsrwz correctly.

https://github.com/qemu/qemu/commit/7ee19fb9d682689d36c849576c808cf92e3bae40
https://github.com/qemu/qemu/commit/f5c0f7f981333da59cc35c3210d05ec1775c97c1

** Affects: qemu
     Importance: Undecided
         Status: New

Comments

Launchpad Bug Tracker Oct. 29, 2017, 1:15 a.m. UTC | #1
I am running:

qemu-ppc64le-static -L /usr/powerpc64le-linux-gnu ./a.out
Richard Henderson Oct. 31, 2017, 9:35 a.m. UTC | #2
This is buggy C.

https://gcc.gnu.org/bugs/#nonbugs_c

** Changed in: qemu
       Status: New => Invalid
Launchpad Bug Tracker Oct. 31, 2017, 10:38 a.m. UTC | #3
The original code used a union.  It generates the same assembler all the
same.

** Changed in: qemu
       Status: Invalid => New
Launchpad Bug Tracker Nov. 10, 2020, 3:11 a.m. UTC | #4
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now.
If you still think this bug report here is valid, then please switch the state back to "New" within the next 60 days, otherwise this report will be marked as "Expired". Or mark it as "Fix Released" if the problem has been solved with a newer version of QEMU already. Thank you and sorry for the inconvenience.


** Changed in: qemu
       Status: New => Incomplete
Launchpad Bug Tracker Jan. 9, 2021, 4:17 a.m. UTC | #5
[Expired for QEMU because there has been no activity for 60 days.]

** Changed in: qemu
       Status: Incomplete => Expired
diff mbox

Patch

--- power7.s
+++ power8.s
@@ -6,9 +6,9 @@ 
 	.globl getWord
 	.type	getWord, @function
 getWord:
-	stfs 1,-16(1)
-	ori 2,2,0
-	lwa 3,-16(1)
+	xscvdpspn 0,1
+	mfvsrwz 3,0
+	extsw 3,3
 	blr
 	.long 0
 	.byte 0,0,0,0,0,0,0,0