| Message ID | 1519071820-4062-1-git-send-email-thuth@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Feb 19, 2018 at 09:23:40PM +0100, Thomas Huth wrote: > It's been marked as deprecated since a very long time already, and > the parameter is not doing anything useful anymore except for printing > a warning, so it's now time to finally get rid of this option. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > qemu-doc.texi | 7 ------- > vl.c | 3 --- > 2 files changed, 10 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel
On Mon, Feb 19, 2018 at 09:23:40PM +0100, Thomas Huth wrote: > It's been marked as deprecated since a very long time already, and > the parameter is not doing anything useful anymore except for printing > a warning, so it's now time to finally get rid of this option. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > qemu-doc.texi | 7 ------- > vl.c | 3 --- > 2 files changed, 10 deletions(-) Nice catch. Reviewed-by: Kashyap Chamarthy <kchamart@redhat.com> [...]
On 19/02/2018 21:23, Thomas Huth wrote: > It's been marked as deprecated since a very long time already, and > the parameter is not doing anything useful anymore except for printing > a warning, so it's now time to finally get rid of this option. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > qemu-doc.texi | 7 ------- > vl.c | 3 --- > 2 files changed, 10 deletions(-) > > diff --git a/qemu-doc.texi b/qemu-doc.texi > index 56388b5..eac8e8b 100644 > --- a/qemu-doc.texi > +++ b/qemu-doc.texi > @@ -2606,13 +2606,6 @@ which is the default. > > @section System emulator command line arguments > > -@subsection -tdf (since 1.3.0) > - > -The ``-tdf'' argument is ignored. The behaviour implemented > -by this argument is now the default when using the KVM PIT, > -but can be requested explicitly using > -``-global kvm-pit.lost_tick_policy=slew''. > - > @subsection -no-kvm-pit-reinjection (since 1.3.0) > > The ``-no-kvm-pit-reinjection'' argument is now a > diff --git a/vl.c b/vl.c > index 81724f5..3956e53 100644 > --- a/vl.c > +++ b/vl.c > @@ -3849,9 +3849,6 @@ int main(int argc, char **argv, char **envp) > exit(1); > } > break; > - case QEMU_OPTION_tdf: > - warn_report("ignoring deprecated option"); > - break; > case QEMU_OPTION_name: > opts = qemu_opts_parse_noisily(qemu_find_opts("name"), > optarg, true); > Good one! Queued, thanks. Paolo
diff --git a/qemu-doc.texi b/qemu-doc.texi index 56388b5..eac8e8b 100644 --- a/qemu-doc.texi +++ b/qemu-doc.texi @@ -2606,13 +2606,6 @@ which is the default. @section System emulator command line arguments -@subsection -tdf (since 1.3.0) - -The ``-tdf'' argument is ignored. The behaviour implemented -by this argument is now the default when using the KVM PIT, -but can be requested explicitly using -``-global kvm-pit.lost_tick_policy=slew''. - @subsection -no-kvm-pit-reinjection (since 1.3.0) The ``-no-kvm-pit-reinjection'' argument is now a diff --git a/vl.c b/vl.c index 81724f5..3956e53 100644 --- a/vl.c +++ b/vl.c @@ -3849,9 +3849,6 @@ int main(int argc, char **argv, char **envp) exit(1); } break; - case QEMU_OPTION_tdf: - warn_report("ignoring deprecated option"); - break; case QEMU_OPTION_name: opts = qemu_opts_parse_noisily(qemu_find_opts("name"), optarg, true);
It's been marked as deprecated since a very long time already, and the parameter is not doing anything useful anymore except for printing a warning, so it's now time to finally get rid of this option. Signed-off-by: Thomas Huth <thuth@redhat.com> --- qemu-doc.texi | 7 ------- vl.c | 3 --- 2 files changed, 10 deletions(-)