From patchwork Mon Feb 26 17:13:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Denis V. Lunev\" via" X-Patchwork-Id: 10242865 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 40330602A0 for ; Mon, 26 Feb 2018 17:19:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 363B22A1F7 for ; Mon, 26 Feb 2018 17:19:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 298522A1FA; Mon, 26 Feb 2018 17:19:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A5D1F2A1F7 for ; Mon, 26 Feb 2018 17:19:44 +0000 (UTC) Received: from localhost ([::1]:60483 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMRD-0003AY-Sy for patchwork-qemu-devel@patchwork.kernel.org; Mon, 26 Feb 2018 12:19:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMLt-0007JU-IM for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqMLp-0004e8-Dv for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:13 -0500 Received: from mail-sn1nam02on0132.outbound.protection.outlook.com ([104.47.36.132]:37730 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqMLp-0004dW-6J for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=33eXzQTGVm3PuEDP//xdzul1groXbdvW/sDwN9hm9aE=; b=M5CrMYrDz3gcAchowIPgvHMpbuyNB3uYKwtkkTe3cFZTz1aJusjAIdGgOOFQFBDVmAyGZbMoLZ/b7n12y1jHd89k8IpSGMAbuDFNfuE9GrYUvZBGeoDVGlzhiv7+QRuOctoEN2MgTRcHufO1ITzEO9N0zoK21+g6YDGSQ5+hkc4= Received: from DESKTOP-CS4P60I.corp.microsoft.com (2001:4898:80e8:9::75b) by CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.2; Mon, 26 Feb 2018 17:14:07 +0000 To: qemu-devel@nongnu.org Date: Mon, 26 Feb 2018 09:13:31 -0800 Message-Id: <1519665216-1078-4-git-send-email-juterry@microsoft.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519665216-1078-1-git-send-email-juterry@microsoft.com> References: <1519665216-1078-1-git-send-email-juterry@microsoft.com> MIME-Version: 1.0 X-Originating-IP: [2001:4898:80e8:9::75b] X-ClientProxiedBy: DM5PR1401CA0003.namprd14.prod.outlook.com (2603:10b6:4:4a::13) To CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: e72e97b5-15ac-4a3d-c691-08d57d3c5847 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7193020); SRVR:CY4PR21MB0168; X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 3:JJbPiQ/l3Mv7lal3d8j61wUg7tcxpEigA1VE65KD2UJDkD3HCEmpDy+OV7FnN9xwJ2RmKV6lazYXWLy71NUyBN/wcAHCvHkUY9MivuOhOPI1UUdwmuUvJsavCOeYur26559B/Rz8lX4ep0nx4w61A9QisVid1Mu6Yvb8/gBGz7gGi5O7V6R6eROTXIlyIQK9OL9GVMA0Gsmgut0moM1R9Cjm65sLTy6nZLB3KlfWceLLXD0ifIVtqaAqWNPqWfEx; 25:Zfa0AxHkhefHMeMukkbnbokyAQchzNqlDohBmsby1Wn87xDCK0t7fSuUkaRLesA3WRMFmsEP0dlIJonYmRj0b+2lfLiWSdp2jE6c9kapWWcPS+8nUZX6yUmHqpa78OzYCTYC+QqSVjlgzcjozsyUqpWzZelxmUODB27PPPdQ5FRQlNP822ddSAI4SDaInelO1AfiqwnSfQTPk9w02S5+wjBdkPxXG9Bnp0q0dGFDYgaWGor0CK+5E9MQIqDyHubrSdHt14nC4zPhXuLFDxStsKqmC3N2vjRBLzE1Cd6QnmQcaX7cfsNhYUHxYphCTe7fa7UrrPk3woxph3ix6Mu2Qw==; 31:V8FExPsa9yiVlrOphx1PmJdCIVsDvEGOewjV0d1sNjnhsxqECDPZTNl80/nIeuzWv62+MD7RuL+rGa/ILfUXrSbHL1lpVWOMfPZopho0yifKUYtML9//E4rjJkTuDLslxfjRWzEccfz7HZYUpo61SRQwaCCQsYMlgbnZwH4TJAb3hZolzTi3ICfeIy7PkTqZwICBZ6xMDacKB69+lgz53VWb9EcvxiQmFif2tSD5yBA= X-MS-TrafficTypeDiagnostic: CY4PR21MB0168: X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 20:mmcZ1yuc2MDb0hCp+dTpUWfs3bQ5K3Zs/ae0H68rhEYRgl06zb3MAgJPH+R6oo3QyFeLfUTpM59DK2gEGXSlbuEfGLD6+R6HyeyOwttRMW7h0htqIpMPNRCI3+2ABI7ZqzOi+7Uk7A9IlAy+aoPTo83i16ZCf69i6zaR3fOtfl1eFKReN9dLxi8C9kLvWMM8Dl36wqA/KC1CkMozL/3EkQq6sAizBh/H5Yka/L0yMwq5V/8BH7v9ecHa1537PxBQlz8oJEhdpuWcieouLLYKk/o4L2Db/zNr6hKm1bOjuMa27HDMzanN1WGomaxaVIl2vz9fwkuJQI1ziJ0ngKA+mpSKLdwGPGPAIUJsCZM1Y3f8aZgkFpEMKTZOnb3KOpXahI8z1yGdIUld4iYMPMXgLogcjlnBCXVws4QatTqbG8anfx1xj8WXVD8Cg4aJKmuFEOWSndmem5vhwobBU5KVEV40Mdjgr2dV0NsRy5XBD16kFRSptnbcouXIFAQS0sSu; 4:y2kkgB17dyI6E07e3vm0CDbA1GfciNlFRH7cESgwBvx5RzEP2+zEnfbouvMvInANFw6hgGH5/DHC7XP8Pstyw/5UoBwmnWWJIx5Q4lol1k8qVv6dgHi2v3+pjh3lGqqRwRrjlMszlLTvcN7lSpk/0MQ26U0Sqj74yo/SBNDFQTCZVpSLbgR9SsCKcoXh4XdEm6RhEkElxOQpembVK6jFsM40G6nssZdMiZSs1mUoFM0Am6bgwpH3eePwPMpQG1Bi+Z7A4EJi2TG5EyBJRYSULdQxZg8UnM/ojFtqKF1c1H2YSErwG+pDZIYq+E2LcDd9a1AHSXvCRFCTK5XbeyPemug4cwOXsSRgmsn7WfXWyeQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(28532068793085)(89211679590171); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231220)(944501187)(52105095)(3002001)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:CY4PR21MB0168; BCL:0; PCL:0; RULEID:; SRVR:CY4PR21MB0168; X-Forefront-PRVS: 05954A7C45 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(979002)(376002)(396003)(39860400002)(366004)(346002)(39380400002)(189003)(199004)(5660300001)(36756003)(53936002)(10290500003)(7736002)(6116002)(105586002)(478600001)(6666003)(8936002)(8676002)(81166006)(47776003)(2950100002)(81156014)(50226002)(10090500001)(6916009)(106356001)(2906002)(52396003)(50466002)(51416003)(6486002)(48376002)(52116002)(7696005)(97736004)(76176011)(68736007)(86612001)(6346003)(107886003)(386003)(25786009)(86362001)(22452003)(2351001)(2361001)(316002)(305945005)(16526019)(59450400001)(4326008)(186003)(16586007)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR21MB0168; H:DESKTOP-CS4P60I.corp.microsoft.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=juterry@microsoft.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR21MB0168; 23:FzHE5jGhzsB6R4vTcDbZ/3uxuOXMOeTUNYu16DFIU?= =?us-ascii?Q?ta5B1Tz9a/h52DiV67TPjkA174xuDa+L0XJLOZ+Ua60hevqYpjPRDc8OtFoL?= =?us-ascii?Q?rXY/4OXAczD2+fvTfwq+aKj8v+xiQHXhvDn4Jd0eLjkYhqQT02bQ9Vcpe5Hw?= =?us-ascii?Q?OV+GqvjvqMBRmORSacRDJUCeERmG4/3mYKrdNUnPh4VK0SBXKpKmpwrEwqCq?= =?us-ascii?Q?RTr8CXEBSsQKGpywSx3DSNEtSLBz9++7fTpJ8zS1D7QgYUPLbPAmSJnLNtVT?= =?us-ascii?Q?/YjnK5AUZIrjUgQw+0GCeEUVqpdUrniFT8VGXesnshY3VZx39ml8BO5r7IYo?= =?us-ascii?Q?MZzxCSehVG2yjC05RcDtuWR8o0D3ieI74YdSSNhM5qRCbYxQK/AgbvbsPJSb?= =?us-ascii?Q?lDsWACXlAOAffxaCxnMUU8dPpo9ArX9q/38ACgSYsoXqbHlfNxjOLf4RiZPj?= =?us-ascii?Q?7bvI4u+6Yv6iPuxNWVdPjtBeSqAo1wNlGNS8ps6DkMMLjqCNrfkNEE15Qsz/?= =?us-ascii?Q?piADjJGqyaB95mxftD0M8DXEiG7AJm94r9dDrlVkWQCWM5AUYWJ8TmozzCny?= =?us-ascii?Q?OjDbFIA2IXYUMfOoF5VCAXe5StMY0uZkWL3eB/WBqEipWN/j4e1FZlQ9xw9a?= =?us-ascii?Q?0+S+mzuUMcDlcEG/bUCZT9pjK7Z9Od+rDlFlzPPO3w7bxOj7MyiRmeOdZjvF?= =?us-ascii?Q?UgXC3NNQXhkapbzYwU/8ef7I2ir9nQCPD9j169A5fkbSmvhy+sL8ZU1Ert59?= =?us-ascii?Q?jF+vPEM9qj//tWdu4EYQZOh+BfLQ8b5BJDUnga7GrMyIlvYRSaJqcdLXkbsU?= =?us-ascii?Q?lCAz0iGLHTI0ysE6uZd/02EaoVO/3GXbdPdFAJqSEHqnkoGITePNI6NGBjnN?= =?us-ascii?Q?iTIkLChrLvfP37awnubOWiROFmrqa/12duwKxk+JfsdZzSJlIKPC6r5CNNIw?= =?us-ascii?Q?ld9bXuyhRl6A5cMUgga2t8XqyGQohg2iLzvrkXv4zfn8T5NlhnUY1GbX7BdO?= =?us-ascii?Q?hEfuwW7HFTdi5lRAGfNRmlF51zbWZKhlJAL1/jooCGs49FMi1jT7esDoHSK0?= =?us-ascii?Q?5fUIpeAoT1hXSAG7kNqPet+n5pA+Cz/x/1TNLw6OQbvmn8NTj8eejb5G798n?= =?us-ascii?Q?zgb0Q6/kQ3BwEmC6Qvczk85nskyQQflnkqPSeenvRwzhKsICnZ9myFRS5r/Z?= =?us-ascii?Q?CG6yDCSO4RQ5bcqCsdYaxrA8Wr1eDwhHajhOYRY/tLJPGTpUl4ym4M1INbRH?= =?us-ascii?Q?3zBFhwzx3tWCEtuOW2IXPVXL5iMa2eZXzEM+FYISjuhCxtQ1NOteR0OcUFU/?= =?us-ascii?Q?GJ+SUm3L0EwDxYLa31IyRsMkElNkfXExZ4JUS/CqJNzNN0CEmq5qSm8mN7dd?= =?us-ascii?Q?0zY0A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 6:hfd/a9glVvCowTVbBpOvsaPIOJjTlLDf2MZBIXkYAgGq93/Um0Sx8bSZfg1OCPW0qlPOGaWONsEa+iqb1u9AcIqRPoGFC7Pd9E92t10m2w9eFrK3am3nutWFVpoIhXc1y0BzUDLk8aW0/S3TYlK2gtJtVOwrsLXiSBw4nN6ltUa1n/GCatOwEBk4azBxnPxcZ7hwVPlv1LM8D3KRYcJMUtkgGWlJxDnpc3VVYXbrrdUFVH2wsG05pQPxG8ImwuBEfuSfIHuiH5TGIZgvGtNoaIrQIfiKU8tRLp5qKnTXAQomoZ5o2u+4cqsoCFPM3f/9K+v/cDhRNW82slGWAHv7Rp9o09SHgsNd61q8y/lJbKY=; 5:copzsU7qRhQUPup+Gx/N1cns0eiLJvu7jUx970WKjC78Me5+6Q9nv46BH6+KvKFalArY3jWOZa90A1YRwY6bXhE02shjsZ5L6wsfAEPBpSfIaaxpSTwkyoGTs1m+c/sZBf/8sMNPZpLaMFS9YUjxzlV6XUrwfqq9FQTv0cjXUkg=; 24:LumRk8+cygsx8vBaIKTTD9EWjvyYspehcT1RVW9k8m1MMT6dTyyIHu9/aqBVo7VvCZwxikZfb1ls806OoVnRUfSEW+GzJcBLcaIUfAfJ6CE=; 7:i1Vbpm1pWepb/R3ro1kgn849q8YMsAOObDOwUbesQneE6XnfhiMtohmxssDWxV0vGO4dOR2DaPWtokRDv8YG5vbDrwkY9qjuOgSKWMA2MjSYeCg403eTo+7PIw2PSFAHJNM3K7VSdCmbE2UjsO2+5H4LJcDnhmCXOUoXWCNAMH+FUU4g50+OiViUZC7V6DiW3nKBnl0jzSlJ+je4LhEvOH8SJi6SjKBgzalmANWn+SiTUBWGnQmvjn8WQlKT51eh SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2018 17:14:07.0337 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e72e97b5-15ac-4a3d-c691-08d57d3c5847 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0168 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.36.132 Subject: [Qemu-devel] [PATCH 3/8] Remove unnecessary WHPX __debugbreak(); X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Justin Terry \(VM\) via Qemu-devel" From: "Denis V. Lunev\" via" Reply-To: "Justin Terry \(VM\)" Cc: pbonzini@redhat.com, "Justin Terry \(VM\)" , ehabkost@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Minor code cleanup. The calls to __debugbreak() are not required and should no longer be used to prevent unnecessary breaks. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 969c2f5f93..14ea732ec6 100644 --- a/target/i386/whpx-all.c +++ b/target/i386/whpx-all.c @@ -364,7 +364,6 @@ static void whpx_set_registers(CPUState *cpu) if (FAILED(hr)) { error_report("WHPX: Failed to set virtual processor context, hr=%08lx", hr); - __debugbreak(); } return; @@ -391,7 +390,6 @@ static void whpx_get_registers(CPUState *cpu) if (FAILED(hr)) { error_report("WHPX: Failed to get virtual processor context, hr=%08lx", hr); - __debugbreak(); } /* Indexes for first 16 registers match between HV and QEMU definitions */ @@ -554,7 +552,6 @@ static HRESULT CALLBACK whpx_emu_getreg_callback( if (FAILED(hr)) { error_report("WHPX: Failed to get virtual processor registers," " hr=%08lx", hr); - __debugbreak(); } return hr; @@ -576,7 +573,6 @@ static HRESULT CALLBACK whpx_emu_setreg_callback( if (FAILED(hr)) { error_report("WHPX: Failed to set virtual processor registers," " hr=%08lx", hr); - __debugbreak(); } /* @@ -604,7 +600,6 @@ static HRESULT CALLBACK whpx_emu_translate_callback( Gva, TranslateFlags, &res, Gpa); if (FAILED(hr)) { error_report("WHPX: Failed to translate GVA, hr=%08lx", hr); - __debugbreak(); } else { *TranslationResult = res.ResultCode; } @@ -631,13 +626,11 @@ static int whpx_handle_mmio(CPUState *cpu, WHV_MEMORY_ACCESS_CONTEXT *ctx) &vcpu->exit_ctx.VpContext, ctx, &emu_status); if (FAILED(hr)) { - __debugbreak(); error_report("WHPX: Failed to parse MMIO access, hr=%08lx", hr); return -1; } if (!emu_status.EmulationSuccessful) { - __debugbreak(); error_report("WHPX: Failed to emulate MMIO access"); return -1; } @@ -656,13 +649,11 @@ static int whpx_handle_portio(CPUState *cpu, &vcpu->exit_ctx.VpContext, ctx, &emu_status); if (FAILED(hr)) { - __debugbreak(); error_report("WHPX: Failed to parse PortIO access, hr=%08lx", hr); return -1; } if (!emu_status.EmulationSuccessful) { - __debugbreak(); error_report("WHPX: Failed to emulate PortMMIO access"); return -1; } @@ -716,7 +707,6 @@ static void whpx_vcpu_pre_run(CPUState *cpu) if (cpu->interrupt_request & CPU_INTERRUPT_SMI) { qemu_mutex_lock_iothread(); cpu->interrupt_request &= ~CPU_INTERRUPT_SMI; - __debugbreak(); qemu_mutex_unlock_iothread(); } } @@ -785,7 +775,6 @@ static void whpx_vcpu_pre_run(CPUState *cpu) if (FAILED(hr)) { error_report("WHPX: Failed to set interrupt state registers," " hr=%08lx", hr); - __debugbreak(); } } @@ -812,7 +801,6 @@ static void whpx_vcpu_post_run(CPUState *cpu) if (FAILED(hr)) { error_report("WHPX: Failed to get interrupt state regusters," " hr=%08lx", hr); - __debugbreak(); vcpu->interruptable = false; return; }