From patchwork Mon Feb 26 17:13:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhijian Li (Fujitsu)\" via" X-Patchwork-Id: 10242867 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3713E602A0 for ; Mon, 26 Feb 2018 17:19:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2CF202A1F7 for ; Mon, 26 Feb 2018 17:19:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1FECB2A1FA; Mon, 26 Feb 2018 17:19:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9F3872A1F7 for ; Mon, 26 Feb 2018 17:19:50 +0000 (UTC) Received: from localhost ([::1]:60484 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMRJ-0003Dn-Pz for patchwork-qemu-devel@patchwork.kernel.org; Mon, 26 Feb 2018 12:19:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqMLu-0007KA-Fs for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqMLq-0004eT-CQ for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:14 -0500 Received: from mail-sn1nam02on0130.outbound.protection.outlook.com ([104.47.36.130]:17056 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqMLq-0004eC-3k for qemu-devel@nongnu.org; Mon, 26 Feb 2018 12:14:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DsCgoygGgfK23OIa9+p4DAYItMpPzd8tQjgSYuhAKEE=; b=KU8W18Yn3DXfPRTlGSSoaTNiQNaWsDzSZBr6lP+56a8/oXQMyP07J52LXl04dUxxouIAkiKa0VaopXIIvn3Hv2ShY2yOn0mU8zYMVA+djXwM6BNIZS0loNac2nl6SMmqnDEmjZjFFmtkBTomryKaWzXKAr0BZksuBVs/MdjP1U4= Received: from DESKTOP-CS4P60I.corp.microsoft.com (2001:4898:80e8:9::75b) by CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.2; Mon, 26 Feb 2018 17:14:07 +0000 To: qemu-devel@nongnu.org Date: Mon, 26 Feb 2018 09:13:32 -0800 Message-Id: <1519665216-1078-5-git-send-email-juterry@microsoft.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519665216-1078-1-git-send-email-juterry@microsoft.com> References: <1519665216-1078-1-git-send-email-juterry@microsoft.com> MIME-Version: 1.0 X-Originating-IP: [2001:4898:80e8:9::75b] X-ClientProxiedBy: DM5PR1401CA0003.namprd14.prod.outlook.com (2603:10b6:4:4a::13) To CY4PR21MB0168.namprd21.prod.outlook.com (2603:10b6:903:b9::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 15d73a46-97df-4e66-4cee-08d57d3c58c5 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7193020); SRVR:CY4PR21MB0168; X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 3:tYbct4Bp+trdanKtM/99r3+t/NaNHrP0Uh3XHEJnmpLP2Jrqu7jOVAvN8Et4d8//RCi5SvIpgiAGkJDBMHWcXs7UmhSHN7JUhsgqc7WKlmfo+fceIf3HRxkd1orlbTwhr9Qp/psW+TbiiFonPtsB8eLGRmBjVTKuIeFkgKJOcdnFb1Wjy9OvHGfZ6pxFVrHuntcUruEn8MmrXY3ni1j4NA7waeuRwE97Yc9JnBqZRcUQSUfJY9RVvIMHcLgF2LT+; 25:4ju7tJnOARMPs5fRcxjORd6l2xVB/fo34L1oJG0+Vh0kJLXdsI8Df2e0/2fBsikIQUXcezu0VdbeeHI/GuqHRURrgdeqvxLEiouu/Lag0n3zm64nhcZHEPHm1AKl86ntNkOs/RlkYQZEJpw5LIWffa3T+0S5Xz9MEhxurw674pNL9nJd8MbRXc/uLG9h4Lf2ciT40xslfnry3TvvYcUhSwmwpOR9fKK5is5v46JkPxJUzaxZ8dCyRhmzFUrs35SMUU4nkOD6jeUULcMjRbJgwsPwJeXkAyQ7ZQECbS8o0Usof3SvXjtF2Y0ZJ/Ox6/5GJ3O1i/Uza+mk6MBNb3ddmQ==; 31:RmjFAFUDojkoP4xgx/+5hVMHjuYZVm2fgdhzF27KCP/xmeMBAXreytCbg7JwQoV4KoY8+6MtLjFVSecEY/D9Q+LvAFygquvXS2/ZqkFeDz6szVaJj0tlynmfN9KqOUhG4GPUKvgWizR1gu1ZbvB7lePoDRAjhLU8vPp5kpcGhuiT3cugr7Ex0KCRETGYar7LSRyfRIq9+MNDFv8FV0Au1TVaBqzgtAbWjH+a+8sT6oo= X-MS-TrafficTypeDiagnostic: CY4PR21MB0168: X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 20:EMxORV2gJXwJnvIjDIusF/t4dVyXHZmTAN8j3x5Z99WZbz6z0/s61VPrv6yXODOddOERPvMqbke4G3HdnthcbBO6XkyfUL0SVeUczDU95IndpAmfLvVFgXbCCBmK47VE5ngcWkGfE8Cjsxh0U17zGyjHu0akiraWlkUorcY28qNg9wbvG8l0KIsnOVsWU1jyOkWOkAjhrze7AtfMZCyvazOVZmxRiEBTm/TQ1eCtgDh4L25yb6NA3yyAuWK+XU2lrCl3NN3wK6OSNlmtbdaVKR6osYV14IPUEk6/WhrMffkEyQZKOvA9yEQXZ/C2H0rkl/D6t5P6ZWXvKNmlyqdDXsYyYNTd8z4LpZXWqHGrXUSN7trZ/aTfTNJ/ojOFrrkaYYuCQ5117/OcZub51Nk/2KodEwujoaDRHNyoVnUtaI9aUfjjTLV6j0wGylY4pZ1UmtLDLDxDCfp/BuV53JT+9pAb3fUp11oxamE30eQtxIYggDy4au4UeJZDsSHyWaV6; 4:uklKyXkNAfuy/kUwL+5ssCMPWfkm4zV9VrBoZvl2+Pf6mfW0dJhQ75zP1kQGe6qn+ViA/Pzt6YGGJeQ2W3zVE1zNu0V2Ne3kvfP7W+e0JX8B7KG7Ro4uiK+Cq7AiUKMvB6F3tye1+slVRUtSgtryyeG1+2WukHw+LIDYIhsziY6utWIWZO6Zj6Bs/f/YeVm+Zch/c0Bcrw4fXt2xOmwEHeh7dTY8L/ew4WvhrEXv29+6mX1eTmnr1ncIc5M5Y381nktwFg5xY29tOSLb71SLjRPG5GtV3ljqX40y39+Nfku27fVWMsJAimhRnschAt7LsG+NHzfyv3CmEtVzptz138CGX49iUqze/w493SyJJ+8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(28532068793085)(89211679590171); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231220)(944501187)(52105095)(3002001)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:CY4PR21MB0168; BCL:0; PCL:0; RULEID:; SRVR:CY4PR21MB0168; X-Forefront-PRVS: 05954A7C45 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(376002)(396003)(39860400002)(366004)(346002)(39380400002)(189003)(199004)(5660300001)(36756003)(53936002)(10290500003)(7736002)(6116002)(105586002)(478600001)(6666003)(8936002)(8676002)(81166006)(47776003)(2950100002)(81156014)(50226002)(10090500001)(6916009)(106356001)(2906002)(52396003)(50466002)(51416003)(6486002)(48376002)(52116002)(7696005)(97736004)(76176011)(68736007)(86612001)(6346003)(107886003)(386003)(25786009)(86362001)(22452003)(2351001)(2361001)(316002)(305945005)(16526019)(59450400001)(4326008)(186003)(16586007); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR21MB0168; H:DESKTOP-CS4P60I.corp.microsoft.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=juterry@microsoft.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR21MB0168; 23:aLA2mefr4Sqo4HcjvxEE+BPzXiPrRCGrC/+aDhtoq?= =?us-ascii?Q?iWD+qhH0bPU93ecUwPiy0ghAJG9S0zmIdySS8jVH9YfKWVwYOMLkHdFXUhpB?= =?us-ascii?Q?lbhbh6BoJ33nZEqg5bFN+nkpKIAzrn6eV4FQE0dTnZn8NrrPlcd6BDWSLED+?= =?us-ascii?Q?WmHBpRhKE+hvCJl3pV2MwlzX1D/LCT36QTHWQvLuLnMSka4NPVPuicmNOXEd?= =?us-ascii?Q?sCQxvgpUbdVVozYbN5b5Q6kBKH9WcntVkjo5frq0++tJrTGZACwxx41ENLME?= =?us-ascii?Q?hLr7ByH4w/Gkm+rt2atCymrj25GV8Zkyh1xp/InlNC5L8YBflb4ICyUs2tur?= =?us-ascii?Q?DN/yAfZkrIxF9ztJkTqEsYI5g0RJ4n5/HatDTzic7Swwd/omOpTeLDYAQI2w?= =?us-ascii?Q?gIsxzkJQlLyUqATDOvcBWynMpAKI//VVn8w4S7Ab1hxqHDD6XOj5juGqKeQb?= =?us-ascii?Q?SqxNDBOJM9Bn5xNVBq4x74zj6J+P/0bEhe2ZHFGUumT99MDfQMu5Mx/X8v/W?= =?us-ascii?Q?7HiQJ37DYIqTXQUSOksM2QjGwEujkFyHv42yyQnebJ19VAsz8tKHR7C3Pyo4?= =?us-ascii?Q?ZkElD4C0QadPS+qD4DEaxhz/eolXftprK7gSDAteG4te+0EoXn4OmMdLjX/H?= =?us-ascii?Q?N9PRLjEiZwxEm9IcMCPlQa1S8NwydNq2dGHiRIMfOsUTZEWgCIWmMh1LHUXv?= =?us-ascii?Q?4rLiDV5Oyu0/rBIoDHvd6crA4+7Ub82iZp5bUicud9emiECqCR0+ZSA0B46Z?= =?us-ascii?Q?mbdzoBadQUYSC2Le8Z2LZjNkEM9Rxuo9tLq7cPOln+ch3rngKN9/kgUNu12f?= =?us-ascii?Q?8praNtJBYa9bjLHtV6c8Egv9MlzMNSSGofBwgYaLdfcH03Psz0hehg8LfB0C?= =?us-ascii?Q?HPXkAK4zNNtGqWOgiFjrfZMwr+FKm3bpqf3MF5E3eyns3/ym6tGXaR4nFrIS?= =?us-ascii?Q?n8TdFRp8wITmDneZvRiqLQq8s66ho3ZRyzJV+g1ithz/NAfkMLVf+MsjwoX/?= =?us-ascii?Q?x0teKG7hNoGbD1wwmpnawZasLxmESnPV/+0/LrpPThBM7GxyBkVnFOVEmMvk?= =?us-ascii?Q?axK62pnXzoZ8yLB7H23FxCNPmOcIgAOEmD/46bI19zecOk9/vPOaf4hn7p/T?= =?us-ascii?Q?MU1qwjBQLpevMZEETsqy+elf19hlAFdvrEC+qhyL5mEy+SsmR2en1OT+9lzK?= =?us-ascii?Q?RJA1ruRFEn6dd/SKY6BJ5SFJwNtraopuqqJ71H0BNKEBQ8ivb7TJM8eETVH7?= =?us-ascii?Q?JkBhoDU9T2+8xwCqZ8=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR21MB0168; 6:XKke00nk8+5heNCgtEkLh05VgysBL0Gks+zsSYyzGROQNQMkV5cVyyxYAC6aLWx+3up8vUqUmx6MEhy5Ufa2hCfmzUOlw5LnT4+H85Npq6WzavKRFVHwpEtMa23JkgbrIt5oJgUyjqD4r0ZuA7V7v4TQTXPJvVl9eX9Bt2IagvwhHTjbCVv9SbINT7tZC2SdZBjLUUepQFunsxlyfILl+WHo1uR6zR45zgn9QJzagrH/ZSImvMFxOfsg9GLM9pgi6QDjsM9+32WQ/E4F8Pe98pt9oil5XSFGEUPXCRspuTyIBdN9QNjHf/a/5R13ea8XYym68HU7yC0M49QTNvZ5w9zA8jZeJeBVMI+wJZbkcmU=; 5:sP2/k6ZQTo6hL5E4t8Lbu+b8H3X7nUdo0dUBCg8sE+N1GDHUWaV7oEzw5Z7rhi81Efn2xHMDlP/ROQWwL8tYUwkv2cYHqCW1TtCCCnyXfZlZVKhXkF/jygeRlJGJ8ptd/6IRpRpYZQCapx+S/NeOtLoAfV0epVhNIwp5w9YiLP8=; 24:iPcGZ5HQlRNT4T9SmsdzXBBZaCkM8rf6FhArYxbTJZzZPfNuqckjuHA98GJ8q4IIhv//S+OjRipaaRPFmfZH0TfzqPCqRylrY4aJI5oSSYs=; 7:soYSwSTV9vi34YMIHYD32Fd5MTlwQMpf3IOYO9vG/Njh/weHQ35ZK8Xnes4gO9n92s4+KFs3MDln/X1/ooHv4+cv/VzqsN5scwu7YELWTIRV6XykS8lABTozo+sghqw17rexEgGPEhdUS8nAb0GpHQRnrPmE+rMySJahZr/eVqgG5C/OMJcCNVWC3hZavCTii8H+j/D1D+uA0SNaKyYCKjcu3tyB0ZUzq/OKpnmPsFxYoAmC2MOo/cvbV/gZ6SWY SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2018 17:14:07.8574 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 15d73a46-97df-4e66-4cee-08d57d3c58c5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0168 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.36.130 Subject: [Qemu-devel] [PATCH 4/8] Fix WHPX additional lock acquisition X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Justin Terry \(VM\) via Qemu-devel" From: "Zhijian Li (Fujitsu)\" via" Reply-To: "Justin Terry \(VM\)" Cc: pbonzini@redhat.com, "Justin Terry \(VM\)" , ehabkost@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP The code already is holding the qemu_mutex for the IO thread. We do not need to additionally take the lock again in this case. Signed-off-by: Justin Terry (VM) --- target/i386/whpx-all.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 14ea732ec6..74a8f4d599 100644 --- a/target/i386/whpx-all.c +++ b/target/i386/whpx-all.c @@ -705,9 +705,7 @@ static void whpx_vcpu_pre_run(CPUState *cpu) new_int.InterruptionVector = 2; } if (cpu->interrupt_request & CPU_INTERRUPT_SMI) { - qemu_mutex_lock_iothread(); cpu->interrupt_request &= ~CPU_INTERRUPT_SMI; - qemu_mutex_unlock_iothread(); } }