From patchwork Tue Mar 6 13:19:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 10261693 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1B7D0602C8 for ; Tue, 6 Mar 2018 13:34:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EF5F528EF1 for ; Tue, 6 Mar 2018 13:34:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E1DA028F8E; Tue, 6 Mar 2018 13:34:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0585928EF1 for ; Tue, 6 Mar 2018 13:34:56 +0000 (UTC) Received: from localhost ([::1]:55780 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCk2-00039B-Mn for patchwork-qemu-devel@patchwork.kernel.org; Tue, 06 Mar 2018 08:34:54 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCVR-0004qF-Cf for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:19:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etCVO-0006Gp-WB for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:19:49 -0500 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:40136) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1etCVO-0006GG-Pp for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:19:46 -0500 Received: by mail-wm0-x241.google.com with SMTP id t6so22233856wmt.5 for ; Tue, 06 Mar 2018 05:19:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ExnxpKndTsPSZ9cB3srpn658cSG5Kyd5DBF0UQm4lKI=; b=aEBpJFG9pi7ntb97OiNAnCI1MfOPj+lEEG7g2P1Q4ncJQzEMzEcQV4TZn4mG9rt4eb v4T/Hr4BjtRKW4qdCej6PTmUZuwSpPyAssfV6Ym6KVKXG5L2qIIeZL60XlIuciCYYf2D rk7ize47z9GEuhdeLm6VLBts6Kp2CugeTtQxcs9etrZLDr50/009Tw9jpxb7r91zTDYu S9ZWMKWQz7ixwpNbmpwrJUSvGfaxw9yodFf+cozX6VSlwxUT2gYjfunt7GFhjaeMZHvh ghxxhJzxQM8IRpBQzK4AX1+ZpZY89gIupG5qOk7yp3dGKfC21BvVJVoPyRvaAH2XpJ6P fxIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ExnxpKndTsPSZ9cB3srpn658cSG5Kyd5DBF0UQm4lKI=; b=kOj17BsolJxL5TGhcS8f6s1JOi0eRWB+Pft+hIOJ+YGINyZzg4Q1BMhcT94lvLluWj /eBstL3J4Nu5l3WXkkBYlLapzVHxwevqYYU0qyGV3JKHuEOPlWKOpVK0pPWMAqeGezgD 9kx+NDmgXKhOPu1vAZNVfV6sMXWt98F25ErF/zDJYBIHXDYCvr8Yq3ALDMxfS4xvdcPt zMMBjGwZ6TztYopwmZE1uhFncDNfE0BRpSDySszgjRlilJL6nIGZg4q+s2KJ/hA79p0w oX/aWIIw1Y4i2REacBXRfG2A5Q/gJOrnnjkmLmDYZcN+wkTDFpdIBhqE4FH1gra0yEPw blxA== X-Gm-Message-State: AElRT7HyQqg2qP9xms6Nb8FEOQI5GFhQRDeB+aI3dcuJNlflIvBI9UuL Lji0Hlh+5hqX6OXYuFY1m76erPHP X-Google-Smtp-Source: AG47ELtCNS++ACNJakgsy12azSJQKqXokVy4SUy50wrZkog0/2FUP0pMfARiqHAfSlx0KqUK1t+UmQ== X-Received: by 10.28.34.3 with SMTP id i3mr10540035wmi.121.1520342385436; Tue, 06 Mar 2018 05:19:45 -0800 (PST) Received: from 640k.lan (94-36-191-219.adsl-ull.clienti.tiscali.it. [94.36.191.219]) by smtp.gmail.com with ESMTPSA id l38sm25652538wrc.96.2018.03.06.05.19.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Mar 2018 05:19:44 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 6 Mar 2018 14:19:06 +0100 Message-Id: <1520342370-123606-11-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> References: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::241 Subject: [Qemu-devel] [PULL 10/34] build-sys: fix -fsanitize=address check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Marc-André Lureau Since 218bb57dd79d6843e0592c30a82ea8c1fddc74a5, the -fsanitize=address check fails with: config-temp/qemu-conf.c:3:20: error: integer overflow in expression [-Werror=overflow] return INT32_MIN / -1; Interestingly, UBSAN check doesn't produce a compile time warning. Use a test that doesn't have compile time warnings, and make it specific to UBSAN check. Signed-off-by: Marc-André Lureau Message-Id: <20180215212552.26997-2-marcandre.lureau@redhat.com> Reviewed-by: Emilio G. Cota Signed-off-by: Paolo Bonzini --- configure | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/configure b/configure index 27d3f66..7ff00f8 100755 --- a/configure +++ b/configure @@ -5316,25 +5316,27 @@ fi ########################################## # checks for sanitizers -# we could use a simple skeleton for flags checks, but this also -# detect the static linking issue of ubsan, see also: -# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84285 -cat > $TMPC << EOF -#include -int main(void) { - return INT32_MIN / -1; -} -EOF - have_asan=no have_ubsan=no have_asan_iface_h=no have_asan_iface_fiber=no if test "$sanitizers" = "yes" ; then + write_c_skeleton if compile_prog "$CPU_CFLAGS -Werror -fsanitize=address" ""; then have_asan=yes fi + + # we could use a simple skeleton for flags checks, but this also + # detect the static linking issue of ubsan, see also: + # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84285 + cat > $TMPC << EOF +#include +int main(void) { + void *tmp = malloc(10); + return *(int *)(tmp + 2); +} +EOF if compile_prog "$CPU_CFLAGS -Werror -fsanitize=undefined" ""; then have_ubsan=yes fi