From patchwork Sat May 5 23:35:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Clark X-Patchwork-Id: 10382487 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 58C2B60541 for ; Sat, 5 May 2018 23:47:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4A5F828F60 for ; Sat, 5 May 2018 23:47:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3F3EA28F6B; Sat, 5 May 2018 23:47:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9DEF528F68 for ; Sat, 5 May 2018 23:47:09 +0000 (UTC) Received: from localhost ([::1]:40315 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fF6tQ-0003hS-DZ for patchwork-qemu-devel@patchwork.kernel.org; Sat, 05 May 2018 19:47:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fF6jt-00041o-Ru for qemu-devel@nongnu.org; Sat, 05 May 2018 19:37:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fF6jr-0003hG-BG for qemu-devel@nongnu.org; Sat, 05 May 2018 19:37:17 -0400 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:40012) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fF6jr-0003gT-4N for qemu-devel@nongnu.org; Sat, 05 May 2018 19:37:15 -0400 Received: by mail-pg0-x242.google.com with SMTP id l2-v6so17772190pgc.7 for ; Sat, 05 May 2018 16:37:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hy2H2QS7ngE2pVSRu23At4t1tCIofg9OfH/RuEiYKYM=; b=iISpI9n4dxrHPmYJOVlIQ8k4UO0tmUwTxeFDg3pLlwo/svOMuS65q7SNg3N/ZDrmCB BOLl3mCbyo4wi9GOFiUnfpX8njTcZQMyNddd8BR1/8SkfAg/0YqHFZwFTvjk0Mfv06t5 PoSEswkfYkV26LdvQRIRZfl7xckS8p0twNa3ztWiL3GTSQLSYld5QltG18fn4ul8sms1 g99o090FGxNa8CWWTaKEcqXiArwcn1mIQJ91XVfu2B4hBk/mZvGFsUAsBlnu0yHUBpI+ kIDf32VIwasOViDYqz3HT7KMh4VLuDjE4JydlYhsFevkwi8EqPNJ49mL1SaqfA24uurc eolg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hy2H2QS7ngE2pVSRu23At4t1tCIofg9OfH/RuEiYKYM=; b=agjhax0a71r0MCqsjlr1nV7RDq6f9MRe4rtnwbQ0DcTDXU2RWALZ/qnHFbWtUfYJAc NTv67OomZ0QF87l/J2kRP37kbO7TQB+4hFpMNfTQMwfHUer5TESvKr+w2VAGxATvzkDJ VaPDIha9SZPBm7RmJAUf4Iv0zMj4UjJnxh4CcaZoBb0oEvyKx/ad5nIfyvb7+1NwrpA+ 62b9zW/LH9zx5Ya6208Hfzfsa6ZQFj+znARHsFt2Oo5sgF4TCMm4u/acYh7UDnPKC8bu mCCSd91kmXtqkX5CJ03eI/mQf4/wIL2mfss/nCQOY3iOOKTyDKXZdJH3Q938rnVBQEp3 gMig== X-Gm-Message-State: ALQs6tB3sEj5WoFhr5AfUt2nGF3iybAL3bEaPdzzY77WdOVpLub6iTmQ XSZKb4BngYfAcUST74PQ1/YtcSCcNcQ= X-Google-Smtp-Source: AB8JxZqTY78PQWQP1bbH1cCyMNg904QnFvfouM6uJhingG0IsHupXlldLihgIOLD+z5fAOQF+qAneA== X-Received: by 2002:a17:902:a4:: with SMTP id a33-v6mr9257503pla.346.1525563434247; Sat, 05 May 2018 16:37:14 -0700 (PDT) Received: from localhost.localdomain (122-58-167-38-fibre.bb.spark.co.nz. [122.58.167.38]) by smtp.gmail.com with ESMTPSA id x8sm47297094pfa.173.2018.05.05.16.37.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 05 May 2018 16:37:13 -0700 (PDT) From: Michael Clark To: qemu-devel@nongnu.org Date: Sun, 6 May 2018 11:35:12 +1200 Message-Id: <1525563325-62963-8-git-send-email-mjc@sifive.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1525563325-62963-1-git-send-email-mjc@sifive.com> References: <1525563325-62963-1-git-send-email-mjc@sifive.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::242 Subject: [Qemu-devel] [PULL 07/20] RISC-V: Fix missing break statement in disassembler X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , Bastian Koppelmann , Palmer Dabbelt , Michael Clark , Alistair Francis , patches@groups.riscv.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP This fixes an issue when disassembling rv128 c.sqsp, where the code erroneously fell through to c.swsp. Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: Alistair Francis Cc: Peter Maydell Signed-off-by: Michael Clark Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- disas/riscv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/disas/riscv.c b/disas/riscv.c index 2cecf0d8558d..7fd1019623ee 100644 --- a/disas/riscv.c +++ b/disas/riscv.c @@ -1470,8 +1470,9 @@ static void decode_inst_opcode(rv_decode *dec, rv_isa isa) if (isa == rv128) { op = rv_op_c_sqsp; } else { - op = rv_op_c_fsdsp; break; + op = rv_op_c_fsdsp; } + break; case 6: op = rv_op_c_swsp; break; case 7: if (isa == rv32) {