From patchwork Wed May 9 10:20:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Clark X-Patchwork-Id: 10389065 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 31122602C2 for ; Wed, 9 May 2018 10:25:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2240120243 for ; Wed, 9 May 2018 10:25:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 16E8727FA5; Wed, 9 May 2018 10:25:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 75A9B20243 for ; Wed, 9 May 2018 10:25:18 +0000 (UTC) Received: from localhost ([::1]:55555 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGMHd-0004Q5-Jd for patchwork-qemu-devel@patchwork.kernel.org; Wed, 09 May 2018 06:25:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGMEk-0002LG-KO for qemu-devel@nongnu.org; Wed, 09 May 2018 06:22:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGMEj-0004Eq-Lj for qemu-devel@nongnu.org; Wed, 09 May 2018 06:22:18 -0400 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:46362) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fGMEj-0004D0-GH for qemu-devel@nongnu.org; Wed, 09 May 2018 06:22:17 -0400 Received: by mail-pf0-x242.google.com with SMTP id p12so25387641pff.13 for ; Wed, 09 May 2018 03:22:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LgSDkSAYgyak4/h7FOuUBCmm7VzxdqbJE8EyVPLaDG0=; b=LFvAkRH5nI4rfUrLty2Sske1vpCi5098phLnRj6j4ujiXkh6rMtK2akyw63KY7TdDz ksFHqKSmH3BUdXQtBkv25w7K0hR7gn/5uoYjJqdwhnlQmQ80ZjDTve2SkDrtOpz0Klxd ubkbCTxCsU1M41JP0V6jvqEGfg2EB3ATRAk5dwyHqayUXlSCSuw0+WtzSaA2u5M+yyKC ZfjFKKIYfMP5xf55iD8J8Nfz9qrGct9mJLJ6QSJ5A5Y0Fp4zhiuhpLd8TBllwmV5+wzT s6LTx/bRyfh2OY7GHTRvnA0aWsm5kolFHA9Rtoou76ZuDs2MGwOLbL14P6KmXsf8X8pd UuGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LgSDkSAYgyak4/h7FOuUBCmm7VzxdqbJE8EyVPLaDG0=; b=WjdqlZGkSDqbtku7m/CeN1TM+YG6cmsFlZjY8s49I6ppMV44nU0zuBrnGGbPLejtQS bFKkiZnB7+eDHHANuAoR5xGbNykRmlI72Eb0PMOv8KGfXSZpu5l+HWdE+UTka7hMeQEa HaxK52JI0p+rKhemVLJ2iLLH/ULhFqdd+yNDpdeVOrOwaJjNBd7ot8CwtVpjGeTQir1u 5k/d4Kcj5O6/4sMIlR0dRKzkifEQk62yWs/9BEQXBdYv/o2DHtBQHRl/tDdHYipXu3Zw NHr23qnlVeGCaENMOMp+LrbvAAohaQsjWyQS/kWwT2yT6vBqE8Bv2vuO8V57pDv2cTCL ccpA== X-Gm-Message-State: ALQs6tC2OKLF51NyyKmPuYBtDalJV5HUA8IgvIo0++kmGtgK3eDOk/S9 EYCl86JdkK08CTLBFeMJCxqmet8Ida8= X-Google-Smtp-Source: AB8JxZqTbQn/G+ZinoM55XA0hk+qKPLyzJfwJ46Um2QbJZ+nNuRFHNBWO87Pg/vGqnV21WBCluMFTw== X-Received: by 2002:a63:7e58:: with SMTP id o24-v6mr36378097pgn.325.1525861336503; Wed, 09 May 2018 03:22:16 -0700 (PDT) Received: from localhost.localdomain (122-58-167-38-fibre.bb.spark.co.nz. [122.58.167.38]) by smtp.gmail.com with ESMTPSA id q62sm50086498pfd.172.2018.05.09.03.22.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 09 May 2018 03:22:16 -0700 (PDT) From: Michael Clark To: qemu-devel@nongnu.org Date: Wed, 9 May 2018 22:20:40 +1200 Message-Id: <1525861240-4130-4-git-send-email-mjc@sifive.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1525861240-4130-1-git-send-email-mjc@sifive.com> References: <1525861240-4130-1-git-send-email-mjc@sifive.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::242 Subject: [Qemu-devel] [PULL 3/3] riscv: requires libfdt X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patches@groups.riscv.org, KONRAD Frederic , Michael Clark , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: KONRAD Frederic When compiling on a machine without libfdt installed the configure script should try to get libfdt from the git or should die because otherwise CONFIG_LIBFDT is not set and the build process end in an error in the link phase.. eg: hw/riscv/virt.o: In function `riscv_virt_board_init': qemu/src/hw/riscv/virt.c:317: undefined reference to `qemu_fdt_setprop_cell' qemu/src/hw/riscv/virt.c:319: undefined reference to `qemu_fdt_setprop_cell' qemu/src/hw/riscv/virt.c:345: undefined reference to `qemu_fdt_dumpdtb' collect2: error: ld returned 1 exit status make[1]: *** [qemu-system-riscv64] Error 1 make: *** [subdir-riscv64-softmmu] Error 2 Cc: qemu-stable@nongnu.org Reviewed-by: Bastian Koppelmann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael Clark Signed-off-by: KONRAD Frederic Signed-off-by: Michael Clark Message-Id: <1525360636-18229-4-git-send-email-frederic.konrad@adacore.com> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 1443422e83f1..479e9a787e6e 100755 --- a/configure +++ b/configure @@ -3761,7 +3761,7 @@ fi fdt_required=no for target in $target_list; do case $target in - aarch64*-softmmu|arm*-softmmu|ppc*-softmmu|microblaze*-softmmu|mips64el-softmmu) + aarch64*-softmmu|arm*-softmmu|ppc*-softmmu|microblaze*-softmmu|mips64el-softmmu|riscv*-softmmu) fdt_required=yes ;; esac