From patchwork Thu Aug 9 11:46:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liran Alon X-Patchwork-Id: 10561287 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2C622139A for ; Thu, 9 Aug 2018 11:56:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 181FD2AED5 for ; Thu, 9 Aug 2018 11:56:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0B4C62AEE1; Thu, 9 Aug 2018 11:56:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AF4D52AED5 for ; Thu, 9 Aug 2018 11:56:43 +0000 (UTC) Received: from localhost ([::1]:50056 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnjYY-0003tx-T0 for patchwork-qemu-devel@patchwork.kernel.org; Thu, 09 Aug 2018 07:56:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnjPe-0004wu-Bg for qemu-devel@nongnu.org; Thu, 09 Aug 2018 07:47:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnjPb-0007DG-OO for qemu-devel@nongnu.org; Thu, 09 Aug 2018 07:47:30 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:60760) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fnjPb-0007Cy-CY for qemu-devel@nongnu.org; Thu, 09 Aug 2018 07:47:27 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w79BiRVx138020; Thu, 9 Aug 2018 11:47:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2018-07-02; bh=qzdO2VLgeE++ZuASNXgevLWqYRP3XE+rVWDFSAGobBw=; b=g0Q5LZ61SqB5UFbp6dHvjnR6WJrV+II3QT8UXRNfPSgvBqxYXq6cdcFrg4kcy0lSy95H e73h3eza+KeoUfeH5HunVh+92TQ4fmpGiGPaZClpeKQgDiH7TJVsiCBpjLsTtVpmOMch 25x4DJ9vB0/s6Sx/x5I3GhfYE2udOWp3RatqsjAWAdbxOoanyGk91GkNV+j/LwGAuelT SgWwahTDfPflg+H1YNPSESLTKBW0erK9WF/LkVUonR1BV4F2fsxpx0EHNT5K/vN1fIMK qQ4IeD8IOxxU19294ZuuPCxz/5NkkbUqN1f9Y17tLkBaP65tLR5AkyN2PQIqHVoa4ro1 2A== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2kn4sq2s7u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 09 Aug 2018 11:47:26 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w79BlPhI006491 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 9 Aug 2018 11:47:26 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w79BlPEW019913; Thu, 9 Aug 2018 11:47:25 GMT Received: from liran-pc.ravello.local (/213.57.127.2) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 09 Aug 2018 04:47:25 -0700 From: Liran Alon To: qemu-devel@nongnu.org Date: Thu, 9 Aug 2018 14:46:23 +0300 Message-Id: <1533815202-11967-11-git-send-email-liran.alon@oracle.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1533815202-11967-1-git-send-email-liran.alon@oracle.com> References: <1533815202-11967-1-git-send-email-liran.alon@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8979 signatures=668707 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=998 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808090123 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 156.151.31.85 Subject: [Qemu-devel] [PATCH 10/29] vmsvga: Remove treatment of deprecated commands as Nop X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: habkost@redhat.com, mtosatti@redhat.com, Liran Alon , kraxel@redhat.com, pbonzini@redhat.com, rth@twiddle.net, Leonid Shatz Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Leonid Shatz Remove switch-case invalid handling of SVGA_CMD_SURFACE_FILL and SVGA_CMD_SURFACE_COPY deprecated commands as their handling is obviously not complete. We'd rather leave it to default (unknown) command handling and have an error message displayed. Signed-off-by: Leonid Shatz Reviewed-by: Darren Kenny Signed-off-by: Liran Alon --- hw/display/vmware_vga.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c index b32a625ae9c2..c30ae9b4b204 100644 --- a/hw/display/vmware_vga.c +++ b/hw/display/vmware_vga.c @@ -780,8 +780,6 @@ static void vmsvga_fifo_run(struct vmsvga_state_s *s) * Other commands that are not listed as depending on any * CAPABILITIES bits, but are not described in the README either. */ - case SVGA_CMD_SURFACE_FILL: - case SVGA_CMD_SURFACE_COPY: case SVGA_CMD_INVALID_CMD: break; /* Nop */