From patchwork Thu Aug 9 11:46:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liran Alon X-Patchwork-Id: 10561297 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B954A157B for ; Thu, 9 Aug 2018 11:59:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A3D932AE89 for ; Thu, 9 Aug 2018 11:59:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 97A382AEB9; Thu, 9 Aug 2018 11:59:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 17F982AE89 for ; Thu, 9 Aug 2018 11:59:26 +0000 (UTC) Received: from localhost ([::1]:50079 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnjbB-0007VT-BI for patchwork-qemu-devel@patchwork.kernel.org; Thu, 09 Aug 2018 07:59:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnjPK-0004iO-VE for qemu-devel@nongnu.org; Thu, 09 Aug 2018 07:47:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnjPI-00073V-5D for qemu-devel@nongnu.org; Thu, 09 Aug 2018 07:47:10 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:47914) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fnjPH-00073F-R2 for qemu-devel@nongnu.org; Thu, 09 Aug 2018 07:47:08 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w79BivQ2163150; Thu, 9 Aug 2018 11:47:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2018-07-02; bh=lqiWefVTBKsNtGwi9yjv2AYEWEbXwvp+adxugaE4+4A=; b=iKds3tTnDNUAtJG14l0RtJTMrGwGH0ivxo+PfP/mhmRvMqi1Qvd5cG5QfUG1n6babOdo WVtflgtE+sj+wx8rjenTdRPjnWdZAMEwwVdEIep6oPl12IKLcy9RDbGNDvk6NN5a2Ehf QkBmt66hggWDSAzShmuK2EvyR5051WIqqEkC8antzFrLgWvYDB11SOBsib+3+camDgqi uUAsv/mx2EMHEfPHy6WleXItJ697uHtY5q4mQNELVMnalUOlF7nt2g2e10Ijs4Y4AE2R cFUd1AXetK1TOj/AVmAbUpgnIsgsd+LLqjKpcIyxTM9j10rC5lCdZYyiPktxtLzzak06 Sg== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2130.oracle.com with ESMTP id 2kn1ndaxxr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 09 Aug 2018 11:47:06 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w79Bl5qV005797 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 9 Aug 2018 11:47:05 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w79Bl5j2030966; Thu, 9 Aug 2018 11:47:05 GMT Received: from liran-pc.ravello.local (/213.57.127.2) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 09 Aug 2018 04:47:05 -0700 From: Liran Alon To: qemu-devel@nongnu.org Date: Thu, 9 Aug 2018 14:46:16 +0300 Message-Id: <1533815202-11967-4-git-send-email-liran.alon@oracle.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1533815202-11967-1-git-send-email-liran.alon@oracle.com> References: <1533815202-11967-1-git-send-email-liran.alon@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8979 signatures=668707 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=3 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=870 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808090123 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 141.146.126.79 Subject: [Qemu-devel] [PATCH 03/29] vmsvga: Explictly mark deprecated commands X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: habkost@redhat.com, mtosatti@redhat.com, Liran Alon , kraxel@redhat.com, pbonzini@redhat.com, rth@twiddle.net, Leonid Shatz Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Leonid Shatz These commands are neither mentioned nor documented in VMware SVGA development-kit and Linux vmware-svga driver source code. Thus, they should be subject to future deletion, if not encountered in practice. Signed-off-by: Leonid Shatz Reviewed-by: Darren Kenny Signed-off-by: Liran Alon --- hw/display/vmware_vga.c | 56 ++++++++++++++++++++++++------------------------- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c index f8c5b64cfd7c..a244f43a866f 100644 --- a/hw/display/vmware_vga.c +++ b/hw/display/vmware_vga.c @@ -248,33 +248,33 @@ static const char *vmsvga_guest_id[] = { enum { SVGA_CMD_INVALID_CMD = 0, SVGA_CMD_UPDATE = 1, - SVGA_CMD_RECT_FILL = 2, + SVGA_CMD_RECT_FILL = 2, /* deprecated */ SVGA_CMD_RECT_COPY = 3, - SVGA_CMD_DEFINE_BITMAP = 4, - SVGA_CMD_DEFINE_BITMAP_SCANLINE = 5, - SVGA_CMD_DEFINE_PIXMAP = 6, - SVGA_CMD_DEFINE_PIXMAP_SCANLINE = 7, - SVGA_CMD_RECT_BITMAP_FILL = 8, - SVGA_CMD_RECT_PIXMAP_FILL = 9, - SVGA_CMD_RECT_BITMAP_COPY = 10, - SVGA_CMD_RECT_PIXMAP_COPY = 11, - SVGA_CMD_FREE_OBJECT = 12, - SVGA_CMD_RECT_ROP_FILL = 13, - SVGA_CMD_RECT_ROP_COPY = 14, - SVGA_CMD_RECT_ROP_BITMAP_FILL = 15, - SVGA_CMD_RECT_ROP_PIXMAP_FILL = 16, - SVGA_CMD_RECT_ROP_BITMAP_COPY = 17, - SVGA_CMD_RECT_ROP_PIXMAP_COPY = 18, + SVGA_CMD_DEFINE_BITMAP = 4, /* deprecated */ + SVGA_CMD_DEFINE_BITMAP_SCANLINE = 5, /* deprecated */ + SVGA_CMD_DEFINE_PIXMAP = 6, /* deprecated */ + SVGA_CMD_DEFINE_PIXMAP_SCANLINE = 7, /* deprecated */ + SVGA_CMD_RECT_BITMAP_FILL = 8, /* deprecated */ + SVGA_CMD_RECT_PIXMAP_FILL = 9, /* deprecated */ + SVGA_CMD_RECT_BITMAP_COPY = 10, /* deprecated */ + SVGA_CMD_RECT_PIXMAP_COPY = 11, /* deprecated */ + SVGA_CMD_FREE_OBJECT = 12, /* deprecated */ + SVGA_CMD_RECT_ROP_FILL = 13, /* deprecated */ + SVGA_CMD_RECT_ROP_COPY = 14, /* deprecated */ + SVGA_CMD_RECT_ROP_BITMAP_FILL = 15, /* deprecated */ + SVGA_CMD_RECT_ROP_PIXMAP_FILL = 16, /* deprecated */ + SVGA_CMD_RECT_ROP_BITMAP_COPY = 17, /* deprecated */ + SVGA_CMD_RECT_ROP_PIXMAP_COPY = 18, /* deprecated */ SVGA_CMD_DEFINE_CURSOR = 19, - SVGA_CMD_DISPLAY_CURSOR = 20, - SVGA_CMD_MOVE_CURSOR = 21, + SVGA_CMD_DISPLAY_CURSOR = 20, /* deprecated */ + SVGA_CMD_MOVE_CURSOR = 21, /* deprecated */ SVGA_CMD_DEFINE_ALPHA_CURSOR = 22, - SVGA_CMD_DRAW_GLYPH = 23, - SVGA_CMD_DRAW_GLYPH_CLIPPED = 24, + SVGA_CMD_DRAW_GLYPH = 23, /* deprecated */ + SVGA_CMD_DRAW_GLYPH_CLIPPED = 24, /* deprecated */ SVGA_CMD_UPDATE_VERBOSE = 25, - SVGA_CMD_SURFACE_FILL = 26, - SVGA_CMD_SURFACE_COPY = 27, - SVGA_CMD_SURFACE_ALPHA_BLEND = 28, + SVGA_CMD_SURFACE_FILL = 26, /* deprecated */ + SVGA_CMD_SURFACE_COPY = 27, /* deprecated */ + SVGA_CMD_SURFACE_ALPHA_BLEND = 28, /* deprecated */ SVGA_CMD_FRONT_ROP_FILL = 29, SVGA_CMD_FENCE = 30, }; @@ -692,7 +692,7 @@ static void vmsvga_fifo_run(struct vmsvga_state_s *s) * If they are not encountered in real world scenarious, they should be * completely removed. */ - case SVGA_CMD_RECT_FILL: + case SVGA_CMD_RECT_FILL: /* deprecated */ len -= 6; if (len < 0) { goto rewind; @@ -715,10 +715,10 @@ static void vmsvga_fifo_run(struct vmsvga_state_s *s) * Unimplemented commands that we gracefully skip their * arguments so we can avoid FIFO desync */ - case SVGA_CMD_RECT_ROP_FILL: + case SVGA_CMD_RECT_ROP_FILL: /* deprecated */ args = 6; goto badcmd; - case SVGA_CMD_RECT_ROP_COPY: + case SVGA_CMD_RECT_ROP_COPY: /* deprecated */ args = 7; goto badcmd; case SVGA_CMD_DEFINE_ALPHA_CURSOR: @@ -733,7 +733,7 @@ static void vmsvga_fifo_run(struct vmsvga_state_s *s) y = vmsvga_fifo_read(s); args = x * y; goto badcmd; - case SVGA_CMD_DRAW_GLYPH_CLIPPED: + case SVGA_CMD_DRAW_GLYPH_CLIPPED: /* deprecated */ len -= 4; if (len < 0) { goto rewind; @@ -742,7 +742,7 @@ static void vmsvga_fifo_run(struct vmsvga_state_s *s) vmsvga_fifo_read(s); args = 7 + (vmsvga_fifo_read(s) >> 2); goto badcmd; - case SVGA_CMD_SURFACE_ALPHA_BLEND: + case SVGA_CMD_SURFACE_ALPHA_BLEND: /* deprecated */ args = 12; goto badcmd;