From patchwork Fri Sep 21 14:25:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brijesh Singh X-Patchwork-Id: 10610181 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 77B986CB for ; Fri, 21 Sep 2018 14:30:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 684442E210 for ; Fri, 21 Sep 2018 14:30:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 62FDA2E18C; Fri, 21 Sep 2018 14:30:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DA2E02E218 for ; Fri, 21 Sep 2018 14:30:51 +0000 (UTC) Received: from localhost ([::1]:55928 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3MSJ-0006d0-45 for patchwork-qemu-devel@patchwork.kernel.org; Fri, 21 Sep 2018 10:30:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3MNQ-0001f0-D1 for qemu-devel@nongnu.org; Fri, 21 Sep 2018 10:25:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3MNM-0001Ju-94 for qemu-devel@nongnu.org; Fri, 21 Sep 2018 10:25:48 -0400 Received: from mail-bn3nam01on0066.outbound.protection.outlook.com ([104.47.33.66]:15887 helo=NAM01-BN3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g3MNM-0001Je-0o for qemu-devel@nongnu.org; Fri, 21 Sep 2018 10:25:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2dNDHEOgEcivD+3M/xCB8F3YzN9XM9RYg6/BCMrdUW4=; b=1EbSgxqe6R8S+eIVQaW3t+Zuwq8NvTAwQJ35242Ht8KMHqLLqSvlLlsVs0nZx+4qKPbbyOzi1TbhQeWC+56OtGhdgbukXOOPWswiFEFFEqmdXXFq9zyM9NPf2LrRVglLurAX9kPTyktMmYHO1APREQ5OpILflfEuiZr+DBSH2aI= Received: from DM6PR12MB2682.namprd12.prod.outlook.com (20.176.116.31) by DM6PR12MB2651.namprd12.prod.outlook.com (20.176.116.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Fri, 21 Sep 2018 14:25:41 +0000 Received: from DM6PR12MB2682.namprd12.prod.outlook.com ([fe80::7c34:f2e8:a8a9:cab8]) by DM6PR12MB2682.namprd12.prod.outlook.com ([fe80::7c34:f2e8:a8a9:cab8%2]) with mapi id 15.20.1143.017; Fri, 21 Sep 2018 14:25:41 +0000 From: "Singh, Brijesh" To: "qemu-devel@nongnu.org" Thread-Topic: [PATCH v3 7/9] i386: acpi: add IVHD device entry for IOAPIC Thread-Index: AQHUUbb5nccU2EJXLk6eKcmdoj0+Kw== Date: Fri, 21 Sep 2018 14:25:41 +0000 Message-ID: <1537539920-30662-8-git-send-email-brijesh.singh@amd.com> References: <1537539920-30662-1-git-send-email-brijesh.singh@amd.com> In-Reply-To: <1537539920-30662-1-git-send-email-brijesh.singh@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: DM5PR21CA0008.namprd21.prod.outlook.com (2603:10b6:3:ac::18) To DM6PR12MB2682.namprd12.prod.outlook.com (2603:10b6:5:4a::31) authentication-results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [165.204.77.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM6PR12MB2651; 20:0J52mhAVFaregV4/sHF97HNmVjKe69BhCuleJ93t0nymAumbsCn5aR7uII47vPfTkT4dhmDq73jX2qeJEJLTsXKpLolOu/op9L4ykNMU12MWK24lfji19+NstjUv8mb2VcBCyqmwxJ58yeeZ06FaAz3QfZW9GV1G6TEhUdANrQ4X6aZ9MSsYH8ldeHsL97bds21/RUccn6e7C3w26nnCiCl12xMsDUqvHYdQHuMbkFVbzmVKNdES+Xmm7LAxkCdr x-ms-office365-filtering-correlation-id: 5cd22e8a-a12f-41ba-bced-08d61fce1ba0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DM6PR12MB2651; x-ms-traffictypediagnostic: DM6PR12MB2651: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(85827821059158)(767451399110); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301075)(93006095)(93001095)(3002001)(3231355)(944501410)(52105095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123560045)(201708071742011)(7699051); SRVR:DM6PR12MB2651; BCL:0; PCL:0; RULEID:; SRVR:DM6PR12MB2651; x-forefront-prvs: 0802ADD973 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(39860400002)(366004)(346002)(376002)(199004)(189003)(6512007)(81166006)(5250100002)(2501003)(14444005)(256004)(486006)(11346002)(446003)(3846002)(39060400002)(8676002)(2351001)(186003)(8936002)(6116002)(2616005)(5640700003)(2906002)(6306002)(53936002)(66066001)(81156014)(25786009)(6436002)(99286004)(68736007)(105586002)(476003)(6486002)(86362001)(6916009)(305945005)(2900100001)(5660300001)(316002)(7736002)(106356001)(26005)(478600001)(76176011)(36756003)(386003)(52116002)(6506007)(966005)(54906003)(4326008)(102836004)(14454004)(71190400001)(97736004)(71200400001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR12MB2651; H:DM6PR12MB2682.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: plEq1np2VxkI8+ddwxlxMmofTcyeNWnFCjZZbHCUnXp4C+GpeZ99gthTAgmvgMSTRNV04KrsZ31Hi0teOIo8atQnjF4kKcByN8hh9+7JxFC6IVlfjvGBpnQV+n1nvMjWJx2gLmgMyi/upHxoTIEQmX5roVlmVug4ZNo18/9Ytg30nYJfLfjrCcBmMP90mlMhk/y65VRNHxhD2vFlVF7UlduamIBYaI9IEQsIYlKSxMiMsF9QJXi5SFDu4l48nhNrAuCUXVtYVCpACLOc041HohFXbKkkp+D8uWx9FWETp0fVMEvQ9tiqVMk5JTz8OzjcaQPwJuautX1rH/OLYTFHQy5M8uh1kFWxypxjXOnTuP4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5cd22e8a-a12f-41ba-bced-08d61fce1ba0 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2018 14:25:41.1903 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2651 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.33.66 Subject: [Qemu-devel] [PATCH v3 7/9] i386: acpi: add IVHD device entry for IOAPIC X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Lendacky, Thomas" , "Singh, Brijesh" , Eduardo Habkost , "Michael S. Tsirkin" , Peter Xu , Paolo Bonzini , "Suthikulpanit, Suravee" , Richard Henderson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP When interrupt remapping is enabled, add a special IVHD device (type IOAPIC). Signed-off-by: Brijesh Singh Cc: Peter Xu Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: Tom Lendacky Cc: Suravee Suthikulpanit --- hw/i386/acpi-build.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index e1ee8ae..21c99a1 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -2516,9 +2516,12 @@ build_dmar_q35(GArray *table_data, BIOSLinker *linker) * IVRS table as specified in AMD IOMMU Specification v2.62, Section 5.2 * accessible here http://support.amd.com/TechDocs/48882_IOMMU.pdf */ +#define IOAPIC_SB_DEVID (uint64_t)PCI_BUILD_BDF(0, PCI_DEVFN(0x14, 0)) + static void build_amd_iommu(GArray *table_data, BIOSLinker *linker) { + int ivhd_table_len = 28; int iommu_start = table_data->len; AMDVIState *s = AMD_IOMMU_DEVICE(x86_iommu_get_default()); @@ -2540,8 +2543,16 @@ build_amd_iommu(GArray *table_data, BIOSLinker *linker) (1UL << 6) | /* PrefSup */ (1UL << 7), /* PPRSup */ 1); + + /* + * When interrupt remapping is supported, we add a special IVHD device + * for type IO-APIC. + */ + if (x86_iommu_get_default()->intr_supported) { + ivhd_table_len += 8; + } /* IVHD length */ - build_append_int_noprefix(table_data, 28, 2); + build_append_int_noprefix(table_data, ivhd_table_len, 2); /* DeviceID */ build_append_int_noprefix(table_data, s->devid, 2); /* Capability offset */ @@ -2565,6 +2576,21 @@ build_amd_iommu(GArray *table_data, BIOSLinker *linker) */ build_append_int_noprefix(table_data, 0x0000001, 4); + /* + * Add a special IVHD device type. + * Refer to spec - Table 95: IVHD device entry type codes + * + * Linux IOMMU driver checks for the special IVHD device (type IO-APIC). + * See Linux kernel commit 'c2ff5cf5294bcbd7fa50f7d860e90a66db7e5059' + */ + if (x86_iommu_get_default()->intr_supported) { + build_append_int_noprefix(table_data, + (0x1ull << 56) | /* type IOAPIC */ + (IOAPIC_SB_DEVID << 40) | /* IOAPIC devid */ + 0x48, /* special device */ + 8); + } + build_header(linker, table_data, (void *)(table_data->data + iommu_start), "IVRS", table_data->len - iommu_start, 1, NULL, NULL); }