From patchwork Sat Mar 9 07:48:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 10845847 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8C2901390 for ; Sat, 9 Mar 2019 08:06:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 78B512DB37 for ; Sat, 9 Mar 2019 08:06:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6A70B2DB3B; Sat, 9 Mar 2019 08:06:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F3EA02DB37 for ; Sat, 9 Mar 2019 08:06:39 +0000 (UTC) Received: from localhost ([127.0.0.1]:55553 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2X0B-0001h0-Az for patchwork-qemu-devel@patchwork.kernel.org; Sat, 09 Mar 2019 03:06:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2Wih-0003t9-4b for qemu-devel@nongnu.org; Sat, 09 Mar 2019 02:48:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2Wig-0000Wh-C1 for qemu-devel@nongnu.org; Sat, 09 Mar 2019 02:48:35 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:54879) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h2Wig-0000Tc-3n for qemu-devel@nongnu.org; Sat, 09 Mar 2019 02:48:34 -0500 Received: by mail-wm1-x329.google.com with SMTP id f3so14573501wmj.4 for ; Fri, 08 Mar 2019 23:48:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=6zDQbSwZUxX7y2jiQ2tcr21YfVkxewJV+Z414eERG8A=; b=MlZgtHqDZr51IRmG9rlZBG5SqmmwrP5Yp54mUi5z8dtR4x0Hxaiu6EOF/2i05BKb/Y ze5HQBjS16Dn8ZptKIB7yKraQWjQzEDP3DwzBtEMWFPz7CefrWnZFyz24XGYSRtfrWxY 83mF5/tCwlN9hjCNz/ATw62zO8ZIt3A5LcaxKQ84tCa4jm6HuZHUOPMA1SF9PhFhEDMZ 7gzWlMwnhZmEfQmpc/vmhU+3V6e08iLr+avSL1wr6ff4zqinKMforyiSmn5nxl+sSZ21 1rwrHCZmytC0EFFDGR0hjMx53kkCsT0quasO3eLNcOLqPDrZAscNfx/fOR/YCvqqgT1F kvSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=6zDQbSwZUxX7y2jiQ2tcr21YfVkxewJV+Z414eERG8A=; b=QTjEtXwUYXlaTRhhrcCB/8nz+ngZKAghxhW8niWY7t0CwwV7DfyNbH2j+/xAa56o1s pia5mIa2EgqhgU/UENQtAd1Mf8I14UkhCTAQMXLRk8VPcE0A3UxIHp+oVqRTanlRFY/f SjH2OAEnKFjPZkbmnaeX9NoCOh02FYWQavWikNLnm0XaPVOKco/1/+bQcYVv1nRviJm5 TsrUBL11b/gY6JycZ+9sP8ysFsg9TfSPD2y3k/xEudcP9+ll5mg7Lrz6bfqcU+I3xVbt bdTdt3taqfFshkS6OWZx0GuwVAUrf1WryT0taYbg8nVZAI9S8pyProkHOJSAcO6bhN52 SiEg== X-Gm-Message-State: APjAAAURQj0R1YV46W6kc/xXeUbAD9Q1mwA/WZWq1ni1H4hjtrxlgwjq b1XHLdXrIIPUCtcoLA9XaqVj8jbn X-Google-Smtp-Source: APXvYqyr962ZyFZMnhBMd6KI65iRLrx4jibfEE+Ta99PaDwdfc/iwm+cP5T27Eyfwwyu0bK+9qUUBQ== X-Received: by 2002:a1c:7e58:: with SMTP id z85mr11701852wmc.52.1552117710311; Fri, 08 Mar 2019 23:48:30 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id 11sm5252294wmg.27.2019.03.08.23.48.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 23:48:29 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sat, 9 Mar 2019 08:48:04 +0100 Message-Id: <1552117698-12355-12-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1552117698-12355-1-git-send-email-pbonzini@redhat.com> References: <1552117698-12355-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::329 Subject: [Qemu-devel] [PULL 11/25] lsi: check if SIGP bit is already set in Wait reselect X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sven Schnelle Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Sven Schnelle If SIGP is set, the 'Wait for Reselection' command should jump immediately to the address stored in the second DWORD of the instruction. This fixes spurious hangs in the HP-UX 11.11 installer when the SIGP bit gets set by the kernel before the 'Wait for Reselection' command is executed by SCRIPTS. Signed-off-by: Sven Schnelle Tested-by: Helge Deller Message-Id: <20190217113717.7077-1-svens@stackframe.org> Signed-off-by: Paolo Bonzini --- hw/scsi/lsi53c895a.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 8ba07f8..bcff859 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -1297,8 +1297,10 @@ again: } break; case 2: /* Wait Reselect */ - if (!lsi_irq_on_rsl(s)) { - lsi_wait_reselect(s); + if (s->istat0 & LSI_ISTAT0_SIGP) { + s->dsp = s->dnad; + } else if (!lsi_irq_on_rsl(s)) { + lsi_wait_reselect(s); } break; case 3: /* Set */