Message ID | 1552381594-5437-1-git-send-email-thuth@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Patchew URL: https://patchew.org/QEMU/1552381594-5437-1-git-send-email-thuth@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1552381594-5437-1-git-send-email-thuth@redhat.com Subject: [Qemu-devel] [PULL 0/4] qtest and misc patches === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1552381594-5437-1-git-send-email-thuth@redhat.com -> patchew/1552381594-5437-1-git-send-email-thuth@redhat.com Switched to a new branch 'test' fe3629e622 scripts/qemugdb: re-license timers.py to GPLv2 or later e0ee3d52c9 hw/sd/sdhci: Move PCI-related code into a separate file 87fcefd5ed ahci-test: Drop dependence on global_qtest 3c1dda5ace tests: test-announce-self: fix memory leak === OUTPUT BEGIN === 1/4 Checking commit 3c1dda5aceb9 (tests: test-announce-self: fix memory leak) 2/4 Checking commit 87fcefd5edf2 (ahci-test: Drop dependence on global_qtest) 3/4 Checking commit e0ee3d52c944 (hw/sd/sdhci: Move PCI-related code into a separate file) ERROR: Macros with complex values should be enclosed in parenthesis #76: FILE: hw/sd/sdhci-internal.h:326: +#define DEFINE_SDHCI_COMMON_PROPERTIES(_state) \ + DEFINE_PROP_UINT8("sd-spec-version", _state, sd_spec_version, 2), \ + DEFINE_PROP_UINT8("uhs", _state, uhs_mode, UHS_NOT_SUPPORTED), \ + \ + /* Capabilities registers provide information on supported WARNING: Block comments use a leading /* on a separate line #80: FILE: hw/sd/sdhci-internal.h:330: + /* Capabilities registers provide information on supported WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #93: new file mode 100644 total: 1 errors, 2 warnings, 290 lines checked Patch 3/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/4 Checking commit fe3629e62258 (scripts/qemugdb: re-license timers.py to GPLv2 or later) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1552381594-5437-1-git-send-email-thuth@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1552381594-5437-1-git-send-email-thuth@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1552381594-5437-1-git-send-email-thuth@redhat.com Subject: [Qemu-devel] [PULL 0/4] qtest and misc patches === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/1552381594-5437-1-git-send-email-thuth@redhat.com -> patchew/1552381594-5437-1-git-send-email-thuth@redhat.com Switched to a new branch 'test' 11a3092922 scripts/qemugdb: re-license timers.py to GPLv2 or later 8d3aa7f056 hw/sd/sdhci: Move PCI-related code into a separate file edd61393eb ahci-test: Drop dependence on global_qtest 4d3b0ea23c tests: test-announce-self: fix memory leak === OUTPUT BEGIN === 1/4 Checking commit 4d3b0ea23c5e (tests: test-announce-self: fix memory leak) 2/4 Checking commit edd61393eb02 (ahci-test: Drop dependence on global_qtest) 3/4 Checking commit 8d3aa7f05695 (hw/sd/sdhci: Move PCI-related code into a separate file) ERROR: Macros with complex values should be enclosed in parenthesis #76: FILE: hw/sd/sdhci-internal.h:326: +#define DEFINE_SDHCI_COMMON_PROPERTIES(_state) \ + DEFINE_PROP_UINT8("sd-spec-version", _state, sd_spec_version, 2), \ + DEFINE_PROP_UINT8("uhs", _state, uhs_mode, UHS_NOT_SUPPORTED), \ + \ + /* Capabilities registers provide information on supported WARNING: Block comments use a leading /* on a separate line #80: FILE: hw/sd/sdhci-internal.h:330: + /* Capabilities registers provide information on supported WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #93: new file mode 100644 total: 1 errors, 2 warnings, 290 lines checked Patch 3/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/4 Checking commit 11a309292223 (scripts/qemugdb: re-license timers.py to GPLv2 or later) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1552381594-5437-1-git-send-email-thuth@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Tue, 12 Mar 2019 at 09:06, Thomas Huth <thuth@redhat.com> wrote: > > Hi Peter, > > the following changes since commit 377b155bde451d5ac545fbdcdfbf6ca17a4228f5: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2019-03-11 18:26:37 +0000) > > are available in the git repository at: > > > https://gitlab.com/huth/qemu.git tags/pull-request-2019-03-12 > > for you to fetch changes up to 390947ed2a7e5e84fa912f275ac20eac48d2f8ca: > > scripts/qemugdb: re-license timers.py to GPLv2 or later (2019-03-12 08:04:22 +0100) > > ---------------------------------------------------------------- > - qtest patches > - One SD patch (with Reviewed-by from the maintainer) > - One license fix patch > ---------------------------------------------------------------- Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0 for any user-visible changes. -- PMM