mbox

[PULL,v2,00/25] Misc (mostly x86) patches for 2019-06-21

Message ID 1561116620-22245-1-git-send-email-pbonzini@redhat.com (mailing list archive)
State New, archived
Headers show

Pull-request

git://github.com/bonzini/qemu.git tags/for-upstream

Message

Paolo Bonzini June 21, 2019, 11:29 a.m. UTC 
The following changes since commit 33d609990621dea6c7d056c86f707b8811320ac1:

  Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-06-18 17:00:52 +0100)

are available in the git repository at:


  git://github.com/bonzini/qemu.git tags/for-upstream

for you to fetch changes up to 8e8cbed09ad9d577955691b4c061b61b602406d1:

  hw: Nuke hw_compat_4_0_1 and pc_compat_4_0_1 (2019-06-21 13:25:29 +0200)

----------------------------------------------------------------
* Nuke hw_compat_4_0_1 and pc_compat_4_0_1 (Greg)
* Static analysis fixes (Igor, Lidong)
* X86 Hyper-V CPUID improvements (Vitaly)
* X86 nested virt migration (Liran)
* New MSR-based features (Xiaoyao)

----------------------------------------------------------------
Colin Xu (1):
      hax: Honor CPUState::halted

Greg Kurz (1):
      hw: Nuke hw_compat_4_0_1 and pc_compat_4_0_1

Lidong Chen (2):
      sd: Fix out-of-bounds assertions
      util/main-loop: Fix incorrect assertion

Liran Alon (10):
      target/i386: kvm: Delete VMX migration blocker on vCPU init failure
      KVM: Introduce kvm_arch_destroy_vcpu()
      target/i386: kvm: Use symbolic constant for #DB/#BP exception constants
      target/i386: kvm: Re-inject #DB to guest with updated DR6
      target/i386: kvm: Block migration for vCPUs exposed with nested virtualization
      linux-headers: sync with latest KVM headers from Linux 5.2
      vmstate: Add support for kernel integer types
      target/i386: kvm: Add support for save and restore nested state
      target/i386: kvm: Add support for KVM_CAP_EXCEPTION_PAYLOAD
      target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities

Vitaly Kuznetsov (9):
      i386/kvm: convert hyperv enlightenments properties from bools to bits
      i386/kvm: add support for KVM_GET_SUPPORTED_HV_CPUID
      i386/kvm: move Hyper-V CPUID filling to hyperv_handle_properties()
      i386/kvm: document existing Hyper-V enlightenments
      i386/kvm: implement 'hv-passthrough' mode
      i386/kvm: hv-stimer requires hv-time and hv-synic
      i386/kvm: hv-tlbflush/ipi require hv-vpindex
      i386/kvm: hv-evmcs requires hv-vapic
      i386/kvm: add support for Direct Mode for Hyper-V synthetic timers

Xiaoyao Li (1):
      target/i386: define a new MSR based feature word - FEAT_CORE_CAPABILITY

Yury Kotov (1):
      kvm-all: Add/update fprintf's for kvm_*_ioeventfd_del

 accel/kvm/kvm-all.c         |  25 +-
 cpus.c                      |   1 -
 docs/hyperv.txt             | 201 +++++++++
 hw/core/machine.c           |   5 +-
 hw/i386/pc.c                |   6 +-
 hw/i386/pc_q35.c            |  12 +-
 hw/sd/sd.c                  |   4 +-
 include/hw/boards.h         |   3 -
 include/hw/i386/pc.h        |   3 -
 include/migration/vmstate.h |  26 ++
 include/sysemu/kvm.h        |   2 +
 linux-headers/asm-x86/kvm.h |  33 +-
 target/arm/kvm32.c          |   5 +
 target/arm/kvm64.c          |   5 +
 target/i386/cpu.c           |  81 +++-
 target/i386/cpu.h           |  65 ++-
 target/i386/hax-all.c       |  36 +-
 target/i386/hvf/hvf.c       |  10 +-
 target/i386/hvf/x86hvf.c    |   4 +-
 target/i386/hyperv-proto.h  |   1 +
 target/i386/hyperv.c        |   2 +-
 target/i386/kvm.c           | 999 +++++++++++++++++++++++++++++++++-----------
 target/i386/machine.c       | 284 ++++++++++++-
 target/mips/kvm.c           |   5 +
 target/ppc/kvm.c            |   5 +
 target/s390x/kvm.c          |  10 +
 util/main-loop.c            |   2 +-
 27 files changed, 1506 insertions(+), 329 deletions(-)
 create mode 100644 docs/hyperv.txt

Comments

no-reply@patchew.org June 21, 2019, 1:53 p.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/1561116620-22245-1-git-send-email-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PULL v2 00/25] Misc (mostly x86) patches for 2019-06-21
Message-id: 1561116620-22245-1-git-send-email-pbonzini@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20190621132324.2165-1-mreitz@redhat.com -> patchew/20190621132324.2165-1-mreitz@redhat.com
Switched to a new branch 'test'
cf66e55 hw: Nuke hw_compat_4_0_1 and pc_compat_4_0_1
6c88e3a util/main-loop: Fix incorrect assertion
13371b1 sd: Fix out-of-bounds assertions
0b837d9 target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities
1583048 target/i386: kvm: Add support for KVM_CAP_EXCEPTION_PAYLOAD
4e4d392 target/i386: kvm: Add support for save and restore nested state
c952fd2 vmstate: Add support for kernel integer types
be0bc2a linux-headers: sync with latest KVM headers from Linux 5.2
fcc123c target/i386: kvm: Block migration for vCPUs exposed with nested virtualization
ff0e7df target/i386: kvm: Re-inject #DB to guest with updated DR6
b03c3ff target/i386: kvm: Use symbolic constant for #DB/#BP exception constants
67ea33b KVM: Introduce kvm_arch_destroy_vcpu()
9e26b32 target/i386: kvm: Delete VMX migration blocker on vCPU init failure
7020f89 target/i386: define a new MSR based feature word - FEAT_CORE_CAPABILITY
3a0d495 i386/kvm: add support for Direct Mode for Hyper-V synthetic timers
6a7127a i386/kvm: hv-evmcs requires hv-vapic
c7514b4 i386/kvm: hv-tlbflush/ipi require hv-vpindex
51cdfac i386/kvm: hv-stimer requires hv-time and hv-synic
1f02e73 i386/kvm: implement 'hv-passthrough' mode
aeaf6f8 i386/kvm: document existing Hyper-V enlightenments
82d1c81 i386/kvm: move Hyper-V CPUID filling to hyperv_handle_properties()
f5e0932 i386/kvm: add support for KVM_GET_SUPPORTED_HV_CPUID
b0b89da i386/kvm: convert hyperv enlightenments properties from bools to bits
d49efb1 hax: Honor CPUState::halted
113cfe4 kvm-all: Add/update fprintf's for kvm_*_ioeventfd_del

=== OUTPUT BEGIN ===
1/25 Checking commit 113cfe429a07 (kvm-all: Add/update fprintf's for kvm_*_ioeventfd_del)
2/25 Checking commit d49efb131de1 (hax: Honor CPUState::halted)
WARNING: Block comments use a leading /* on a separate line
#77: FILE: target/i386/hax-all.c:479:
+    /* After a vcpu is halted (either because it is an AP and has just been

WARNING: Block comments use a leading /* on a separate line
#109: FILE: target/i386/hax-all.c:519:
+        /* If this vcpu is halted, we must not ask HAXM to run it. Instead, we

total: 0 errors, 2 warnings, 60 lines checked

Patch 2/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/25 Checking commit b0b89daa3c59 (i386/kvm: convert hyperv enlightenments properties from bools to bits)
4/25 Checking commit f5e09320671b (i386/kvm: add support for KVM_GET_SUPPORTED_HV_CPUID)
5/25 Checking commit 82d1c8147a54 (i386/kvm: move Hyper-V CPUID filling to hyperv_handle_properties())
6/25 Checking commit aeaf6f88598f (i386/kvm: document existing Hyper-V enlightenments)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

total: 0 errors, 1 warnings, 181 lines checked

Patch 6/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/25 Checking commit 1f02e738d953 (i386/kvm: implement 'hv-passthrough' mode)
8/25 Checking commit 51cdfac4fca3 (i386/kvm: hv-stimer requires hv-time and hv-synic)
9/25 Checking commit c7514b44e2d0 (i386/kvm: hv-tlbflush/ipi require hv-vpindex)
10/25 Checking commit 6a7127a97552 (i386/kvm: hv-evmcs requires hv-vapic)
11/25 Checking commit 3a0d49524898 (i386/kvm: add support for Direct Mode for Hyper-V synthetic timers)
12/25 Checking commit 7020f89f2f08 (target/i386: define a new MSR based feature word - FEAT_CORE_CAPABILITY)
13/25 Checking commit 9e26b329c385 (target/i386: kvm: Delete VMX migration blocker on vCPU init failure)
14/25 Checking commit 67ea33bcc49e (KVM: Introduce kvm_arch_destroy_vcpu())
ERROR: code indent should never use tabs
#61: FILE: target/arm/kvm32.c:245:
+^Ireturn 0;$

ERROR: g_free(NULL) is safe this check is probably not required
#96: FILE: target/i386/kvm.c:1687:
+    if (cpu->kvm_msr_buf) {
+        g_free(cpu->kvm_msr_buf);

total: 2 errors, 0 warnings, 96 lines checked

Patch 14/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/25 Checking commit b03c3ffbb26e (target/i386: kvm: Use symbolic constant for #DB/#BP exception constants)
16/25 Checking commit ff0e7dfa1207 (target/i386: kvm: Re-inject #DB to guest with updated DR6)
17/25 Checking commit fcc123ca5c8e (target/i386: kvm: Block migration for vCPUs exposed with nested virtualization)
18/25 Checking commit be0bc2a41ca8 (linux-headers: sync with latest KVM headers from Linux 5.2)
19/25 Checking commit c952fd2398ef (vmstate: Add support for kernel integer types)
20/25 Checking commit 4e4d392b5f30 (target/i386: kvm: Add support for save and restore nested state)
ERROR: g_free(NULL) is safe this check is probably not required
#130: FILE: target/i386/kvm.c:1712:
+    if (env->nested_state) {
+        g_free(env->nested_state);

ERROR: spaces required around that '*' (ctx:VxV)
#316: FILE: target/i386/machine.c:935:
+    .subsections = (const VMStateDescription*[]) {
                                             ^

ERROR: return is not a function, parentheses are not required
#345: FILE: target/i386/machine.c:964:
+    return (env->nested_state &&

ERROR: spaces required around that '*' (ctx:VxV)
#407: FILE: target/i386/machine.c:1026:
+    .subsections = (const VMStateDescription*[]) {
                                             ^

total: 4 errors, 0 warnings, 386 lines checked

Patch 20/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

21/25 Checking commit 158304885e51 (target/i386: kvm: Add support for KVM_CAP_EXCEPTION_PAYLOAD)
22/25 Checking commit 0b837d9595d8 (target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities)
23/25 Checking commit 13371b1ad995 (sd: Fix out-of-bounds assertions)
24/25 Checking commit 6c88e3a62741 (util/main-loop: Fix incorrect assertion)
25/25 Checking commit cf66e55c4dbe (hw: Nuke hw_compat_4_0_1 and pc_compat_4_0_1)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1561116620-22245-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Peter Maydell June 21, 2019, 2:40 p.m. UTC | #2 
On Fri, 21 Jun 2019 at 12:34, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> The following changes since commit 33d609990621dea6c7d056c86f707b8811320ac1:
>
>   Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-06-18 17:00:52 +0100)
>
> are available in the git repository at:
>
>
>   git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 8e8cbed09ad9d577955691b4c061b61b602406d1:
>
>   hw: Nuke hw_compat_4_0_1 and pc_compat_4_0_1 (2019-06-21 13:25:29 +0200)
>
> ----------------------------------------------------------------
> * Nuke hw_compat_4_0_1 and pc_compat_4_0_1 (Greg)
> * Static analysis fixes (Igor, Lidong)
> * X86 Hyper-V CPUID improvements (Vitaly)
> * X86 nested virt migration (Liran)
> * New MSR-based features (Xiaoyao)
>

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.1
for any user-visible changes.

-- PMM