From patchwork Wed Jan 8 12:32:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 11323431 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4A32592A for ; Wed, 8 Jan 2020 12:37:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20D11206DA for ; Wed, 8 Jan 2020 12:37:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qG6So0vT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20D11206DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:42850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipAa7-0000h6-Mm for patchwork-qemu-devel@patchwork.kernel.org; Wed, 08 Jan 2020 07:37:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60326) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipAWM-0003jc-7P for qemu-devel@nongnu.org; Wed, 08 Jan 2020 07:33:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipAWL-0004Iy-5e for qemu-devel@nongnu.org; Wed, 08 Jan 2020 07:33:10 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:39180) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ipAWK-0004Hi-W0 for qemu-devel@nongnu.org; Wed, 08 Jan 2020 07:33:09 -0500 Received: by mail-wm1-x330.google.com with SMTP id 20so2309129wmj.4 for ; Wed, 08 Jan 2020 04:33:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9PjzHiXwj1KdaDnPbGNelnRbOtkZ/aefiRl2myJ+BXU=; b=qG6So0vTYWa8iEipqHSW/GMHxSRvAPLp+/DMdd3nP/LiDn3/96/+9pSiH5fuLymK15 NTRWF4wfyq2RXShDKap9rNDY55q4As8+U/bicuF2PNwlxlTTCAUEqeD1/pn9Big+XjdP W7IkJETfB5i5rjO0+27KR8BafoHwVcLjeacRmfAyWpiN7oyelRFQpRQtBi7cuFOUnAmR 66M6PKSkucXlWDo8FNji8k+LSEZzt9jKJqGVSy1rV8Aa0/P0XHCRlQZMfm9Q9tJnu5ZM Dy4RoLuEQMlC3P5V0lApjJ/r7dZ4n47zsQadZ5GDmYinunaqaWfzWLH4XuIr9O9FI+Gw AgFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=9PjzHiXwj1KdaDnPbGNelnRbOtkZ/aefiRl2myJ+BXU=; b=KfcYQhep/rhcpfFy6UY0lvQMvvs1PMjQ3rGX+kn1jEYulbuUVN416hTRQxbixWrYS3 9DTyMdOJJaxYiBu1sSA9sQM1n6UcOvGK7Mdwf18oREFWkDdghh+rbv32p6mdx6o2ibVZ FNWtBsGfKYQ0DiPmmiKLeqnmM5x7rWA6eUEzQTVE1zi5uOpx4SJ01RVkAiQsx4TI19pS 3YplthEk2RMpoE4OHUnnVeHcuR52flJ+/1XkpBgNBehGluElpPxmaJoMNn7l9P298nas lOmmPUqfGyUG6oimFbvrrFYj5z6RVDlA5axUvGTX+6APaeJD+qmeti1nqkjJt64gMmry wwgg== X-Gm-Message-State: APjAAAU4tW1oTGEd02dNZNpEzNdARxcWJ/VQcDG65I3pqSiISbLxqDnd gwRZJ8c81pPE1kazaBXqEmqQl+Cc X-Google-Smtp-Source: APXvYqwnr9EgKFTIZwRM1eZSGaYf/HS5mTKgumPV9FVDnZWvJwv/VbGA1gybr6iSyYtMM4Uy3wwO7w== X-Received: by 2002:a7b:cfc2:: with SMTP id f2mr3624754wmm.44.1578486787776; Wed, 08 Jan 2020 04:33:07 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id o4sm4037750wrw.97.2020.01.08.04.33.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jan 2020 04:33:07 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 11/38] hw/i386/Kconfig: Let the MicroVM machine select the SERIAL_ISA config Date: Wed, 8 Jan 2020 13:32:28 +0100 Message-Id: <1578486775-52247-12-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1578486775-52247-1-git-send-email-pbonzini@redhat.com> References: <1578486775-52247-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::330 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé When configured with --without-default-devices, the build fails: LINK x86_64-softmmu/qemu-system-x86_64 /usr/bin/ld: hw/i386/microvm.o: in function `microvm_devices_init': hw/i386/microvm.c:157: undefined reference to `serial_hds_isa_init' collect2: error: ld returned 1 exit status make[1]: *** [Makefile:206: qemu-system-x86_64] Error 1 make: *** [Makefile:483: x86_64-softmmu/all] Error 2 While the MicroVM machine only uses the ISA serial port when the MICROVM_MACHINE_ISA_SERIAL property is set, it has to be linked with it. Replace the 'imply' Kconfig rule by a 'select'. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20191231183216.6781-4-philmd@redhat.com> Signed-off-by: Paolo Bonzini --- hw/i386/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 91cf584..cdc8515 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -95,7 +95,7 @@ config Q35 config MICROVM bool - imply SERIAL_ISA + select SERIAL_ISA # for serial_hds_isa_init() select ISA_BUS select APIC select IOAPIC