| Message ID | 1581521009-44121-1-git-send-email-pbonzini@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | target/i386: enable monitor and ucode revision with -cpu max | expand |
On Wed, Feb 12, 2020 at 04:23:29PM +0100, Paolo Bonzini wrote: > These two features were incorrectly tied to host_cpuid_required rather than > cpu->max_features. As a result, -cpu max was not enabling either MONITOR > features or ucode revision. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 32efa46..92fafa2 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -6414,7 +6414,9 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) error_setg(&local_err, "CPU model '%s' requires KVM", name); goto out; } + } + if (cpu->max_features && accel_uses_host_cpuid()) { if (enable_cpu_pm) { host_cpuid(5, 0, &cpu->mwait.eax, &cpu->mwait.ebx, &cpu->mwait.ecx, &cpu->mwait.edx);
These two features were incorrectly tied to host_cpuid_required rather than cpu->max_features. As a result, -cpu max was not enabling either MONITOR features or ucode revision. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- target/i386/cpu.c | 2 ++ 1 file changed, 2 insertions(+)