| Message ID | 158326544443.40452.17613849801643778536.stgit@naples-babu.amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | APIC ID fixes for AMD EPYC CPU model | expand |
On Tue, 03 Mar 2020 13:57:24 -0600 Babu Moger <babu.moger@amd.com> wrote: > The function pc_cpu_pre_plug takes care of initialization of CPUX86State. > So, remove the initialization here. > > Suggested-by: Igor Mammedov <imammedo@redhat.com> > Signed-off-by: Babu Moger <babu.moger@amd.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > hw/i386/x86.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/hw/i386/x86.c b/hw/i386/x86.c > index 03b8962c98..79badcc4ec 100644 > --- a/hw/i386/x86.c > +++ b/hw/i386/x86.c > @@ -103,13 +103,9 @@ void x86_cpu_new(X86MachineState *x86ms, int64_t apic_id, Error **errp) > { > Object *cpu = NULL; > Error *local_err = NULL; > - CPUX86State *env = NULL; > > cpu = object_new(MACHINE(x86ms)->cpu_type); > > - env = &X86_CPU(cpu)->env; > - env->nr_dies = x86ms->smp_dies; > - > object_property_set_uint(cpu, apic_id, "apic-id", &local_err); > object_property_set_bool(cpu, true, "realized", &local_err); > >
diff --git a/hw/i386/x86.c b/hw/i386/x86.c index 03b8962c98..79badcc4ec 100644 --- a/hw/i386/x86.c +++ b/hw/i386/x86.c @@ -103,13 +103,9 @@ void x86_cpu_new(X86MachineState *x86ms, int64_t apic_id, Error **errp) { Object *cpu = NULL; Error *local_err = NULL; - CPUX86State *env = NULL; cpu = object_new(MACHINE(x86ms)->cpu_type); - env = &X86_CPU(cpu)->env; - env->nr_dies = x86ms->smp_dies; - object_property_set_uint(cpu, apic_id, "apic-id", &local_err); object_property_set_bool(cpu, true, "realized", &local_err);
The function pc_cpu_pre_plug takes care of initialization of CPUX86State. So, remove the initialization here. Suggested-by: Igor Mammedov <imammedo@redhat.com> Signed-off-by: Babu Moger <babu.moger@amd.com> --- hw/i386/x86.c | 4 ---- 1 file changed, 4 deletions(-)