diff mbox series

[2/2] If we have more than one colo-compare, we can only destroy the lock when we delete the last one.

Message ID 1589191231-18876-2-git-send-email-quweijie@huayun.com (mailing list archive)
State New, archived
Headers show
Series [1/2] When del child, next_child_index need to subtract 1. Otherwise, the index will get bigger and bigger. | expand

Commit Message

quweijie@huayun.com May 11, 2020, 10 a.m. UTC 
From: quweijie <quweijie@huayun.com>

Signed-off-by: quweijie <quweijie@huayun.com>
---
 net/colo-compare.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/net/colo-compare.c b/net/colo-compare.c
index 10c0239..ee878f6 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -1313,8 +1313,10 @@  static void colo_compare_finalize(Object *obj)
         object_unref(OBJECT(s->iothread));
     }
 
-    qemu_mutex_destroy(&event_mtx);
-    qemu_cond_destroy(&event_complete_cond);
+    if(QTAILQ_EMPTY(&net_compares)) {
+        qemu_mutex_destroy(&event_mtx);
+        qemu_cond_destroy(&event_complete_cond);
+    }
 
     g_free(s->pri_indev);
     g_free(s->sec_indev);